From patchwork Sat Nov 18 09:33:47 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 10064649 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7985660230 for ; Sat, 18 Nov 2017 09:36:04 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6E62A2A682 for ; Sat, 18 Nov 2017 09:36:04 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 630EE2A873; Sat, 18 Nov 2017 09:36:04 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1422D2A682 for ; Sat, 18 Nov 2017 09:36:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=29Zq/HbE5tps07j+whTXpNd84UIihwIm2DxQBDxMzIA=; b=oVjE30vydzRvFBpgbqUKiWM3QD wvN+0RXXuEEcjKf0+nF4hyWVDKUSB5B0q3SsLKpEX/lvPWykdQTnMzIfeslOPEsBdb3qunzLrG055 4kB5RjB9gweYudWuvvMTBofjobDnd7G/nLB7jtKV5jV4eNuC4uwRwEQhDhtgcXL9KwHqa8iqmtNca AKAgDXkeUe2uV90+DJh6azDQRJgoKbsP/D8q1SszmrwmtzfJLQGA7OSdjO+q55QONIv0P2Pp/gyug zTD00IvNaSbKqwwTXCVXoWA6i9J5nnr2I9/c02Brteo/DDG1xUb4736GzM+L+iIX3n0+Ev/GK8seA ujTJnt5A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eFzXe-0001iv-O3; Sat, 18 Nov 2017 09:36:02 +0000 Received: from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eFzWV-0007iP-Iz; Sat, 18 Nov 2017 09:34:53 +0000 Received: by mail-pg0-x242.google.com with SMTP id l19so3761015pgo.2; Sat, 18 Nov 2017 01:34:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=BdyLi9FjKAcopuKRh9sSVffYvZNgeLxHTIjfX+hJpUg=; b=qW3mUncKV4+SOZJvrjLWNX2PKO1jvUtxsLlnrcqNo5LLKlrvra5nqeJw7vwBfuFm7O RvlTX8oINnRdg4HaWdM+60seqnCxIzS9frW6sduwalNYKpv6Mbp+p9DXfXWeZl/Tp1f/ W3VCc/HfbvN0SkRMwz14VdeNNLW8duwKc3qC3K//0pBrUuB5B1W6DEoZA+Qwtnaqv2ZB WnNV/T7Jw7+xDOo35K3R+fESpfp38tvFNfNgrLl6KLChK1oMsnpw5o+NmmOmbcY2xOyN l8oUWx7lTpn1eMUP47LTKX2bfaCbOfiiCDwCPHz0FJ7D82rQlUV83ukvuQQKA8Dwg74/ 46iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=BdyLi9FjKAcopuKRh9sSVffYvZNgeLxHTIjfX+hJpUg=; b=JbocGoGuXaezFbhJwETtC3E+CnjWsaRsfvlDbvGi8EDiF5+zQAeB4NrNtDmuhUmgrn D3+ZNG4yifO4c2XpjGoJpRr31zRuDQDxdHTWp14cMVV4+vTy+X25SDGNlMK8k5ZQGKpg bVlK1CNCSubfo748YulYh9p4GKczfS+3XOh6l0tPBjBQYmGRAeiy5MT7uMZ9RRdF5pM0 6S75dmb+JQmgnVMrey5wC8HFyhvQi/QGZjYk3eEgDxXzKEKuM+g9peAmbACx5q7pLAUG vL7zYk4coi60Oi7Jd43m3cNLaNXprHl7JJBBY/JtOjbFD8/MJF3UzknVua0dMEuzXmKX 946w== X-Gm-Message-State: AJaThX7itdNMrHy82oaKhFX6HwZCUEbDZoLIEpnTYhzXGj2QnU6Nvtj+ ozFsb3puLcc2kgYH7WC86pY= X-Google-Smtp-Source: AGs4zMaR4JIrH34EDT7jAL1RO5ce5uEC4eJqwg28HjEX3xJt0VXsXQ+xk+HxpoJ+eBND8ctt5ZwH2Q== X-Received: by 10.159.205.132 with SMTP id v4mr8078886plo.426.1510997670476; Sat, 18 Nov 2017 01:34:30 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id y20sm11057079pgc.52.2017.11.18.01.34.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 18 Nov 2017 01:34:29 -0800 (PST) From: Arvind Yadav To: ben-linux@fluff.org, ulf.hansson@linaro.org, adrian.hunter@intel.com, vireshk@kernel.org, maxime.ripard@free-electrons.com, wens@csie.org, linux@armlinux.org.uk, carlo@caione.org, khilman@baylibre.com Subject: [PATCH 5/6 v2] mmc: sh_mmcif: Handle return value of platform_get_irq Date: Sat, 18 Nov 2017 15:03:47 +0530 Message-Id: <59e155d8c3eff4adf39cd343c56e52530020f64d.1510997223.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <130df0c2c60ed6a0f460b68c586cc0a4167aed0b.1510997223.git.arvind.yadav.cs@gmail.com> References: <130df0c2c60ed6a0f460b68c586cc0a4167aed0b.1510997223.git.arvind.yadav.cs@gmail.com> In-Reply-To: <130df0c2c60ed6a0f460b68c586cc0a4167aed0b.1510997223.git.arvind.yadav.cs@gmail.com> References: <130df0c2c60ed6a0f460b68c586cc0a4167aed0b.1510997223.git.arvind.yadav.cs@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171118_013451_738861_C25DEF4F X-CRM114-Status: UNSURE ( 8.49 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-amlogic@lists.infradead.org, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP platform_get_irq() can fail here and we must check its return value. Signed-off-by: Arvind Yadav --- changes in v2 : Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid. drivers/mmc/host/sh_mmcif.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/sh_mmcif.c b/drivers/mmc/host/sh_mmcif.c index 53fb18b..481f2c4 100644 --- a/drivers/mmc/host/sh_mmcif.c +++ b/drivers/mmc/host/sh_mmcif.c @@ -1405,7 +1405,7 @@ static int sh_mmcif_probe(struct platform_device *pdev) irq[0] = platform_get_irq(pdev, 0); irq[1] = platform_get_irq(pdev, 1); - if (irq[0] < 0) { + if (irq[0] <= 0 || irq[1] <= 0) { dev_err(dev, "Get irq error\n"); return -ENXIO; }