| Message ID | 5c3a005a67096010cf3c465f8e3362651763fe3b.1713778236.git.haibo1.xu@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add ACPI NUMA support for RISC-V | expand |
@Arnd Bergmann Could you help review this patch? Thanks, Haibo On Wed, Apr 24, 2024 at 1:31 PM Haibo Xu <haibo1.xu@intel.com> wrote: > > x86/arm64/loongarch would select ACPI_NUMA by default and riscv > would do the same thing, so change it to a hidden option and the > select statements except for the X86_64_ACPI_NUMA can also go away. > > Suggested-by: Arnd Bergmann <arnd@arndb.de> > Suggested-by: Sunil V L <sunilvl@ventanamicro.com> > Signed-off-by: Haibo Xu <haibo1.xu@intel.com> > --- > arch/arm64/Kconfig | 1 - > arch/loongarch/Kconfig | 1 - > drivers/acpi/numa/Kconfig | 5 +---- > 3 files changed, 1 insertion(+), 6 deletions(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 7b11c98b3e84..c6c667898da6 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1439,7 +1439,6 @@ config HOTPLUG_CPU > config NUMA > bool "NUMA Memory Allocation and Scheduler Support" > select GENERIC_ARCH_NUMA > - select ACPI_NUMA if ACPI > select OF_NUMA > select HAVE_SETUP_PER_CPU_AREA > select NEED_PER_CPU_EMBED_FIRST_CHUNK > diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig > index a5f300ec6f28..29d574a5c34c 100644 > --- a/arch/loongarch/Kconfig > +++ b/arch/loongarch/Kconfig > @@ -465,7 +465,6 @@ config NR_CPUS > config NUMA > bool "NUMA Support" > select SMP > - select ACPI_NUMA if ACPI > help > Say Y to compile the kernel with NUMA (Non-Uniform Memory Access) > support. This option improves performance on systems with more > diff --git a/drivers/acpi/numa/Kconfig b/drivers/acpi/numa/Kconfig > index 849c2bd820b9..f33194d1e43f 100644 > --- a/drivers/acpi/numa/Kconfig > +++ b/drivers/acpi/numa/Kconfig > @@ -1,9 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > config ACPI_NUMA > - bool "NUMA support" > - depends on NUMA > - depends on (X86 || ARM64 || LOONGARCH) > - default y if ARM64 > + def_bool NUMA && !X86 > > config ACPI_HMAT > bool "ACPI Heterogeneous Memory Attribute Table Support" > -- > 2.34.1 >
On Wed, Apr 24, 2024 at 01:46:25PM +0800, Haibo Xu wrote: > x86/arm64/loongarch would select ACPI_NUMA by default and riscv > would do the same thing, so change it to a hidden option and the > select statements except for the X86_64_ACPI_NUMA can also go away. > > Suggested-by: Arnd Bergmann <arnd@arndb.de> > Suggested-by: Sunil V L <sunilvl@ventanamicro.com> > Signed-off-by: Haibo Xu <haibo1.xu@intel.com> > --- > arch/arm64/Kconfig | 1 - > arch/loongarch/Kconfig | 1 - > drivers/acpi/numa/Kconfig | 5 +---- > 3 files changed, 1 insertion(+), 6 deletions(-) > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > index 7b11c98b3e84..c6c667898da6 100644 > --- a/arch/arm64/Kconfig > +++ b/arch/arm64/Kconfig > @@ -1439,7 +1439,6 @@ config HOTPLUG_CPU > config NUMA > bool "NUMA Memory Allocation and Scheduler Support" > select GENERIC_ARCH_NUMA > - select ACPI_NUMA if ACPI > select OF_NUMA > select HAVE_SETUP_PER_CPU_AREA > select NEED_PER_CPU_EMBED_FIRST_CHUNK > diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig > index a5f300ec6f28..29d574a5c34c 100644 > --- a/arch/loongarch/Kconfig > +++ b/arch/loongarch/Kconfig > @@ -465,7 +465,6 @@ config NR_CPUS > config NUMA > bool "NUMA Support" > select SMP > - select ACPI_NUMA if ACPI > help > Say Y to compile the kernel with NUMA (Non-Uniform Memory Access) > support. This option improves performance on systems with more > diff --git a/drivers/acpi/numa/Kconfig b/drivers/acpi/numa/Kconfig > index 849c2bd820b9..f33194d1e43f 100644 > --- a/drivers/acpi/numa/Kconfig > +++ b/drivers/acpi/numa/Kconfig > @@ -1,9 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0 > config ACPI_NUMA > - bool "NUMA support" > - depends on NUMA > - depends on (X86 || ARM64 || LOONGARCH) > - default y if ARM64 > + def_bool NUMA && !X86 > LGTM. Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 7b11c98b3e84..c6c667898da6 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -1439,7 +1439,6 @@ config HOTPLUG_CPU config NUMA bool "NUMA Memory Allocation and Scheduler Support" select GENERIC_ARCH_NUMA - select ACPI_NUMA if ACPI select OF_NUMA select HAVE_SETUP_PER_CPU_AREA select NEED_PER_CPU_EMBED_FIRST_CHUNK diff --git a/arch/loongarch/Kconfig b/arch/loongarch/Kconfig index a5f300ec6f28..29d574a5c34c 100644 --- a/arch/loongarch/Kconfig +++ b/arch/loongarch/Kconfig @@ -465,7 +465,6 @@ config NR_CPUS config NUMA bool "NUMA Support" select SMP - select ACPI_NUMA if ACPI help Say Y to compile the kernel with NUMA (Non-Uniform Memory Access) support. This option improves performance on systems with more diff --git a/drivers/acpi/numa/Kconfig b/drivers/acpi/numa/Kconfig index 849c2bd820b9..f33194d1e43f 100644 --- a/drivers/acpi/numa/Kconfig +++ b/drivers/acpi/numa/Kconfig @@ -1,9 +1,6 @@ # SPDX-License-Identifier: GPL-2.0 config ACPI_NUMA - bool "NUMA support" - depends on NUMA - depends on (X86 || ARM64 || LOONGARCH) - default y if ARM64 + def_bool NUMA && !X86 config ACPI_HMAT bool "ACPI Heterogeneous Memory Attribute Table Support"
x86/arm64/loongarch would select ACPI_NUMA by default and riscv would do the same thing, so change it to a hidden option and the select statements except for the X86_64_ACPI_NUMA can also go away. Suggested-by: Arnd Bergmann <arnd@arndb.de> Suggested-by: Sunil V L <sunilvl@ventanamicro.com> Signed-off-by: Haibo Xu <haibo1.xu@intel.com> --- arch/arm64/Kconfig | 1 - arch/loongarch/Kconfig | 1 - drivers/acpi/numa/Kconfig | 5 +---- 3 files changed, 1 insertion(+), 6 deletions(-)