From patchwork Tue May 19 12:39:12 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 6436781 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 85A5A9F38D for ; Tue, 19 May 2015 12:42:05 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B10C120392 for ; Tue, 19 May 2015 12:42:04 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D89E320453 for ; Tue, 19 May 2015 12:42:03 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YugoJ-00009V-Qh; Tue, 19 May 2015 12:39:51 +0000 Received: from mout.kundenserver.de ([212.227.126.187]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YugoF-0008VN-6B for linux-arm-kernel@lists.infradead.org; Tue, 19 May 2015 12:39:47 +0000 Received: from wuerfel.localnet ([149.172.15.242]) by mrelayeu.kundenserver.de (mreue001) with ESMTPSA (Nemesis) id 0MeGZ4-1YX6yK0m2Y-00Puxn; Tue, 19 May 2015 14:39:14 +0200 From: Arnd Bergmann To: linux-media@vger.kernel.org Subject: [PATCH] [media] ov2659: add v4l2_subdev dependency Date: Tue, 19 May 2015 14:39:12 +0200 Message-ID: <6092911.yr0lA5IaG4@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) MIME-Version: 1.0 X-Provags-ID: V03:K0:iMzS9iEPTSsSIMiYihyXzjRUpgq0nnIdmGuypakGrhSV/cg0JAu beWOD4NT0vwPGjJupERp/K8y3LkVV4PFkqfkJ10JBwqD6eOFpZ1Sx4OFfTWu43oD6HUrPip KmjRwslI0AV215dQRaDzoJ6raUcEMlS6NFCbObyymg5EXjmDzCQylcnKoj86LghUCtAk5xN 5/PZHlEDHds8+QnRXoRdw== X-UI-Out-Filterresults: notjunk:1; X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150519_053947_564432_8196A895 X-CRM114-Status: UNSURE ( 8.37 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.1 (-) Cc: Mauro Carvalho Chehab , linux-kernel@vger.kernel.org, Benoit Parrot , Prabhakar , Hans Verkuil , Sakari Ailus , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The newly added ov2659 driver uses the v4l2 subdev API, but can be enabled even when that API is not part of the kernel, resulting in this build error: media/i2c/ov2659.c: In function 'ov2659_get_fmt': media/i2c/ov2659.c:1054:8: error: implicit declaration of function 'v4l2_subdev_get_try_format' [-Werror=implicit-function-declaration] media/i2c/ov2659.c:1054:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion] media/i2c/ov2659.c: In function 'ov2659_set_fmt': media/i2c/ov2659.c:1129:6: warning: assignment makes pointer from integer without a cast [-Wint-conversion] media/i2c/ov2659.c: In function 'ov2659_open': media/i2c/ov2659.c:1264:38: error: 'struct v4l2_subdev_fh' has no member named 'pad' This adds an explicit dependency, like all the other drivers have. Signed-off-by: Arnd Bergmann Fixes: c4c0283ab3c ("[media] media: i2c: add support for omnivision's ov2659 sensor") Acked-by: Benoit Parrot diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index 6f30ea76151a..db01ed84918f 100644 --- a/drivers/media/i2c/Kconfig +++ b/drivers/media/i2c/Kconfig @@ -469,7 +469,7 @@ config VIDEO_SMIAPP_PLL config VIDEO_OV2659 tristate "OmniVision OV2659 sensor support" depends on VIDEO_V4L2 && I2C - depends on MEDIA_CAMERA_SUPPORT + depends on MEDIA_CAMERA_SUPPORT && VIDEO_V4L2_SUBDEV_API ---help--- This is a Video4Linux2 sensor-level driver for the OmniVision OV2659 camera.