| Message ID | 60BA5429A0E1584BA3633194F6F993B501482A65@NA-MBX-02.mgc.mentorg.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hello. On 16-11-2012 3:32, Chaiken, Alison wrote: > From fd4450ac6bdcf62a84b0d029b36506e7fd567688 Mon Sep 17 00:00:00 2001 > From: Alison Chaiken <alchaiken@gmail.com> > Date: Thu, 1 Nov 2012 01:12:38 -0700 > Subject: [PATCH] Argument list for of_platform_populate correction to match of_platform.h prototype The above header is not needed. > Signed-off-by: Alison Chaiken <alison_chaiken@mentor.com> > --- > Documentation/devicetree/usage-model.txt | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > diff --git a/Documentation/devicetree/usage-model.txt b/Documentation/devicetree/usage-model.txt > index c5a8009..daa56a2 100644 > --- a/Documentation/devicetree/usage-model.txt > +++ b/Documentation/devicetree/usage-model.txt > @@ -347,7 +347,7 @@ later), which will happily live at the base of the Linux /sys/devices > tree. Therefore, if a DT node is at the root of the tree, then it > really probably is best registered as a platform_device. > > -Linux board support code calls of_platform_populate(NULL, NULL, NULL) > +Linux board support code calls of_platform_populate(NULL, NULL, NULL, NULL) > to kick off discovery of devices at the root of the tree. The > parameters are all NULL because when starting from the root of the > tree, there is no need to provide a starting node (the first NULL), a Looks like the patch is whitespace spoiled, i.e. a space is added to each line starting with a space. WBR, Sergei
On Thursday 15 November 2012, Chaiken, Alison wrote: > From fd4450ac6bdcf62a84b0d029b36506e7fd567688 Mon Sep 17 00:00:00 2001 > From: Alison Chaiken <alchaiken@gmail.com> > Date: Thu, 1 Nov 2012 01:12:38 -0700 > Subject: [PATCH] Argument list for of_platform_populate correction to match of_platform.h prototype > > Signed-off-by: Alison Chaiken <alison_chaiken@mentor.com> Hi Alison, Congratulations on your first patch on the arm mailing list! The patch looks obviously correct to me, so Acked-by: Arnd Bergmann <arnd@arndb.de> Sergei already mentioned that the email was whitespace broken and had extra lines on top, which can happen when you use thunderbird for sending the patch. See Documentation/email-clients.txt for how to deal with this. My usual recommendation is to use git-send-email. It also helps to include all maintainers that might be responsible for picking up the patch. In this case, there are three maintainers: Grant Likely and Rob Herring (both doing device tree) and Rob Landley (for Documentation). There are also two mailing lists, linux-doc@vger.kernel.org and devicetree-discuss@lists.ozlabs.org. Adding all of the above to Cc increases the chances of someone actually applying the patch. Unfortunately not all of us get to apply patches we receive as fast as we should, and patches like yours could get applied by any of the three people. In doubt, you can always Cc everyone that scripts/get_maintainer.pl suggests, but if you know the people well, you can also trim down that list. Arnd
On Fri, 16 Nov 2012 17:42:05 +0000, Arnd Bergmann <arnd@arndb.de> wrote: > On Thursday 15 November 2012, Chaiken, Alison wrote: > > From fd4450ac6bdcf62a84b0d029b36506e7fd567688 Mon Sep 17 00:00:00 2001 > > From: Alison Chaiken <alchaiken@gmail.com> > > Date: Thu, 1 Nov 2012 01:12:38 -0700 > > Subject: [PATCH] Argument list for of_platform_populate correction to match of_platform.h prototype > > > > Signed-off-by: Alison Chaiken <alison_chaiken@mentor.com> > > Hi Alison, > > Congratulations on your first patch on the arm mailing list! > > The patch looks obviously correct to me, so > > Acked-by: Arnd Bergmann <arnd@arndb.de> Applied, thanks.
diff --git a/Documentation/devicetree/usage-model.txt b/Documentation/devicetree/usage-model.txt index c5a8009..daa56a2 100644 --- a/Documentation/devicetree/usage-model.txt +++ b/Documentation/devicetree/usage-model.txt @@ -347,7 +347,7 @@ later), which will happily live at the base of the Linux /sys/devices tree. Therefore, if a DT node is at the root of the tree, then it really probably is best registered as a platform_device. -Linux board support code calls of_platform_populate(NULL, NULL, NULL) +Linux board support code calls of_platform_populate(NULL, NULL, NULL, NULL) to kick off discovery of devices at the root of the tree. The parameters are all NULL because when starting from the root of the tree, there is no need to provide a starting node (the first NULL), a