| Message ID | 60fb2068b0ee6ce2a67333c81ccd2f6b@208suo.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ARM: mm: Fix warnings in context.c | expand |
On Wed, Jul 12, 2023 at 05:06:32PM +0800, shijie001@208suo.com wrote: > The following checkpatch warning is removed: > WARNING: Use #include <linux/mmu_context.h> instead of <asm/mmu_context.h> > > Signed-off-by: Jie Shi <shijie001@208suo.com> > --- > arch/arm/mm/context.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mm/context.c b/arch/arm/mm/context.c > index 4204ffa2d104..c84ad6c786e7 100644 > --- a/arch/arm/mm/context.c > +++ b/arch/arm/mm/context.c > @@ -13,7 +13,7 @@ > #include <linux/smp.h> > #include <linux/percpu.h> > > -#include <asm/mmu_context.h> > +#include <linux/mmu_context.h> > #include <asm/smp_plat.h> > #include <asm/thread_notify.h> > #include <asm/tlbflush.h> > Probably haven't noticed, but linux/ includes are all grouped together, and asm/ includes are all grouped together. Please keep that. Also, is it really a necessary change, when arch/arm/mm/context.c is only implementing the interfaces provided by asm/mmu_context.h? I think the warning is wrong in this case and should never be fixed as things currently stand.
diff --git a/arch/arm/mm/context.c b/arch/arm/mm/context.c index 4204ffa2d104..c84ad6c786e7 100644 --- a/arch/arm/mm/context.c +++ b/arch/arm/mm/context.c @@ -13,7 +13,7 @@ #include <linux/smp.h> #include <linux/percpu.h> -#include <asm/mmu_context.h> +#include <linux/mmu_context.h> #include <asm/smp_plat.h> #include <asm/thread_notify.h> #include <asm/tlbflush.h>
The following checkpatch warning is removed: WARNING: Use #include <linux/mmu_context.h> instead of <asm/mmu_context.h> Signed-off-by: Jie Shi <shijie001@208suo.com> --- arch/arm/mm/context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)