| Message ID | 6141061.UF13qqqgfz@wasted.cogentembedded.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, Sep 29, 2014 at 10:21:59PM +0400, Sergei Shtylyov wrote: > Describe the PCI USB devices that are behind the PCI bridges, adding necessary > links to the USB PHY device. > > Based on the original work by Ben Dooks <ben.dooks@codethink.co.uk>. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Thanks, I have queued this up. > > --- > This patch is against 'renesas-devel-20140924-v3.17-rc6' tag of Simon Horman's > 'renesas.git' repo plus R8A7790/Lager USB PHY support patches posted before. > The patch requires the USB PHY driver and USB HCD generic PHY support (merged > by Kishon and Greg recently) in order to work. > > Changes in version 4: > - refreshed the patch. > > Changes in version 3: > - adjusted "phys" properties in the PCI OHCI/EHCI device nodes; > - resolved rejects. > > Changes in version 2: > - renamed the PCI OHCI/EHCI device nodes to comply with the PCI binding; > - changed the PHY specifier in the PCI#2 node to reflect that channel #1 support > was dropped; > - resolved rejects, refreshed the patch. > > arch/arm/boot/dts/r8a7790.dtsi | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > Index: renesas/arch/arm/boot/dts/r8a7790.dtsi > =================================================================== > --- renesas.orig/arch/arm/boot/dts/r8a7790.dtsi > +++ renesas/arch/arm/boot/dts/r8a7790.dtsi > @@ -1107,6 +1107,20 @@ > interrupt-map = <0x0000 0 0 1 &gic 0 108 IRQ_TYPE_LEVEL_HIGH > 0x0800 0 0 1 &gic 0 108 IRQ_TYPE_LEVEL_HIGH > 0x1000 0 0 2 &gic 0 108 IRQ_TYPE_LEVEL_HIGH>; > + > + usb@0,1 { > + reg = <0x800 0 0 0 0>; > + device_type = "pci"; > + phys = <&usb0 0>; > + phy-names = "usb"; > + }; > + > + usb@0,2 { > + reg = <0x1000 0 0 0 0>; > + device_type = "pci"; > + phys = <&usb0 0>; > + phy-names = "usb"; > + }; > }; > > pci1: pci@ee0b0000 { > @@ -1147,6 +1161,20 @@ > interrupt-map = <0x0000 0 0 1 &gic 0 113 IRQ_TYPE_LEVEL_HIGH > 0x0800 0 0 1 &gic 0 113 IRQ_TYPE_LEVEL_HIGH > 0x1000 0 0 2 &gic 0 113 IRQ_TYPE_LEVEL_HIGH>; > + > + usb@0,1 { > + reg = <0x800 0 0 0 0>; > + device_type = "pci"; > + phys = <&usb2 0>; > + phy-names = "usb"; > + }; > + > + usb@0,2 { > + reg = <0x1000 0 0 0 0>; > + device_type = "pci"; > + phys = <&usb2 0>; > + phy-names = "usb"; > + }; > }; > > pciec: pcie@fe000000 { >
On Monday 29 September 2014 22:21:59 Sergei Shtylyov wrote: > + > + usb@0,1 { > + reg = <0x800 0 0 0 0>; > + device_type = "pci"; > + phys = <&usb0 0>; > + phy-names = "usb"; > + }; > + > + usb@0,2 { Nice to see this actually works! The patch looks good to me, but I wasn't sure if the ARM PCI code handled of_nodes correctly. We frequently get people asking for the same functionality on USB device, which should really work the same way, so I guess I can point them at this now. Arnd
Index: renesas/arch/arm/boot/dts/r8a7790.dtsi =================================================================== --- renesas.orig/arch/arm/boot/dts/r8a7790.dtsi +++ renesas/arch/arm/boot/dts/r8a7790.dtsi @@ -1107,6 +1107,20 @@ interrupt-map = <0x0000 0 0 1 &gic 0 108 IRQ_TYPE_LEVEL_HIGH 0x0800 0 0 1 &gic 0 108 IRQ_TYPE_LEVEL_HIGH 0x1000 0 0 2 &gic 0 108 IRQ_TYPE_LEVEL_HIGH>; + + usb@0,1 { + reg = <0x800 0 0 0 0>; + device_type = "pci"; + phys = <&usb0 0>; + phy-names = "usb"; + }; + + usb@0,2 { + reg = <0x1000 0 0 0 0>; + device_type = "pci"; + phys = <&usb0 0>; + phy-names = "usb"; + }; }; pci1: pci@ee0b0000 { @@ -1147,6 +1161,20 @@ interrupt-map = <0x0000 0 0 1 &gic 0 113 IRQ_TYPE_LEVEL_HIGH 0x0800 0 0 1 &gic 0 113 IRQ_TYPE_LEVEL_HIGH 0x1000 0 0 2 &gic 0 113 IRQ_TYPE_LEVEL_HIGH>; + + usb@0,1 { + reg = <0x800 0 0 0 0>; + device_type = "pci"; + phys = <&usb2 0>; + phy-names = "usb"; + }; + + usb@0,2 { + reg = <0x1000 0 0 0 0>; + device_type = "pci"; + phys = <&usb2 0>; + phy-names = "usb"; + }; }; pciec: pcie@fe000000 {
Describe the PCI USB devices that are behind the PCI bridges, adding necessary links to the USB PHY device. Based on the original work by Ben Dooks <ben.dooks@codethink.co.uk>. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- This patch is against 'renesas-devel-20140924-v3.17-rc6' tag of Simon Horman's 'renesas.git' repo plus R8A7790/Lager USB PHY support patches posted before. The patch requires the USB PHY driver and USB HCD generic PHY support (merged by Kishon and Greg recently) in order to work. Changes in version 4: - refreshed the patch. Changes in version 3: - adjusted "phys" properties in the PCI OHCI/EHCI device nodes; - resolved rejects. Changes in version 2: - renamed the PCI OHCI/EHCI device nodes to comply with the PCI binding; - changed the PHY specifier in the PCI#2 node to reflect that channel #1 support was dropped; - resolved rejects, refreshed the patch. arch/arm/boot/dts/r8a7790.dtsi | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+)