From patchwork Wed Jul 31 10:43:15 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Furong Xu <0x1207@gmail.com> X-Patchwork-Id: 13748473 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F219C3DA64 for ; Wed, 31 Jul 2024 10:46:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DPGHY6v5CIr+Eb9z9smFgMyzujoybq7sK/FaJAiXSc0=; b=1j/AKAjm6Q28w/oWrCyEgJ9Y7l mWGRjNqpR614/8oSG2IDKaki4b2RUTY8NpHwz4i2r2zlmM3BWYeg/bOBQ9Eg5lObd2rc7KSBa3amp FjSJH2PxOTFV0zXePYZO8fAH7EqvyuwyDRcIbro/h28D6yqg0hgVxL0uld3jVl389J8L3qT4dqDmY dU7mazQtChjl7Tf98pgxIJxcV2qhUV/XCqiSTqTxg5YScKHrmOlrD4OqPaqjM12P++a2tewutT1aU R8pB3kO4xwuf3fy4dSCgpysvrXxC43q0Oplp03c/hficbEwy7sfDgI/602/FRKeSdYDU8gxGtFqem uLMUhitQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZ6qR-00000000mA5-0urb; Wed, 31 Jul 2024 10:46:11 +0000 Received: from mail-pf1-x434.google.com ([2607:f8b0:4864:20::434]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sZ6on-00000000lb1-18EE for linux-arm-kernel@lists.infradead.org; Wed, 31 Jul 2024 10:44:30 +0000 Received: by mail-pf1-x434.google.com with SMTP id d2e1a72fcca58-70ea2f25bfaso3975415b3a.1 for ; Wed, 31 Jul 2024 03:44:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722422668; x=1723027468; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DPGHY6v5CIr+Eb9z9smFgMyzujoybq7sK/FaJAiXSc0=; b=keIndLBJyDyjrWBLDYbiI+seXp3poYHiUHU6KJ0ItFXsOUTakOipzfHF/xG3SaQ0yW X4oew4/WqwPzuxYASRx4wADFI49s9St3SFNzYh6GECJ9rcOXUWAjdx97l5y9irwD5+km I+wg0ZrFp1vR0it7uKjkT369e1IFAgirCH0iLHH7V7OnC++U6JLHH8XuamXwBlkGQ47r iUmTBXEbaKsZMh1TyiLQzlOQZv8GpER6UXnKhzF5+K8OImeh776XC4ckiuJP2thLoLb2 jR5hvqb4qKuMd3mX3YetanZQzm+xzNUahhCOTE9RSQsYV9IftPUut/466/VoUOGQ6rho EkvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722422668; x=1723027468; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DPGHY6v5CIr+Eb9z9smFgMyzujoybq7sK/FaJAiXSc0=; b=u2jCTY3YtFM30JBWiCIUpXzxUtTd39/lEvTSOjig/fznT8XlceOELKsnq3d2uehFNz zY4m14cMu8eeU7fdE3mDExXvm+Brfr1/4gvwwFk+3TseWQJg8nNHrBjqxJhIa6LXJvyN +mNTH2gh1RaHbPWUZlnBXRFer7MvLMn/yDZZiBKsQXKvU2dYJCSio2aE9A4dxIRo9D2O iA7PJRKTuxFx/Zc6ac4bEMlBai1OkNeN7VFAocd3uU/ACToNar4FM086xHEZw6up57nb WcA1MVmuLD7Y6OLFUiUk9BRkh5pXgnYVs0WKRx2NAPGpVgJJS+vuja8skEVU+sglPRg+ uOeA== X-Forwarded-Encrypted: i=1; AJvYcCW3I7NEY5hq+ggq6TgbR1koju2qcTzgq3aXc1adtOfhxRcgmXZBx9Hr0KKMgCe0wBsR5Ur6SWtwzMaU6M2e+TDgDbwnQq1lCtnfof0KfSa00Rn29Ws= X-Gm-Message-State: AOJu0YwbA3TONNp614sAXpCyW/n7cAQgVwHf5ybMS1qfNkyNgWuN7d7I uY+U2ovbnivBq0JdDlapXGsbfGoR9oAYHKwJ+lTUoy7nHTqQ5PShZuGS1A== X-Google-Smtp-Source: AGHT+IFTctTZ1qQ55uQCVBFKWaKO8LVEq4OqBYk1wWdf3UiDgyEsaVyIy02DJQJqJ0/PrRnYWTUxGA== X-Received: by 2002:a05:6a00:21c9:b0:70e:a4ef:e5c2 with SMTP id d2e1a72fcca58-70ecea30033mr13327588b3a.13.1722422668091; Wed, 31 Jul 2024 03:44:28 -0700 (PDT) Received: from localhost.localdomain ([129.146.253.192]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-7a9f816da59sm8791375a12.29.2024.07.31.03.44.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Jul 2024 03:44:27 -0700 (PDT) From: Furong Xu <0x1207@gmail.com> To: Andrew Lunn , Vladimir Oltean , "David S. Miller" , Alexandre Torgue , Jose Abreu , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Joao Pinto Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, xfr@outlook.com, rock.xu@nio.com, Furong Xu <0x1207@gmail.com> Subject: [PATCH net-next v1 4/5] net: stmmac: drop unneeded FPE handshake code Date: Wed, 31 Jul 2024 18:43:15 +0800 Message-Id: <62d2b178672ced64f98d51bff17006728e77dea9.1722421644.git.0x1207@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240731_034429_353648_C023CA22 X-CRM114-Status: GOOD ( 12.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org FPE is configured via ethtool-mm, the hardcoded way shall be no more. Signed-off-by: Furong Xu <0x1207@gmail.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 6 +----- include/linux/stmmac.h | 1 - 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index a5e3316bc410..fba44bd1990a 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -3532,13 +3532,9 @@ static int stmmac_hw_setup(struct net_device *dev, bool ptp_register) stmmac_set_hw_vlan_mode(priv, priv->hw); - if (priv->dma_cap.fpesel) { + if (priv->dma_cap.fpesel) stmmac_fpe_start_wq(priv); - if (priv->plat->fpe_cfg->enable) - stmmac_fpe_handshake(priv, true); - } - return 0; } diff --git a/include/linux/stmmac.h b/include/linux/stmmac.h index 707a6916e51a..66eb4627bd47 100644 --- a/include/linux/stmmac.h +++ b/include/linux/stmmac.h @@ -157,7 +157,6 @@ enum stmmac_fpe_task_state_t { }; struct stmmac_fpe_cfg { - bool enable; /* FPE enable */ bool hs_enable; /* FPE handshake enable */ enum stmmac_fpe_state lp_fpe_state; /* Link Partner FPE state */ enum stmmac_fpe_state lo_fpe_state; /* Local station FPE state */