From patchwork Mon Jul 23 03:06:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 10539529 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 16C71180E for ; Mon, 23 Jul 2018 03:07:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0103328531 for ; Mon, 23 Jul 2018 03:07:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E92AE2855A; Mon, 23 Jul 2018 03:07:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 8ECF428531 for ; Mon, 23 Jul 2018 03:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=cK0QnwCCYQGLu1fejAD0Wpg912IkIcwzinR+0EMI44Y=; b=OLP vKGA9CQO1Q7mw4CjqjN7iNiV9TNqEWS5tuCPeyX8kjQajnqc2pch0QLvIFwzkRMUNm6B5r8mqzZpT cOgiOX4vExInJAm6VfKnRdBHhaunQOHIHARu5bP854wDbtby+txS2CKkqHNlMpgY9HfNMU3iReY6m rjPCZnEovEK6daWjBsqILhOqS6tn2kZdXn4CJ+z5AERYYmI6+o5vR2daMQzqCtqH7YNfH2/Mn8jVn /OIbL76iGN8M3IkvAlAmn4Jj3gI79J4K50BxjtWxG0GlMgFGKJFnJw0jceadqp1auF+9GLKa5ay7w 1ysTcX3bA//SuZlTlTQV/5ffy9JE/7w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fhRBk-0005yE-3v; Mon, 23 Jul 2018 03:07:08 +0000 Received: from mail-pl0-x242.google.com ([2607:f8b0:400e:c01::242]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fhRBg-0005wE-NJ for linux-arm-kernel@lists.infradead.org; Mon, 23 Jul 2018 03:07:06 +0000 Received: by mail-pl0-x242.google.com with SMTP id s17-v6so7600321plp.7 for ; Sun, 22 Jul 2018 20:06:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=IN5o1a/MR10AYDmv1CeefaHwvyUbJkVcoUSVobDTOvY=; b=esRV64x/mvP4nCgS0gMM0Cbypt4nS8+gKdsJ1dO/MPHdGQ6f2Lk81Npj8L8HZAdc1c 6kGOlh3XcH94KZTAUnTqhU3LI8TasnnN2Qg74U2Ipoz7IhLEVyQ8gSxZQHyHqEYNJEyd nuqrPe4+R+sT9ZT59/orGkHzmw1Ruh3Dv6lcw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=IN5o1a/MR10AYDmv1CeefaHwvyUbJkVcoUSVobDTOvY=; b=QRsFK1iPmqmUcAB3FpAo/hyahQDPxXuIx4eVpuiHqVF/js74js3pcgSz01+3BnRV75 gNlTqFUMUfRuYziwp54uw0R/hARoAup1j3K7tPzKBlEDD2oXAVSRhIpnEvUA4qSX/0FP 4n9RFNZQA2chQ1teK7FJdwTANfKPs8IoCrR4+C5AFC82dRYV/OHxqrFhi6w3iZnIfxPW XavthALxiJu1oonhjifhets8i/nETngZwn/68ryHeVjxImhtHkp1QZYx5KQitLm/rQ7u HttixFrkR0sOLF/z6UGemSN1Dqb+TcxUzn/CF8lfylQaJ0IUMT+8e/4e+odDiqf7OmTb Dmhg== X-Gm-Message-State: AOUpUlFDOD9hK5U/0aSP6SvR6TvNW4VT1+8vG2cEms14hQR9iGsKJWWe nSJeNVhEPWlOl2TOXPQirakeGA== X-Google-Smtp-Source: AAOMgpdX57PXt/0exz6wwt6ERA+LMBBHn6c5hy3bJ+xgrkEZ/zL0s4/gPL3uJGQR9jM+5H4MpUEVvQ== X-Received: by 2002:a17:902:2e83:: with SMTP id r3-v6mr11326905plb.80.1532315213661; Sun, 22 Jul 2018 20:06:53 -0700 (PDT) Received: from localhost ([122.172.26.112]) by smtp.gmail.com with ESMTPSA id f5-v6sm13092634pgn.34.2018.07.22.20.06.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 22 Jul 2018 20:06:53 -0700 (PDT) From: Viresh Kumar To: Wei Xu Subject: [PATCH] arm64: dts: hisilicon: Add missing clocks property for CPUs Date: Mon, 23 Jul 2018 08:36:42 +0530 Message-Id: <6de0dde994326b3fdc2b746e22fdf1afe18067d2.1532315177.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.18.0.rc1.242.g61856ae69a2c X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180722_200704_770342_02BF570B X-CRM114-Status: GOOD ( 10.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Vincent Guittot , Viresh Kumar , Daniel Lezcano , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The clocks property should either be present for all the CPUs of a cluster or none. If these are present only for a subset of CPUs of a cluster then things will start falling apart as soon as the CPUs are brought online in a different order. For example, this will happen because the operating system looks for such properties in the CPU node it is trying to bring up, so that it can register a cooling device. Add missing clocks property. Signed-off-by: Viresh Kumar --- arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi index 919d36b91bf3..aec9e371c2a7 100644 --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi @@ -99,6 +99,7 @@ reg = <0x0 0x1>; enable-method = "psci"; next-level-cache = <&CLUSTER0_L2>; + clocks = <&stub_clock 0>; operating-points-v2 = <&cpu_opp_table>; cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; #cooling-cells = <2>; /* min followed by max */ @@ -111,6 +112,7 @@ reg = <0x0 0x2>; enable-method = "psci"; next-level-cache = <&CLUSTER0_L2>; + clocks = <&stub_clock 0>; operating-points-v2 = <&cpu_opp_table>; cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; #cooling-cells = <2>; /* min followed by max */ @@ -123,6 +125,7 @@ reg = <0x0 0x3>; enable-method = "psci"; next-level-cache = <&CLUSTER0_L2>; + clocks = <&stub_clock 0>; operating-points-v2 = <&cpu_opp_table>; cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; #cooling-cells = <2>; /* min followed by max */ @@ -135,6 +138,7 @@ reg = <0x0 0x100>; enable-method = "psci"; next-level-cache = <&CLUSTER1_L2>; + clocks = <&stub_clock 0>; operating-points-v2 = <&cpu_opp_table>; cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; #cooling-cells = <2>; /* min followed by max */ @@ -147,6 +151,7 @@ reg = <0x0 0x101>; enable-method = "psci"; next-level-cache = <&CLUSTER1_L2>; + clocks = <&stub_clock 0>; operating-points-v2 = <&cpu_opp_table>; cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; #cooling-cells = <2>; /* min followed by max */ @@ -159,6 +164,7 @@ reg = <0x0 0x102>; enable-method = "psci"; next-level-cache = <&CLUSTER1_L2>; + clocks = <&stub_clock 0>; operating-points-v2 = <&cpu_opp_table>; cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; #cooling-cells = <2>; /* min followed by max */ @@ -171,6 +177,7 @@ reg = <0x0 0x103>; enable-method = "psci"; next-level-cache = <&CLUSTER1_L2>; + clocks = <&stub_clock 0>; operating-points-v2 = <&cpu_opp_table>; cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>; #cooling-cells = <2>; /* min followed by max */