From patchwork Fri Dec 15 13:59:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13494493 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76197C35274 for ; Fri, 15 Dec 2023 14:00:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aj84MVqSh/rrq/ORggmSQHgwh+xhHdnsWQkcZjFYKUw=; b=LR6Qh74q+Dg+mS QfmUMTOBlhCv0Av7BkOysyjA9JGigycPhv9JlSzbmWXKDgkDF3x2PXHQWZp/qjRJmTk53bzwfm+vF jldUAVoFpxpn82Wgfj22mgZgRvNXoFYqAfTHdgKkbaehCTKUTV9Vx8Ns4YBTZFRbq4xI7goq8SVMj 0ENXIZk69mnSbtOlouNYwJ6nEp1dWsg5753tZrKZJb3r/auJvEEfst+M+ptBHxLKL+Zpy9/0vjbBG fOs2q+0XVF2A9gAGSVa+yWDmjdVa/M04ZGvLih16mNH3bZBOBofc9RyHvIhb6e6KrUcBZAbJXcMlG IjtTWOfUZ/VoGDS/yT8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rE8j0-003Sm0-2k; Fri, 15 Dec 2023 13:59:34 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rE8iw-003SjY-2w for linux-arm-kernel@lists.infradead.org; Fri, 15 Dec 2023 13:59:32 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rE8iu-0002lN-T6; Fri, 15 Dec 2023 14:59:28 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rE8iu-00G2ZM-Fs; Fri, 15 Dec 2023 14:59:28 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1rE8iu-003cCA-6O; Fri, 15 Dec 2023 14:59:28 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Will Deacon , Mark Rutland Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 03/18] perf: arm-cci: Convert to platform remove callback returning void Date: Fri, 15 Dec 2023 14:59:03 +0100 Message-ID: <70b581d58cfffdccb9fb3ed17bf3220c00f8033f.1702648124.git.u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1733; i=u.kleine-koenig@pengutronix.de; h=from:subject:message-id; bh=OV7M65VoRPeJ8qTDzcFPkay5azPTFOLc6r+glQI271o=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBlfFuogdGltz/NA/M9cJo+jkIVbz1EYKIyaZhCh 4ZCdvCuODCJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZXxbqAAKCRCPgPtYfRL+ TkIPB/9K2n7gMNOMWl/EmTYhk5IAPdnBM9fF+pHuMPwmfcFW+Wson4Ic7Y2+x7Rm/Ca/gLzRboB wEjcoZpsPJXtKRihv0dBETuhO5mGrDv/GSIv4T2hPihADs+UyBRG/AT64Igh0NiXQaRuq3LRd3L wDC+Pyry+EZcPk1PcwIGhzcXtTuOriyvJs/xeI1Rj56DlCfdHnCwmlyh2Li7HLrF1CfHnzYPQsz 03aFqQpabdqBZFHMoadpgb0BySMFm6ScfKq5b6ZcQQU3pWm6kz5ouETWEu7UuPetw98bdkJ1e1Y H1BK6h6tIus1cC4lYHZw5geWq1nw0Of3UJC4Bg2uXeaQ0T7m X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231215_055930_951483_DB2BD0E1 X-CRM114-Status: GOOD ( 16.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/perf/arm-cci.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/perf/arm-cci.c b/drivers/perf/arm-cci.c index 61de861eaf91..6be03f81ae5d 100644 --- a/drivers/perf/arm-cci.c +++ b/drivers/perf/arm-cci.c @@ -1697,16 +1697,14 @@ static int cci_pmu_probe(struct platform_device *pdev) return ret; } -static int cci_pmu_remove(struct platform_device *pdev) +static void cci_pmu_remove(struct platform_device *pdev) { if (!g_cci_pmu) - return 0; + return; cpuhp_remove_state(CPUHP_AP_PERF_ARM_CCI_ONLINE); perf_pmu_unregister(&g_cci_pmu->pmu); g_cci_pmu = NULL; - - return 0; } static struct platform_driver cci_pmu_driver = { @@ -1716,7 +1714,7 @@ static struct platform_driver cci_pmu_driver = { .suppress_bind_attrs = true, }, .probe = cci_pmu_probe, - .remove = cci_pmu_remove, + .remove_new = cci_pmu_remove, }; module_platform_driver(cci_pmu_driver);