[V5,4/7] ARM: pxa: Use - instead of @ for DT OPP entries

Commit Message

Viresh Kumar April 20, 2017, 10:55 a.m. UTC

Compiling the DT file with W=1, DTC warns like follows:

Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a
unit name, but no reg property

Fix this by replacing '@' with '-' as the OPP nodes will never have a
"reg" property.

Reported-by: Krzysztof Kozlowski <[e-mail]>
Reported-by: Masahiro Yamada <[e-mail]>
Suggested-by: Mark Rutland <[e-mail]>
Signed-off-by: Viresh Kumar <[e-mail]>
Acked-by: Rob Herring <[e-mail]>
---
 arch/arm/boot/dts/pxa25x.dtsi |  8 ++++----
 arch/arm/boot/dts/pxa27x.dtsi | 14 +++++++-------
 2 files changed, 11 insertions(+), 11 deletions(-)

Comments

Robert Jarzmik April 20, 2017, 8:14 p.m. UTC | #1

Viresh Kumar <[e-mail]> writes:

> Compiling the DT file with W=1, DTC warns like follows:
>
> Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a
> unit name, but no reg property
>
> Fix this by replacing '@' with '-' as the OPP nodes will never have a
> "reg" property.
>
> Reported-by: Krzysztof Kozlowski <[e-mail]>
> Reported-by: Masahiro Yamada <[e-mail]>
> Suggested-by: Mark Rutland <[e-mail]>
> Signed-off-by: Viresh Kumar <[e-mail]>
> Acked-by: Rob Herring <[e-mail]>
Acked-by: Robert Jarzmik <[e-mail]>

Cheers.

Viresh Kumar April 21, 2017, 5:30 a.m. UTC | #2

On 20-04-17, 22:14, Robert Jarzmik wrote:
> Viresh Kumar <[e-mail]> writes:
> 
> > Compiling the DT file with W=1, DTC warns like follows:
> >
> > Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a
> > unit name, but no reg property
> >
> > Fix this by replacing '@' with '-' as the OPP nodes will never have a
> > "reg" property.
> >
> > Reported-by: Krzysztof Kozlowski <[e-mail]>
> > Reported-by: Masahiro Yamada <[e-mail]>
> > Suggested-by: Mark Rutland <[e-mail]>
> > Signed-off-by: Viresh Kumar <[e-mail]>
> > Acked-by: Rob Herring <[e-mail]>
> Acked-by: Robert Jarzmik <[e-mail]>

Thanks. But I need you to pick it up for your pull request for arm-soc.

Robert Jarzmik April 21, 2017, 4:02 p.m. UTC | #3

Viresh Kumar <[e-mail]> writes:

> On 20-04-17, 22:14, Robert Jarzmik wrote:
>> Viresh Kumar <[e-mail]> writes:
>> 
>> > Compiling the DT file with W=1, DTC warns like follows:
>> >
>> > Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a
>> > unit name, but no reg property
>> >
>> > Fix this by replacing '@' with '-' as the OPP nodes will never have a
>> > "reg" property.
>> >
>> > Reported-by: Krzysztof Kozlowski <[e-mail]>
>> > Reported-by: Masahiro Yamada <[e-mail]>
>> > Suggested-by: Mark Rutland <[e-mail]>
>> > Signed-off-by: Viresh Kumar <[e-mail]>
>> > Acked-by: Rob Herring <[e-mail]>
>> Acked-by: Robert Jarzmik <[e-mail]>
>
> Thanks. But I need you to pick it up for your pull request for arm-soc.
Sure, let me take it through my tree, no problem.

Cheers.

Robert Jarzmik April 22, 2017, 7:29 p.m. UTC | #4

Robert Jarzmik <[e-mail]> writes:

> Viresh Kumar <[e-mail]> writes:
>
>> On 20-04-17, 22:14, Robert Jarzmik wrote:
>>> Viresh Kumar <[e-mail]> writes:
>>> 
>>> > Compiling the DT file with W=1, DTC warns like follows:
>>> >
>>> > Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a
>>> > unit name, but no reg property
>>> >
>>> > Fix this by replacing '@' with '-' as the OPP nodes will never have a
>>> > "reg" property.
>>> >
>>> > Reported-by: Krzysztof Kozlowski <[e-mail]>
>>> > Reported-by: Masahiro Yamada <[e-mail]>
>>> > Suggested-by: Mark Rutland <[e-mail]>
>>> > Signed-off-by: Viresh Kumar <[e-mail]>
>>> > Acked-by: Rob Herring <[e-mail]>
>>> Acked-by: Robert Jarzmik <[e-mail]>
>>
>> Thanks. But I need you to pick it up for your pull request for arm-soc.
Applied to pxa/dt tree, thanks.

Cheers.

Patch

diff --git a/arch/arm/boot/dts/pxa25x.dtsi b/arch/arm/boot/dts/pxa25x.dtsi
index f9f4726396a0..95d59be97213 100644
--- a/arch/arm/boot/dts/pxa25x.dtsi
+++ b/arch/arm/boot/dts/pxa25x.dtsi
@@ -93,22 +93,22 @@ 
 	pxa250_opp_table: opp_table0 {
 		compatible = "operating-points-v2";
 
-		opp@99532800 {
+		opp-99532800 {
 			opp-hz = /bits/ 64 <99532800>;
 			opp-microvolt = <1000000 950000 1650000>;
 			clock-latency-ns = <20>;
 		};
-		opp@199065600 {
+		opp-199065600 {
 			opp-hz = /bits/ 64 <199065600>;
 			opp-microvolt = <1000000 950000 1650000>;
 			clock-latency-ns = <20>;
 		};
-		opp@298598400 {
+		opp-298598400 {
 			opp-hz = /bits/ 64 <298598400>;
 			opp-microvolt = <1100000 1045000 1650000>;
 			clock-latency-ns = <20>;
 		};
-		opp@398131200 {
+		opp-398131200 {
 			opp-hz = /bits/ 64 <398131200>;
 			opp-microvolt = <1300000 1235000 1650000>;
 			clock-latency-ns = <20>;
diff --git a/arch/arm/boot/dts/pxa27x.dtsi b/arch/arm/boot/dts/pxa27x.dtsi
index e0fab48ba6fa..5f1d6da02a4c 100644
--- a/arch/arm/boot/dts/pxa27x.dtsi
+++ b/arch/arm/boot/dts/pxa27x.dtsi
@@ -141,37 +141,37 @@ 
 	pxa270_opp_table: opp_table0 {
 		compatible = "operating-points-v2";
 
-		opp@104000000 {
+		opp-104000000 {
 			opp-hz = /bits/ 64 <104000000>;
 			opp-microvolt = <900000 900000 1705000>;
 			clock-latency-ns = <20>;
 		};
-		opp@156000000 {
+		opp-156000000 {
 			opp-hz = /bits/ 64 <156000000>;
 			opp-microvolt = <1000000 1000000 1705000>;
 			clock-latency-ns = <20>;
 		};
-		opp@208000000 {
+		opp-208000000 {
 			opp-hz = /bits/ 64 <208000000>;
 			opp-microvolt = <1180000 1180000 1705000>;
 			clock-latency-ns = <20>;
 		};
-		opp@312000000 {
+		opp-312000000 {
 			opp-hz = /bits/ 64 <312000000>;
 			opp-microvolt = <1250000 1250000 1705000>;
 			clock-latency-ns = <20>;
 		};
-		opp@416000000 {
+		opp-416000000 {
 			opp-hz = /bits/ 64 <416000000>;
 			opp-microvolt = <1350000 1350000 1705000>;
 			clock-latency-ns = <20>;
 		};
-		opp@520000000 {
+		opp-520000000 {
 			opp-hz = /bits/ 64 <520000000>;
 			opp-microvolt = <1450000 1450000 1705000>;
 			clock-latency-ns = <20>;
 		};
-		opp@624000000 {
+		opp-624000000 {
 			opp-hz = /bits/ 64 <624000000>;
 			opp-microvolt = <1550000 1550000 1705000>;
 			clock-latency-ns = <20>;