| Message ID | 768767961c64dea3fdd86132c9eba87ae652d588.1477058332.git.mchehab@s-opensource.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, 2016-10-21 at 11:59 -0200, Mauro Carvalho Chehab wrote: > As warned by smatch: > drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c:98 mtk_mdp_vpu_send_msg() error: double unlock 'mutex:&ctx->mdp_dev->vpulock' > > Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> > --- > drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c b/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c > index b38d29e99f7a..5c8caa864e32 100644 > --- a/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c > +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c > @@ -91,7 +91,6 @@ static int mtk_mdp_vpu_send_msg(void *msg, int len, struct mtk_mdp_vpu *vpu, > mutex_lock(&ctx->mdp_dev->vpulock); > err = vpu_ipi_send(vpu->pdev, (enum ipi_id)id, msg, len); > if (err) { > - mutex_unlock(&ctx->mdp_dev->vpulock); Hi Mauro, It has been fixed by Hans in the later patch. Author: Hans Verkuil <hverkuil@xs4all.nl> Date: Mon Sep 19 05:00:34 2016 -0300 [media] mtk-mdp: fix double mutex_unlock Fix smatch error: media-git/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c:100 mtk_mdp_vpu_send_msg() error: double unlock 'mutex:&ctx-> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> minghsiu > dev_err(&ctx->mdp_dev->pdev->dev, > "vpu_ipi_send fail status %d\n", err); > }
diff --git a/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c b/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c index b38d29e99f7a..5c8caa864e32 100644 --- a/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c +++ b/drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c @@ -91,7 +91,6 @@ static int mtk_mdp_vpu_send_msg(void *msg, int len, struct mtk_mdp_vpu *vpu, mutex_lock(&ctx->mdp_dev->vpulock); err = vpu_ipi_send(vpu->pdev, (enum ipi_id)id, msg, len); if (err) { - mutex_unlock(&ctx->mdp_dev->vpulock); dev_err(&ctx->mdp_dev->pdev->dev, "vpu_ipi_send fail status %d\n", err); }
As warned by smatch: drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c:98 mtk_mdp_vpu_send_msg() error: double unlock 'mutex:&ctx->mdp_dev->vpulock' Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> --- drivers/media/platform/mtk-mdp/mtk_mdp_vpu.c | 1 - 1 file changed, 1 deletion(-)