From patchwork Wed Nov 29 16:17:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Yadav X-Patchwork-Id: 10082709 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0E1736020B for ; Wed, 29 Nov 2017 16:18:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id EBBBF29B10 for ; Wed, 29 Nov 2017 16:18:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E086729B1A; Wed, 29 Nov 2017 16:18:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7856D29B10 for ; Wed, 29 Nov 2017 16:18:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=CzwTk1GQbgPYo11RwwMorhcYazdGShXj3ctfdSMgsKE=; b=FesI9sv0flG8/mUA6DhPsd+u1n 2Do/eHrXFqR6T+HbJGY8lYP7HlRSo2k3WyTgBjqUZvOWIayBVwmO9epy2a05enpBpD4m3yf4N7/tT ESO+AqIofB/Z/ZR0m1dPQCDj4ip7WWlFzMeMfaf/lR/0nkxcoPXAuRcJXxai2Oy952y8dT6A2gA6C uNYpdFqjT0NTyryyy6kdvfOH0S1KWCn4N5gyI2xzBLD4vf7jzEfV8s4Mirw86bufSBdnnxigWb9Ky JSIUQ9QB9nVrR9cl4/QSsh+WYtQ2zo/SLBH22Dqz8Z2edfoVeKTq3OUQ38tWPSEZ/nTfDQfM60h0v NgGscgSQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1eK53o-0006wM-T9; Wed, 29 Nov 2017 16:18:08 +0000 Received: from mail-pl0-x242.google.com ([2607:f8b0:400e:c01::242]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1eK53l-0006jB-62; Wed, 29 Nov 2017 16:18:06 +0000 Received: by mail-pl0-x242.google.com with SMTP id d21so2380169pll.1; Wed, 29 Nov 2017 08:17:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=XJu+0xtEbJ5OwNG616loRCspE/NSZfdw64xVYGTfhqk=; b=Xdcl+FM3j30zZekEZ/1WXXADZ1tRXaMjKLHaKr/tRSyxMDtfLs98iILWJb+KipR2er xWTyE+MEFmg+EXlTGJ3NzsK4966ZfBBKiFl+4lya18hCug/O+PVPW3t5H+D68cdaiS2o SJbRIr2xJgpcoc5rCk8w1rqcykOSsybW/GrpSM9BN2skRxmzq4r4GuR8uUDIyKejoTr0 Vm63Ou0rULXd3IvkJ1Ti42h0YjyhyY2VvPzPMfPmCqTGykXwm76k+KCE/zTfl7u6b1p8 oi5pvozKPkTS78MMfB37cFRkh+mNAHemzc7P/KyPATiNsJ1CsAOGUOA1oSRG7U15v0YG HwVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=XJu+0xtEbJ5OwNG616loRCspE/NSZfdw64xVYGTfhqk=; b=PztbGixEdeYJWbvkEFzBtj65lIIqvr7UDyWRE8Pha6tr9EzFP002STIYGpRpYc2XHa jWJA36ARWxI79eM8RA11jnE7B8JrNPnUc6JzYHLbDrU9S0KFsz7+/NMt0/DL6pFXwU+a iEwgPW5/+qkZxWKEc87igj33P7LuznH1vCtA5Iz8uG859LgwL6X3QxuSndb8scMOilaG QwF0KfeO48P9zJKg9GvITr86g2SloHyMbHNv/SBpNLKNzdlISMGZuPbUviLubAZs+KpQ YXnreOqvHtyEX+SPpI6kd+2N1bm3gf7ep0wU18yHteaNQeLUHYGKC/ULeXqD7gxpDN// ZJgQ== X-Gm-Message-State: AJaThX72QegmFZkYgVQZLJ07zLEGr13+66TsFQ1N4ylP4tWFxrgRVLOx Y5qYwDxCuriLpYAPpTjvyM0= X-Google-Smtp-Source: AGs4zMZ2kwRgdhyI1znSIy2aPOKZy7mZm4V8BmKA6Ekrz0Czi+EgEStlNttjBudSBJPWpQ3J2MhZzA== X-Received: by 10.84.244.11 with SMTP id g11mr3431472pll.80.1511972267663; Wed, 29 Nov 2017 08:17:47 -0800 (PST) Received: from localhost.localdomain ([103.16.68.147]) by smtp.gmail.com with ESMTPSA id q74sm3867400pfd.134.2017.11.29.08.17.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 29 Nov 2017 08:17:46 -0800 (PST) From: Arvind Yadav To: lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, matthias.bgg@gmail.com Subject: [PATCH 2/5 v5] ASoC: mt8173: Fix platform_get_irq's error checking Date: Wed, 29 Nov 2017 21:47:11 +0530 Message-Id: <79e17e6083f5142c4707c94519577b6682a76566.1511970158.git.arvind.yadav.cs@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <4ce907b8389af30eb0677e70cf543a2b795cca12.1511970158.git.arvind.yadav.cs@gmail.com> References: <4ce907b8389af30eb0677e70cf543a2b795cca12.1511970158.git.arvind.yadav.cs@gmail.com> In-Reply-To: <4ce907b8389af30eb0677e70cf543a2b795cca12.1511970158.git.arvind.yadav.cs@gmail.com> References: <4ce907b8389af30eb0677e70cf543a2b795cca12.1511970158.git.arvind.yadav.cs@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20171129_081805_284471_FA3CCF6A X-CRM114-Status: GOOD ( 11.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The platform_get_irq() function returns negative if an error occurs. zero or positive number on success. platform_get_irq() error checking for zero is not correct. Signed-off-by: Arvind Yadav --- changes in v2 : irq was unsigned. so changed it to signed. changes in v3 : Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid. changes in v4 : Return -ENXIO insted of irq. changes in v5 : Add separate error for irq == 0 and irq < 0. sound/soc/mediatek/mt8173/mt8173-afe-pcm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c b/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c index 8a643a3..c7f7f8a 100644 --- a/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c +++ b/sound/soc/mediatek/mt8173/mt8173-afe-pcm.c @@ -1083,7 +1083,7 @@ static int mt8173_afe_init_audio_clk(struct mtk_base_afe *afe) static int mt8173_afe_pcm_dev_probe(struct platform_device *pdev) { int ret, i; - unsigned int irq_id; + int irq_id; struct mtk_base_afe *afe; struct mt8173_afe_private *afe_priv; struct resource *res; @@ -1105,9 +1105,9 @@ static int mt8173_afe_pcm_dev_probe(struct platform_device *pdev) afe->dev = &pdev->dev; irq_id = platform_get_irq(pdev, 0); - if (!irq_id) { + if (irq_id <= 0) { dev_err(afe->dev, "np %s no irq\n", afe->dev->of_node->name); - return -ENXIO; + return irq_id < 0 ? irq_id : -ENXIO; } ret = devm_request_irq(afe->dev, irq_id, mt8173_afe_irq_handler, 0, "Afe_ISR_Handle", (void *)afe);