diff mbox series

[v2] ARM: zynq: Do not define address/size-cells for nand-controller

Message ID 7a3b9eb256b90ea19d35f8bbe3fd311890767974.1736233292.git.michal.simek@amd.com (mailing list archive)
State New
Headers show
Series [v2] ARM: zynq: Do not define address/size-cells for nand-controller | expand

Commit Message

Michal Simek Jan. 7, 2025, 7:01 a.m. UTC
There is no reason to define address/size-cells without defining child
nodes in zynq-7000.dtsi. Define it in board file instead.

Signed-off-by: Michal Simek <michal.simek@amd.com>
---

Changes in v2:
- Update also zynq-ebaz4205.dts
- Update commit message
- Send it separately v1
  https://lore.kernel.org/all/37057526d8ee14416f61fb6e2b82bed65bde5d3c.1733920873.git.michal.simek@amd.com/

 arch/arm/boot/dts/xilinx/zynq-7000.dtsi    | 2 --
 arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts | 2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Michal Simek Feb. 4, 2025, 8:34 a.m. UTC | #1
On 1/7/25 08:01, Michal Simek wrote:
> There is no reason to define address/size-cells without defining child
> nodes in zynq-7000.dtsi. Define it in board file instead.
> 
> Signed-off-by: Michal Simek <michal.simek@amd.com>
> ---
> 
> Changes in v2:
> - Update also zynq-ebaz4205.dts
> - Update commit message
> - Send it separately v1
>    https://lore.kernel.org/all/37057526d8ee14416f61fb6e2b82bed65bde5d3c.1733920873.git.michal.simek@amd.com/
> 
>   arch/arm/boot/dts/xilinx/zynq-7000.dtsi    | 2 --
>   arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts | 2 ++
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/xilinx/zynq-7000.dtsi b/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
> index 4a29216a6d64..153b8d93cbee 100644
> --- a/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
> @@ -303,8 +303,6 @@ nfc0: nand-controller@0,0 {
>   				compatible = "arm,pl353-nand-r2p1";
>   				reg = <0 0 0x1000000>;
>   				status = "disabled";
> -				#address-cells = <1>;
> -				#size-cells = <0>;
>   			};
>   			nor0: flash@1,0 {
>   				status = "disabled";
> diff --git a/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts b/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
> index 53fa6dbfd8fd..14f644156a6f 100644
> --- a/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
> +++ b/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
> @@ -51,6 +51,8 @@ &gpio0 {
>   &nfc0 {
>   	status = "okay";
>   
> +	#address-cells = <1>;
> +	#size-cells = <0>;
>   	nand@0 {
>   		reg = <0>;
>   	};

Applied.
M
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/xilinx/zynq-7000.dtsi b/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
index 4a29216a6d64..153b8d93cbee 100644
--- a/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
+++ b/arch/arm/boot/dts/xilinx/zynq-7000.dtsi
@@ -303,8 +303,6 @@  nfc0: nand-controller@0,0 {
 				compatible = "arm,pl353-nand-r2p1";
 				reg = <0 0 0x1000000>;
 				status = "disabled";
-				#address-cells = <1>;
-				#size-cells = <0>;
 			};
 			nor0: flash@1,0 {
 				status = "disabled";
diff --git a/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts b/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
index 53fa6dbfd8fd..14f644156a6f 100644
--- a/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
+++ b/arch/arm/boot/dts/xilinx/zynq-ebaz4205.dts
@@ -51,6 +51,8 @@  &gpio0 {
 &nfc0 {
 	status = "okay";
 
+	#address-cells = <1>;
+	#size-cells = <0>;
 	nand@0 {
 		reg = <0>;
 	};