| Message ID | 7c26a0b52e00a39930ba02f7552abdd1be4c828c.1742418429.git.andrea.porta@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support for RaspberryPi RP1 PCI device using a DT overlay | expand |
Hi Andrea, Am 19.03.25 um 22:52 schrieb Andrea della Porta: > The RP1 found on Raspberry Pi 5 board needs an external crystal at 50MHz. > Add clk_rp1_xosc node to provide that. > > Signed-off-by: Andrea della Porta <andrea.porta@suse.com> > Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> i'm fine with the patch content, but I think this is necessary before Patch 9 is applied? > --- > arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > index fbc56309660f..1850a575e708 100644 > --- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > @@ -16,6 +16,13 @@ chosen: chosen { > stdout-path = "serial10:115200n8"; > }; > > + clk_rp1_xosc: clock-50000000 { > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-output-names = "rp1-xosc"; > + clock-frequency = <50000000>; > + }; > + > /* Will be filled by the bootloader */ > memory@0 { > device_type = "memory";
Hi Stefan, On 13:55 Mon 14 Apr , Stefan Wahren wrote: > Hi Andrea, > > Am 19.03.25 um 22:52 schrieb Andrea della Porta: > > The RP1 found on Raspberry Pi 5 board needs an external crystal at 50MHz. > > Add clk_rp1_xosc node to provide that. > > > > Signed-off-by: Andrea della Porta <andrea.porta@suse.com> > > Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com> > i'm fine with the patch content, but I think this is necessary before > Patch 9 is applied? True. Thanks for pointing that out. Cheers, Andrea > > --- > > arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > > index fbc56309660f..1850a575e708 100644 > > --- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > > +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts > > @@ -16,6 +16,13 @@ chosen: chosen { > > stdout-path = "serial10:115200n8"; > > }; > > > > + clk_rp1_xosc: clock-50000000 { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-output-names = "rp1-xosc"; > > + clock-frequency = <50000000>; > > + }; > > + > > /* Will be filled by the bootloader */ > > memory@0 { > > device_type = "memory"; >
diff --git a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts index fbc56309660f..1850a575e708 100644 --- a/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts +++ b/arch/arm64/boot/dts/broadcom/bcm2712-rpi-5-b.dts @@ -16,6 +16,13 @@ chosen: chosen { stdout-path = "serial10:115200n8"; }; + clk_rp1_xosc: clock-50000000 { + compatible = "fixed-clock"; + #clock-cells = <0>; + clock-output-names = "rp1-xosc"; + clock-frequency = <50000000>; + }; + /* Will be filled by the bootloader */ memory@0 { device_type = "memory";