From patchwork Wed Sep 16 09:39:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 11779457 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2B56C746 for ; Wed, 16 Sep 2020 09:39:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F338E2223C for ; Wed, 16 Sep 2020 09:39:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1YJi1+Y/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="JqccLoP0" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F338E2223C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9p4lYLJiU80zMCU3nwjdZedFdzW+InUlWNVoBtueV2w=; b=1YJi1+Y/QKfHAE7Cyc+xQELyZ csXR0v677Lf/9pOkpJ/XCUs1TCnG/Rjl9xDYkouPYdt4EsO4oQwTVfBXfPNKwAdNbC9tJs9ZMBFp+ z9Fe1KCWQvPgTvF21Vb4Nl9rNiUjTgB4VuFd6u5LpVmGFKSpiG5OuoKtZfkGteMnwrI2v0eLobEEK XyofgrtAT2kMs2fqp04eGZODqePB0pORl3oto8qhfoiVor9dsrD4HFm4oL1I7l2klo/1hQxgtQ1tx P8UzrgDAr7g6ptzQRN3S9x/scpnzJsCZZEERxThpBpf0o/2Ifs4jtEci++4RGm6eYD7F9ZgeldjPe OQbx+ho/w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kITui-0002WU-Fz; Wed, 16 Sep 2020 09:39:44 +0000 Received: from mail-pg1-x52d.google.com ([2607:f8b0:4864:20::52d]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kITuf-0002Vv-8y for linux-arm-kernel@lists.infradead.org; Wed, 16 Sep 2020 09:39:42 +0000 Received: by mail-pg1-x52d.google.com with SMTP id 7so3551305pgm.11 for ; Wed, 16 Sep 2020 02:39:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=H8AkzaxC++FhteIS2uJYfThdR+e4UohlwkKcMuwBI6c=; b=JqccLoP0WFWnngf08Ztmi7m6wSbuMixdwIc4ZLcHLmZBTvtysKHRt8CLHEmglfF0h0 yEx33j78CKWyy+7AqA4k0iCvPm2Wqi9biduejIc4TziOXcNcsMMESt/u9ao83muvBJxb H+mpNqiEhWOrKKOABom1aKusMcAX3NlEwaXs3hXgY5ZGOysp4wzq1NUHlgcdpUL32Q5T t1UGMTEavf+KxnOMby8SXAjBGrrbQE8rY8m89Vd8W521336ErWKNAXE6GvWYr6OPhCr6 /EmgoxOhkBnL3XSZDyQb20wtt6W5cyj1rbgS7WZlGxpEfLyV1Zb+UL3bSGOrAPlT01ef SL6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=H8AkzaxC++FhteIS2uJYfThdR+e4UohlwkKcMuwBI6c=; b=Imj9sSYGYvVVJkGgv+JianT7VOuZghIJNMJO5lJko1nLQH+eiIdWlQ7Dq16HzdwqsV 0BUOa+mHxOH+P7g6eboJbgHZO5aRIDhlNkk1mewTdGSKjbvLWLovWpLVN2o+YHS1Kz53 IJRVFGc/0Du6xPJzX9JNLIyb+huX+8Up5HnS30tQR8+GRMYNY+Nkd1Fn0FkETgFCuO4A XCYrTGrtKV001hISPrHM3Dw4Jas9ubh+HUiqJs8L/vO/oM5EvP0TmO46gutZtRJuiLjd 3W9o80qz/mnayEH9mbl42Ecrypd7vQLQEuGg5IJKo/dHUPU4OxT6r+KSflkz2/HpyQe5 ANBA== X-Gm-Message-State: AOAM533I7g64dIm2ZGRvrJSMjW0NB/Q8nKgsKFAnVtoorUs5+wdwB+9X KbBwf7MgrCoXRwWFCs6c+MtOEw== X-Google-Smtp-Source: ABdhPJyuMf787MIcMjuhcVoXuvXR7cJupPF8CNqVVrY93x3EpThRI7V1lJFiMAiFewJ1LdsZSw4mmg== X-Received: by 2002:a63:7841:: with SMTP id t62mr17348017pgc.183.1600249179169; Wed, 16 Sep 2020 02:39:39 -0700 (PDT) Received: from localhost ([122.181.54.133]) by smtp.gmail.com with ESMTPSA id v6sm16215933pfi.38.2020.09.16.02.39.38 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Sep 2020 02:39:38 -0700 (PDT) From: Viresh Kumar To: Rob Herring , Jassi Brar , Jassi Brar Subject: [PATCH V4 2/2] dt-bindings: mailbox: add doorbell support to ARM MHU Date: Wed, 16 Sep 2020 15:09:18 +0530 Message-Id: <7f4a98d4dac9257d9577e48992cbfb62a968f127.1600249102.git.viresh.kumar@linaro.org> X-Mailer: git-send-email 2.25.0.rc1.19.g042ed3e048af In-Reply-To: <3874de094d193a08624a00a35067a3237e0b42b1.1600249102.git.viresh.kumar@linaro.org> References: <3874de094d193a08624a00a35067a3237e0b42b1.1600249102.git.viresh.kumar@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200916_053941_520110_1C25AC16 X-CRM114-Status: GOOD ( 20.19 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:52d listed in] [list.dnswl.org] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , Vincent Guittot , Arnd Bergmann , devicetree@vger.kernel.org, Viresh Kumar , linux-kernel@vger.kernel.org, Bjorn Andersson , Sudeep Holla , Frank Rowand , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org From: Sudeep Holla The ARM MHU's reference manual states following: "The MHU drives the signal using a 32-bit register, with all 32 bits logically ORed together. The MHU provides a set of registers to enable software to set, clear, and check the status of each of the bits of this register independently. The use of 32 bits for each interrupt line enables software to provide more information about the source of the interrupt. For example, each bit of the register can be associated with a type of event that can contribute to raising the interrupt." This patch thus extends the MHU controller's DT binding to add support for doorbell mode. Though the same MHU hardware controller is used in the two modes, A new compatible string is added here to represent the combination of the MHU hardware and the firmware sitting on the other side (which expects each bit to represent a different signal now). Reviewed-by: Rob Herring Signed-off-by: Sudeep Holla Co-developed-by: Viresh Kumar Signed-off-by: Viresh Kumar Acked-by: Arnd Bergmann --- V4: Added Rob's tag. .../devicetree/bindings/mailbox/arm,mhu.yaml | 60 +++++++++++++++++-- 1 file changed, 54 insertions(+), 6 deletions(-) diff --git a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml index 2c8df7979c22..d43791a2dde7 100644 --- a/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml +++ b/Documentation/devicetree/bindings/mailbox/arm,mhu.yaml @@ -18,20 +18,40 @@ description: | remote clears it after having read the data. The last channel is specified to be a 'Secure' resource, hence can't be used by Linux running NS. + The MHU hardware also allows operations in doorbell mode. The MHU drives the + interrupt signal using a 32-bit register, with all 32-bits logically ORed + together. It provides a set of registers to enable software to set, clear and + check the status of each of the bits of this register independently. The use + of 32 bits per interrupt line enables software to provide more information + about the source of the interrupt. For example, each bit of the register can + be associated with a type of event that can contribute to raising the + interrupt. Each of the 32-bits can be used as "doorbell" to alert the remote + processor. + # We need a select here so we don't match all nodes with 'arm,primecell' select: properties: compatible: contains: - const: arm,mhu + enum: + - arm,mhu + - arm,mhu-doorbell required: - compatible properties: compatible: - items: - - const: arm,mhu - - const: arm,primecell + oneOf: + - description: Data transfer mode + items: + - const: arm,mhu + - const: arm,primecell + + - description: Doorbell mode + items: + - const: arm,mhu-doorbell + - const: arm,primecell + reg: maxItems: 1 @@ -51,8 +71,11 @@ description: | - const: apb_pclk '#mbox-cells': - description: Index of the channel. - const: 1 + description: | + Set to 1 in data transfer mode and represents index of the channel. + Set to 2 in doorbell mode and represents index of the channel and doorbell + number. + enum: [ 1, 2 ] required: - compatible @@ -63,6 +86,7 @@ description: | additionalProperties: false examples: + # Data transfer mode. - | soc { #address-cells = <2>; @@ -85,3 +109,27 @@ additionalProperties: false mboxes = <&mhuA 1>; /* HP-NonSecure */ }; }; + + # Doorbell mode. + - | + soc { + #address-cells = <2>; + #size-cells = <2>; + + mhuB: mailbox@2b2f0000 { + #mbox-cells = <2>; + compatible = "arm,mhu-doorbell", "arm,primecell"; + reg = <0 0x2b2f0000 0 0x1000>; + interrupts = <0 36 4>, /* LP-NonSecure */ + <0 35 4>, /* HP-NonSecure */ + <0 37 4>; /* Secure */ + clocks = <&clock 0 2 1>; + clock-names = "apb_pclk"; + }; + + mhu_client_scpi: scpi@2f000000 { + compatible = "arm,scpi"; + reg = <0 0x2f000000 0 0x200>; + mboxes = <&mhuB 1 4>; /* HP-NonSecure, 5th doorbell */ + }; + };