From patchwork Mon Nov 24 18:58:16 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 5369341 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 9B0279F2F5 for ; Mon, 24 Nov 2014 19:01:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 851522047B for ; Mon, 24 Nov 2014 19:00:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FB042046F for ; Mon, 24 Nov 2014 19:00:58 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XsyqX-0000LH-Mv; Mon, 24 Nov 2014 18:58:49 +0000 Received: from mail-pa0-f43.google.com ([209.85.220.43]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XsyqO-0000AP-Oo for linux-arm-kernel@lists.infradead.org; Mon, 24 Nov 2014 18:58:41 +0000 Received: by mail-pa0-f43.google.com with SMTP id kx10so10037113pab.16 for ; Mon, 24 Nov 2014 10:58:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=D+DQlCN8GpD03DVaVIBs/XwNOXxiZ8rW7M36OpgciB4=; b=b5oOz7EkeSnBv8ZbX9pbjXt9dm73pUtSJXsUleqK2iwOtVMRU2wtzTcEk4g9WG+z10 czVcprYLhlxYx/nknQdDZ49zc43TCVfNpjfUpY7w1cDeg6oPDMhzoa1VsP2d8ce6Jy1P pxncHXHEY6QlIW3qeAeIptJDF2c6X6cyVTPMzg6z5guKQ9j8AT+3da1CFZdZ0C47mbdO mzlAHbbhgdChsQeFS/cqr+7/e0TfOZ4j+/qWr2Ik2jrrVZDrz1Ngat0AK6Ya04Xte9wc 1K/9KXVxXFH2Dc7K9XUIQZcDuJ4Gn1kqUr1peUCgHjbsMpPAbJ4658n449ohQ34tAc8P Za2Q== X-Gm-Message-State: ALoCoQkaJd8zwGoBLE3Lb4zyiMRxMTE3bW3hXJUoF1f+DXKQUI3FvErW3IE6rmZk8GEhN2NVXkw1 X-Received: by 10.69.26.98 with SMTP id ix2mr35001686pbd.161.1416855499210; Mon, 24 Nov 2014 10:58:19 -0800 (PST) Received: from localhost (c-67-160-101-93.hsd1.wa.comcast.net. [67.160.101.93]) by mx.google.com with ESMTPSA id rh11sm7281325pdb.66.2014.11.24.10.58.17 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 24 Nov 2014 10:58:18 -0800 (PST) From: Kevin Hilman To: Thomas Abraham Subject: Re: [PATCH v12 0/6] cpufreq: use generic cpufreq drivers for exynos platforms References: <1416576682-5255-1-git-send-email-thomas.ab@samsung.com> Date: Mon, 24 Nov 2014 10:58:16 -0800 In-Reply-To: <1416576682-5255-1-git-send-email-thomas.ab@samsung.com> (Thomas Abraham's message of "Fri, 21 Nov 2014 19:01:16 +0530") Message-ID: <7hioi4l92v.fsf@deeprootsystems.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141124_105840_871271_AA5229CC X-CRM114-Status: GOOD ( 25.05 ) X-Spam-Score: -0.7 (/) Cc: l.majewski@samsung.com, kgene.kim@samsung.com, mturquette@linaro.org, heiko@sntech.de, linux-pm@vger.kernel.org, viresh.kumar@linaro.org, tomasz.figa@gmail.com, cw00.choi@samsung.com, linux-samsung-soc@vger.kernel.org, s.nawrocki@samsung.com, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_LOW, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Thomas, Thomas Abraham writes: > Changes since v11: > - Rebased on top of git://linuxtv.org/snawrocki/samsung.git for-v3.19-exynos-clk Thanks for rebasing/reposting. > This patch series removes the use of Exynos4210 and Exynos5250 specific cpufreq > drivers and enables the use of cpufreq-dt driver for these platforms. This > series also enables cpufreq support for Exynos5420 using arm_big_little cpufreq > driver. > > This series is based on the following branch. > git://linuxtv.org/snawrocki/samsung.git for-v3.19-exynos-clk > > This series depends on the following patch which can be picked from > git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git samsung/dt > e540920cf21c (ARM: dts: add CPU nodes for Exynos4 SoCs). > > This patch series has been tested on Exynos4210/5250/5420 based boards. > Tomasz Figa had plans to take this in the Samsung clock tree for v3.19 > (http://www.spinics.net/lists/linux-samsung-soc/msg37933.html). > Sylwester, could you consider to merge this in your tree? I tested this on exynos5800-peach-pi, and noticed a few things. First, since voltage scaling is not currently supported, the CPU cluster regulators (vdd_arm, and vdd_kfc) have to be set at sufficietnly high voltage to support all the OPPs, otherwise things will likely hang. I think you should include something like the patch below[1] in this series as well. Second, as with earlier versions of this series, I'm still seeing lots of "wait_until_divider_stable: timeout in divider stablization" messages coming out when running powertop. Speaking of powertop, in the "frequency stats" tab, I'm not seeing 0% time spent in all the P-states, so not sure what's going on there. The stats/time_in_state sysfs files under cpufreq seem to show the right values, so I'm not sure what's going on with powertop there. Kevin [1] > Thomas Abraham (6): > clk: samsung: add infrastructure to register cpu clocks > clk: samsung: add cpu clock configuration data and instantiate cpu clock > ARM: dts: Exynos: add CPU OPP and regulator supply property > ARM: Exynos: switch to using generic cpufreq driver for Exynos4210/5250/5420 > cpufreq: exynos: remove exynos4210/5250 specific cpufreq driver support > clk: samsung: remove unused clock aliases and update clock flags > > arch/arm/boot/dts/exynos4210-origen.dts | 4 + > arch/arm/boot/dts/exynos4210-trats.dts | 4 + > arch/arm/boot/dts/exynos4210-universal_c210.dts | 4 + > arch/arm/boot/dts/exynos4210.dtsi | 14 ++- > arch/arm/boot/dts/exynos5250-arndale.dts | 4 + > arch/arm/boot/dts/exynos5250-smdk5250.dts | 4 + > arch/arm/boot/dts/exynos5250-snow.dts | 4 + > arch/arm/boot/dts/exynos5250.dtsi | 25 +++- > arch/arm/boot/dts/exynos5420.dtsi | 38 ++++ > arch/arm/mach-exynos/exynos.c | 26 +++- > drivers/clk/samsung/Makefile | 2 +- > drivers/clk/samsung/clk-exynos4.c | 63 +++++--- > drivers/clk/samsung/clk-exynos5250.c | 44 ++++- > drivers/clk/samsung/clk-exynos5420.c | 72 +++++++- > drivers/cpufreq/Kconfig.arm | 22 --- > drivers/cpufreq/Makefile | 2 - > drivers/cpufreq/exynos4210-cpufreq.c | 184 -------------------- > drivers/cpufreq/exynos5250-cpufreq.c | 210 ----------------------- > include/dt-bindings/clock/exynos5250.h | 1 + > include/dt-bindings/clock/exynos5420.h | 2 + > 20 files changed, 266 insertions(+), 463 deletions(-) > delete mode 100644 drivers/cpufreq/exynos4210-cpufreq.c > delete mode 100644 drivers/cpufreq/exynos5250-cpufreq.c > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts index e8fdda827fc9..5160735aad3b 100644 --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts @@ -195,8 +195,8 @@ buck2_reg: BUCK2 { regulator-name = "vdd_arm"; - regulator-min-microvolt = <800000>; - regulator-max-microvolt = <1500000>; + regulator-min-microvolt = <1250000>; + regulator-max-microvolt = <1250000>; regulator-always-on; regulator-boot-on; regulator-ramp-delay = <12500>; @@ -230,8 +230,8 @@ buck6_reg: BUCK6 { regulator-name = "vdd_kfc"; - regulator-min-microvolt = <800000>; - regulator-max-microvolt = <1500000>; + regulator-min-microvolt = <1275000>; + regulator-max-microvolt = <1275000>; regulator-always-on; regulator-boot-on; regulator-ramp-delay = <12500>;