| Message ID | 80272771.MSjafmr6yE@wasted.cogentembedded.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Oct 14, 2015 at 10:35:46PM +0300, Sergei Shtylyov wrote: > Enable HS-USB device for the Porter board, defining the GPIO that the > driver should check when probing (which is the ID output from MAX3355 > OTG chip). > > Note that there will be pinctrl-related error messages if both internal > PCI and HS-USB drivers are enabled but they should be just ignored. > > This patch is analogous to the commit 6f4f7156e0e6 (ARM: shmobile: > henninger: enable HS-USB) as there are no differences between the > boards in this respect. > > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > Thanks Sergei, I have queued this up for v4.5. I took the liberty of tweaking the changelog to address a complaint made by Mr. Check Patch. ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6f4f7156e0e6 ("ARM: shmobile: henninger: enable HS-USB")'
Hello. On 10/15/2015 3:18 AM, Simon Horman wrote: >> Enable HS-USB device for the Porter board, defining the GPIO that the >> driver should check when probing (which is the ID output from MAX3355 >> OTG chip). >> >> Note that there will be pinctrl-related error messages if both internal >> PCI and HS-USB drivers are enabled but they should be just ignored. >> >> This patch is analogous to the commit 6f4f7156e0e6 (ARM: shmobile: >> henninger: enable HS-USB) as there are no differences between the >> boards in this respect. >> >> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> > > Thanks Sergei, > > I have queued this up for v4.5. > > I took the liberty of tweaking the changelog to address a complaint made > by Mr. Check Patch. Which means I forgot to run it again. Sorry about that. :-< > ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 6f4f7156e0e6 ("ARM: shmobile: henninger: enable HS-USB")' Keep forgetting about the now enforced quotes... MBR, Sergei
Index: renesas/arch/arm/boot/dts/r8a7791-porter.dts =================================================================== --- renesas.orig/arch/arm/boot/dts/r8a7791-porter.dts +++ renesas/arch/arm/boot/dts/r8a7791-porter.dts @@ -269,6 +269,14 @@ status = "okay"; }; +&hsusb { + pinctrl-0 = <&usb0_pins>; + pinctrl-names = "default"; + + status = "okay"; + renesas,enable-gpio = <&gpio5 31 GPIO_ACTIVE_HIGH>; +}; + &usbphy { status = "okay"; };
Enable HS-USB device for the Porter board, defining the GPIO that the driver should check when probing (which is the ID output from MAX3355 OTG chip). Note that there will be pinctrl-related error messages if both internal PCI and HS-USB drivers are enabled but they should be just ignored. This patch is analogous to the commit 6f4f7156e0e6 (ARM: shmobile: henninger: enable HS-USB) as there are no differences between the boards in this respect. Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> --- This patch is against 'renesas-devel-20151013v2-v4.3-rc5' tag of Simon Horman's 'renesas.git' repo. arch/arm/boot/dts/r8a7791-porter.dts | 8 ++++++++ 1 file changed, 8 insertions(+)