| Message ID | 80dd26ecf7fc82c88dc378d78210df5dd4138812.1569569778.git.Jose.Abreu@synopsys.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 3c72d4d33059cf84a23492e827731f12c023ab00 |
| Headers | show |
| Series | net: stmmac: Fixes for -net | expand |
On Fri, Sep 27, 2019 at 12:49 AM Jose Abreu <Jose.Abreu@synopsys.com> wrote: > > The sizeof(cfg->key) is != ARRAY_SIZE(cfg->key). Fix it. I think the warning was from -Wsizeof-array-div. > > Reported-by: kbuild test robot <lkp@intel.com> > Reported-by: Nick Desaulniers <ndesaulniers@google.com> I may have reported the kbuild link, but scanning my email, there's also a report from Reported-by: Nathan Chancellor <natechancellor@gmail.com> > Fixes: 76067459c686 ("net: stmmac: Implement RSS and enable it in XGMAC core") > Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com> > > --- > Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com> > Cc: Alexandre Torgue <alexandre.torgue@st.com> > Cc: Jose Abreu <joabreu@synopsys.com> > Cc: "David S. Miller" <davem@davemloft.net> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: netdev@vger.kernel.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > Cc: Nick Desaulniers <ndesaulniers@google.com> > --- > drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c > index 6d8ac2ef4fc2..4a1f52474dbc 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c > +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c > @@ -533,7 +533,7 @@ static int dwxgmac2_rss_configure(struct mac_device_info *hw, > return 0; > } > > - for (i = 0; i < (sizeof(cfg->key) / sizeof(u32)); i++) { > + for (i = 0; i < (ARRAY_SIZE(cfg->key) / sizeof(u32)); i++) { cfg is an instance of struct stmmac_rss, which looks like: 125 struct stmmac_rss { 126 int enable; 127 u8 key[STMMAC_RSS_HASH_KEY_SIZE]; 128 u32 table[STMMAC_RSS_MAX_TABLE_SIZE]; 129 }; yep, LGTM. Thanks for the patch. Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > ret = dwxgmac2_rss_write_reg(ioaddr, true, i, cfg->key[i]); > if (ret) > return ret; > -- > 2.7.4 > -- Thanks, ~Nick Desaulniers
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c index 6d8ac2ef4fc2..4a1f52474dbc 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c @@ -533,7 +533,7 @@ static int dwxgmac2_rss_configure(struct mac_device_info *hw, return 0; } - for (i = 0; i < (sizeof(cfg->key) / sizeof(u32)); i++) { + for (i = 0; i < (ARRAY_SIZE(cfg->key) / sizeof(u32)); i++) { ret = dwxgmac2_rss_write_reg(ioaddr, true, i, cfg->key[i]); if (ret) return ret;
The sizeof(cfg->key) is != ARRAY_SIZE(cfg->key). Fix it. Reported-by: kbuild test robot <lkp@intel.com> Reported-by: Nick Desaulniers <ndesaulniers@google.com> Fixes: 76067459c686 ("net: stmmac: Implement RSS and enable it in XGMAC core") Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com> --- Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com> Cc: Alexandre Torgue <alexandre.torgue@st.com> Cc: Jose Abreu <joabreu@synopsys.com> Cc: "David S. Miller" <davem@davemloft.net> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: netdev@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-arm-kernel@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: Nick Desaulniers <ndesaulniers@google.com> --- drivers/net/ethernet/stmicro/stmmac/dwxgmac2_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)