From patchwork Sat May 6 00:15:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 9714491 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E8898602B9 for ; Sat, 6 May 2017 00:16:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CB83128665 for ; Sat, 6 May 2017 00:16:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BDCD428688; Sat, 6 May 2017 00:16:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A8D9F28665 for ; Sat, 6 May 2017 00:16:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ov4Fk5SprKzmGmWe7GZKIAg5dZREf0jWGPqL8AW39y8=; b=k7WVAyXyIywZRh 7tVKL3ZuH+M9HQHntpvgbAsk+/yjMjshl9R/3HNJjc2Mz4lXKJzscUaFDifeObnkl8DnL1Whul++u dJjxI2nbK2vVTuO2FNMVeSL/iy6ET8EnuNQlje/B+7/hVD4BRxtSPpAUt0FPFuGJeWBsK8HcFKhWg yq1hR10aNolWkojSZ/rW2BnfvXTMhRJwBABxIVq4h+Q93+8p5RZ+FHbCBbP6HxsfyoUpM1nwhbz6t yxRLkIHFoJckFodi056EmPVhhnZncIsTF7sKQ/GL/6hjc81fRUZNXl4EbF8wot0LlWOiDJRUd+M4l GWN/lgn6+c4Zqay5024w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1d6nOB-00088T-RD; Sat, 06 May 2017 00:15:59 +0000 Received: from mail-out.m-online.net ([212.18.0.9]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1d6nO8-00085c-CG for linux-arm-kernel@lists.infradead.org; Sat, 06 May 2017 00:15:58 +0000 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 3wKTmz02pbz1qrtS; Sat, 6 May 2017 02:15:31 +0200 (CEST) Received: from localhost (dynscan01.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 3wKTmy6DKZz3jRB6; Sat, 6 May 2017 02:15:30 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan01.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id eScibjtEaHUR; Sat, 6 May 2017 02:15:29 +0200 (CEST) X-Auth-Info: skma7+2x+yVIopa/UOXI+4DKByYAIUJZa8GGippzkUY= Received: from [IPv6:::1] (unknown [195.140.253.167]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sat, 6 May 2017 02:15:29 +0200 (CEST) Subject: Re: [PATCH 1/5] ARM: dts: imx7-colibri: use OF graph to describe the display To: Stefan Agner , Fabio Estevam References: <20170329232113.19078-1-stefan@agner.ch> <144548a963c8393049f90afd683b331b@agner.ch> From: Marek Vasut Message-ID: <86b6c888-a17b-e19c-8263-ce2b9dd71dea@denx.de> Date: Sat, 6 May 2017 02:15:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <144548a963c8393049f90afd683b331b@agner.ch> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170505_171556_600500_7983181C X-CRM114-Status: GOOD ( 16.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fabio Estevam , Shawn Guo , linux-arm-kernel@lists.infradead.org, Sascha Hauer Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 05/06/2017 01:52 AM, Stefan Agner wrote: > On 2017-05-05 06:18, Fabio Estevam wrote: >> On Fri, May 5, 2017 at 8:48 AM, Fabio Estevam wrote: >> >>> Could you please confirm that drm/mxsfb is working fine on 4.11 on your board? >>> >>> I am converting mx6sx sdb to use drm/mxsfb and I noticed that when >>> board boots I get garbage on the display. >>> >>> If I do a blank/unblank then things are displayed correctly. >> >> Ok, I managed to fix the drm/mxsfb driver. >> >> Will submit a patch shortly. > > FWIW, it works, on i.MX 7 here, but I also have a U-Boot which > initialized eLCDIF first. > > Will check your patch and without U-Boot eLCDIF support. Same thing here, I had U-Boot which inited the eLCDIF too and disabling that triggered this issue on MX6SX as well. Then again, the original patch I sent Fabio fixed it for me too: } diff --git a/drivers/gpu/drm/mxsfb/mxsfb_crtc.c b/drivers/gpu/drm/mxsfb/mxsfb_crtc.c index 6d701d2c362d..f02d23d55995 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_crtc.c +++ b/drivers/gpu/drm/mxsfb/mxsfb_crtc.c @@ -84,6 +84,8 @@ static int mxsfb_set_pixel_fmt(struct mxsfb_drm_private *mxsfb) writel(ctrl1, mxsfb->base + LCDC_CTRL1); writel(ctrl, mxsfb->base + LCDC_CTRL); + writel(ctrl1, mxsfb->base + LCDC_CTRL1); + writel(ctrl, mxsfb->base + LCDC_CTRL); return 0;