diff mbox series

[4/4] ARM: dts: sunxi: Remove useless address and size cells

Message ID 8774db23f87fe401f8ac7b775decba3cde2a56ea.1554153146.git-series.maxime.ripard@bootlin.com (mailing list archive)
State New, archived
Headers show
Series [1/4] dt-bindings: mtd: Add YAML schemas for the generic NAND options | expand

Commit Message

Maxime Ripard April 1, 2019, 9:13 p.m. UTC
The NAND chips in our DTs have address and size cells, even though they
don't have any child nodes. Remove them.

Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
---
 arch/arm/boot/dts/sun5i-gr8-chip-pro.dts             | 2 --
 arch/arm/boot/dts/sun8i-r16-nintendo-nes-classic.dts | 2 --
 2 files changed, 4 deletions(-)

Comments

Miquel Raynal April 2, 2019, 8:19 a.m. UTC | #1
Hi Maxime,

Maxime Ripard <maxime.ripard@bootlin.com> wrote on Mon,  1 Apr 2019
23:13:56 +0200:

> The NAND chips in our DTs have address and size cells, even though they
> don't have any child nodes. Remove them.
> 
> Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> ---
>  arch/arm/boot/dts/sun5i-gr8-chip-pro.dts             | 2 --
>  arch/arm/boot/dts/sun8i-r16-nintendo-nes-classic.dts | 2 --
>  2 files changed, 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts b/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
> index 533a4ecc05e2..a32cde3e32eb 100644
> --- a/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
> +++ b/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
> @@ -133,8 +133,6 @@
>  	status = "okay";
>  
>  	nand@0 {
> -		#address-cells = <2>;
> -		#size-cells = <2>;
>  		reg = <0>;
>  		allwinner,rb = <0>;
>  		nand-ecc-mode = "hw";
> diff --git a/arch/arm/boot/dts/sun8i-r16-nintendo-nes-classic.dts b/arch/arm/boot/dts/sun8i-r16-nintendo-nes-classic.dts
> index 32cf1ab33aab..246dec5846a4 100644
> --- a/arch/arm/boot/dts/sun8i-r16-nintendo-nes-classic.dts
> +++ b/arch/arm/boot/dts/sun8i-r16-nintendo-nes-classic.dts
> @@ -34,8 +34,6 @@
>  
>  	/* 2Gb Macronix MX30LF2G18AC (3V) */
>  	nand@0 {
> -		#address-cells = <1>;
> -		#size-cells = <1>;
>  		reg = <0>;
>  		allwinner,rb = <0>;
>  		nand-ecc-mode = "hw";


Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>


Thanks,
Miquèl
Maxime Ripard April 2, 2019, 11:11 a.m. UTC | #2
On Tue, Apr 02, 2019 at 10:19:52AM +0200, Miquel Raynal wrote:
> Hi Maxime,
>
> Maxime Ripard <maxime.ripard@bootlin.com> wrote on Mon,  1 Apr 2019
> 23:13:56 +0200:
>
> > The NAND chips in our DTs have address and size cells, even though they
> > don't have any child nodes. Remove them.
> >
> > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
> > ---
> >  arch/arm/boot/dts/sun5i-gr8-chip-pro.dts             | 2 --
> >  arch/arm/boot/dts/sun8i-r16-nintendo-nes-classic.dts | 2 --
> >  2 files changed, 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts b/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
> > index 533a4ecc05e2..a32cde3e32eb 100644
> > --- a/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
> > +++ b/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
> > @@ -133,8 +133,6 @@
> >  	status = "okay";
> >
> >  	nand@0 {
> > -		#address-cells = <2>;
> > -		#size-cells = <2>;
> >  		reg = <0>;
> >  		allwinner,rb = <0>;
> >  		nand-ecc-mode = "hw";
> > diff --git a/arch/arm/boot/dts/sun8i-r16-nintendo-nes-classic.dts b/arch/arm/boot/dts/sun8i-r16-nintendo-nes-classic.dts
> > index 32cf1ab33aab..246dec5846a4 100644
> > --- a/arch/arm/boot/dts/sun8i-r16-nintendo-nes-classic.dts
> > +++ b/arch/arm/boot/dts/sun8i-r16-nintendo-nes-classic.dts
> > @@ -34,8 +34,6 @@
> >
> >  	/* 2Gb Macronix MX30LF2G18AC (3V) */
> >  	nand@0 {
> > -		#address-cells = <1>;
> > -		#size-cells = <1>;
> >  		reg = <0>;
> >  		allwinner,rb = <0>;
> >  		nand-ecc-mode = "hw";
>
>
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Applied 3 and 4, thanks!

Maxime

--
Maxime Ripard, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts b/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
index 533a4ecc05e2..a32cde3e32eb 100644
--- a/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
+++ b/arch/arm/boot/dts/sun5i-gr8-chip-pro.dts
@@ -133,8 +133,6 @@ 
 	status = "okay";
 
 	nand@0 {
-		#address-cells = <2>;
-		#size-cells = <2>;
 		reg = <0>;
 		allwinner,rb = <0>;
 		nand-ecc-mode = "hw";
diff --git a/arch/arm/boot/dts/sun8i-r16-nintendo-nes-classic.dts b/arch/arm/boot/dts/sun8i-r16-nintendo-nes-classic.dts
index 32cf1ab33aab..246dec5846a4 100644
--- a/arch/arm/boot/dts/sun8i-r16-nintendo-nes-classic.dts
+++ b/arch/arm/boot/dts/sun8i-r16-nintendo-nes-classic.dts
@@ -34,8 +34,6 @@ 
 
 	/* 2Gb Macronix MX30LF2G18AC (3V) */
 	nand@0 {
-		#address-cells = <1>;
-		#size-cells = <1>;
 		reg = <0>;
 		allwinner,rb = <0>;
 		nand-ecc-mode = "hw";