From patchwork Thu Oct 4 00:33:12 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 1544031 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 70ADDDFF71 for ; Thu, 4 Oct 2012 00:35:44 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1TJZNN-0002x5-3v; Thu, 04 Oct 2012 00:33:17 +0000 Received: from mail-pa0-f49.google.com ([209.85.220.49]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1TJZNJ-0002wr-Eo for linux-arm-kernel@lists.infradead.org; Thu, 04 Oct 2012 00:33:14 +0000 Received: by padbi5 with SMTP id bi5so7447489pad.36 for ; Wed, 03 Oct 2012 17:33:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:organization:references:date:in-reply-to :message-id:user-agent:mime-version:content-type:x-gm-message-state; bh=G9ucF4BXTFVCqOofWWtCcd40aVxV06F5SGS5sht+z10=; b=QDnG/TeeSL/FmIX4eM9EPzEDRcsclBODg1D5/75ahYOuTpRW5+cNyT4pl4H15IiFDM ujB2Qzn/RkbPRxUe5KYbBIp/Tbys8Iy0K0ZnCiMAgYhnNAmcGODSjDOm4JLi3pG0dZwB GogZmgN/EknQlid+zgvZdE8nS+Rff47atq1AJrlTQPYzmPUCDCbqpX5Z0uUzIKKyvxy6 lcIVXcOyrWOp20rXRnM56ZOgFWLdFCZwHXXPZwdHECyEMTGc2kBp2TMMhA85W2zFDF1Z +PEGEPhBTKTKHtpDR81GSQzaqw7BUGzffLdQFf3RqNcG0gRw2YjVjnfXpwkamqtTkRDe rilw== Received: by 10.66.73.226 with SMTP id o2mr8773308pav.83.1349310790984; Wed, 03 Oct 2012 17:33:10 -0700 (PDT) Received: from localhost (c-24-19-7-36.hsd1.wa.comcast.net. [24.19.7.36]) by mx.google.com with ESMTPS id it6sm3377991pbc.14.2012.10.03.17.33.09 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 03 Oct 2012 17:33:10 -0700 (PDT) From: Kevin Hilman To: Tony Lindgren Subject: Re: [PATCH 1/2] ARM: OMAP: hwmod: align the SmartReflex fck names Organization: Deep Root Systems, LLC References: <1349279277-7634-1-git-send-email-j-pihet@ti.com> <1349279277-7634-2-git-send-email-j-pihet@ti.com> <20121003170059.GD4840@atomide.com> Date: Wed, 03 Oct 2012 17:33:12 -0700 In-Reply-To: <20121003170059.GD4840@atomide.com> (Tony Lindgren's message of "Wed, 3 Oct 2012 10:00:59 -0700") Message-ID: <87ehlfvzxz.fsf@deeprootsystems.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 X-Gm-Message-State: ALoCoQkUiUerdVXCIT028zO41BSWgZyNx2XLYTPoLsYIF9ZRECcehmZdyMrQqjdAaBTl7m7HYYmQ X-Spam-Note: CRM114 invocation failed X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.220.49 listed in list.dnswl.org] -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: J Keerthy , jean.pihet@newoldbits.com, Anton Vorontsov , linux-omap@vger.kernel.org, Jean Pihet , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Tony Lindgren writes: > * jean.pihet@newoldbits.com [121003 08:48]: >> @@ -1036,8 +1036,8 @@ static struct omap_clk am33xx_clks[] = { >> CLK("davinci-mcasp.1", NULL, &mcasp1_fck, CK_AM33XX), >> CLK("NULL", "mmc2_fck", &mmc2_fck, CK_AM33XX), >> CLK(NULL, "mmu_fck", &mmu_fck, CK_AM33XX), >> - CLK(NULL, "smartreflex0_fck", &smartreflex0_fck, CK_AM33XX), >> - CLK(NULL, "smartreflex1_fck", &smartreflex1_fck, CK_AM33XX), >> + CLK(NULL, "smartreflex.0", &smartreflex_mpu_fck, CK_AM33XX), >> + CLK(NULL, "smartreflex.1", &smartreflex_core_fck, CK_AM33XX), >> CLK(NULL, "timer1_fck", &timer1_fck, CK_AM33XX), >> CLK(NULL, "timer2_fck", &timer2_fck, CK_AM33XX), >> CLK(NULL, "timer3_fck", &timer3_fck, CK_AM33XX), > > I think this should be something like this instead: > > CLK("smartreflex.0", "fck", &smartreflex_mpu_fck, CK_AM33XX), > CLK("smartreflex.1", "fck", &smartreflex_core_fck, CK_AM33XX), > > Where the first one is the dev name, the second one is the > alias you want to use in the client driver? Actually, the omap_device creation will create this kind of alias for you, with the device name populated etc, so adding device names here isn't necessary. For omap_devices where drivers are always using clk_get(dev, ...), the name in the initial clkdev table here really doesn't matter. However, for core code that needs to do a clk_get(NULL, "name"), then this name matters. In chatting with Paul offline, he mentioned part of the CCF conversion will be using clk_get(NULL, ...) on the main_clk listed in each hwmod. For that reason, it's important that this string match the name in the hwmod. I belive the patch below should make this compatible with any future use. Jean, can you fold this into $SUBJECT patch? Thanks, Kevin diff --git a/arch/arm/mach-omap2/clock33xx_data.c b/arch/arm/mach-omap2/clock33xx_data.c index 6de3dc7..8a16504 100644 --- a/arch/arm/mach-omap2/clock33xx_data.c +++ b/arch/arm/mach-omap2/clock33xx_data.c @@ -1034,8 +1034,8 @@ static struct omap_clk am33xx_clks[] = { CLK("davinci-mcasp.1", NULL, &mcasp1_fck, CK_AM33XX), CLK("NULL", "mmc2_fck", &mmc2_fck, CK_AM33XX), CLK(NULL, "mmu_fck", &mmu_fck, CK_AM33XX), - CLK(NULL, "smartreflex.0", &smartreflex_mpu_fck, CK_AM33XX), - CLK(NULL, "smartreflex.1", &smartreflex_core_fck, CK_AM33XX), + CLK(NULL, "smartreflex_mpu_fck", &smartreflex_mpu_fck, CK_AM33XX), + CLK(NULL, "smartreflex_core_fck", &smartreflex_core_fck, CK_AM33XX), CLK(NULL, "timer1_fck", &timer1_fck, CK_AM33XX), CLK(NULL, "timer2_fck", &timer2_fck, CK_AM33XX), CLK(NULL, "timer3_fck", &timer3_fck, CK_AM33XX), diff --git a/arch/arm/mach-omap2/clock3xxx_data.c b/arch/arm/mach-omap2/clock3xxx_data.c index a197cf2..191d261 100644 --- a/arch/arm/mach-omap2/clock3xxx_data.c +++ b/arch/arm/mach-omap2/clock3xxx_data.c @@ -3447,8 +3447,8 @@ static struct omap_clk omap3xxx_clks[] = { CLK(NULL, "atclk_fck", &atclk_fck, CK_3XXX), CLK(NULL, "traceclk_src_fck", &traceclk_src_fck, CK_3XXX), CLK(NULL, "traceclk_fck", &traceclk_fck, CK_3XXX), - CLK(NULL, "smartreflex.0", &smartreflex_mpu_iva_fck, CK_34XX | CK_36XX), - CLK(NULL, "smartreflex.1", &smartreflex_core_fck, CK_34XX | CK_36XX), + CLK(NULL, "smartreflex_mpu_iva_fck", &smartreflex_mpu_iva_fck, CK_34XX | CK_36XX), + CLK(NULL, "smartreflex_core_fck", &smartreflex_core_fck, CK_34XX | CK_36XX), CLK(NULL, "sr_l4_ick", &sr_l4_ick, CK_34XX | CK_36XX), CLK(NULL, "secure_32k_fck", &secure_32k_fck, CK_3XXX), CLK(NULL, "gpt12_fck", &gpt12_fck, CK_3XXX), diff --git a/arch/arm/mach-omap2/clock44xx_data.c b/arch/arm/mach-omap2/clock44xx_data.c index 9cc1112..19e0c1e 100644 --- a/arch/arm/mach-omap2/clock44xx_data.c +++ b/arch/arm/mach-omap2/clock44xx_data.c @@ -3224,8 +3224,8 @@ static struct omap_clk omap44xx_clks[] = { CLK(NULL, "slimbus2_fclk_0", &slimbus2_fclk_0, CK_443X), CLK(NULL, "slimbus2_slimbus_clk", &slimbus2_slimbus_clk, CK_443X), CLK(NULL, "slimbus2_fck", &slimbus2_fck, CK_443X), - CLK(NULL, "smartreflex.0", &smartreflex_core_fck, CK_443X), - CLK(NULL, "smartreflex.1", &smartreflex_iva_fck, CK_443X), + CLK(NULL, "smartreflex_core_fck", &smartreflex_core_fck, CK_443X), + CLK(NULL, "smartreflex_mpu_fck", &smartreflex_iva_fck, CK_443X), CLK(NULL, "smartreflex.2", &smartreflex_mpu_fck, CK_443X), CLK(NULL, "timer1_fck", &timer1_fck, CK_443X), CLK(NULL, "timer10_fck", &timer10_fck, CK_443X),