From patchwork Fri Jul 22 20:19:21 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kevin Hilman X-Patchwork-Id: 1001012 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by demeter2.kernel.org (8.14.4/8.14.4) with ESMTP id p6MKJaIZ015661 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 22 Jul 2011 20:19:57 GMT Received: from canuck.infradead.org ([2001:4978:20e::1]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1QkMC2-0000tG-DI; Fri, 22 Jul 2011 20:19:30 +0000 Received: from localhost ([127.0.0.1] helo=canuck.infradead.org) by canuck.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QkMC2-0001SV-1E; Fri, 22 Jul 2011 20:19:30 +0000 Received: from na3sys009aog108.obsmtp.com ([74.125.149.199]) by canuck.infradead.org with smtps (Exim 4.76 #1 (Red Hat Linux)) id 1QkMBx-0001Rz-Oy for linux-arm-kernel@lists.infradead.org; Fri, 22 Jul 2011 20:19:27 +0000 Received: from mail-pz0-f53.google.com ([209.85.210.53]) (using TLSv1) by na3sys009aob108.postini.com ([74.125.148.12]) with SMTP ID DSNKTinbS5QJScBKcSeHZIfL3zpTT2T73E7V@postini.com; Fri, 22 Jul 2011 13:19:25 PDT Received: by mail-pz0-f53.google.com with SMTP id 6so5273568pzk.40 for ; Fri, 22 Jul 2011 13:19:23 -0700 (PDT) Received: by 10.68.60.104 with SMTP id g8mr2835424pbr.132.1311365963622; Fri, 22 Jul 2011 13:19:23 -0700 (PDT) Received: from localhost (c-24-19-7-36.hsd1.wa.comcast.net [24.19.7.36]) by mx.google.com with ESMTPS id p7sm2035157pbn.81.2011.07.22.13.19.22 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 22 Jul 2011 13:19:22 -0700 (PDT) From: Kevin Hilman To: Sergei Shtylyov Subject: Re: [RFC/PATCH 3/7] OMAP: McBSP: use existing macros for converting between devices Organization: Texas Instruments, Inc. References: <1311292338-11830-1-git-send-email-khilman@ti.com> <1311292338-11830-5-git-send-email-khilman@ti.com> <4E296DFB.3010205@ru.mvista.com> Date: Fri, 22 Jul 2011 13:19:21 -0700 In-Reply-To: <4E296DFB.3010205@ru.mvista.com> (Sergei Shtylyov's message of "Fri, 22 Jul 2011 16:32:59 +0400") Message-ID: <87y5zqysom.fsf@ti.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20090807-BlameThorstenAndJenny ( TRE 0.7.6 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20110722_161926_050432_453460A6 X-CRM114-Status: GOOD ( 14.63 ) X-Spam-Score: -2.3 (--) X-Spam-Report: SpamAssassin version 3.3.1 on canuck.infradead.org summary: Content analysis details: (-2.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [74.125.149.199 listed in list.dnswl.org] Cc: Paul Walmsley , "G. Manjunath Kondaiah" , devicetree-discuss@lists.ozlabs.org, Grant Likely , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.6 (demeter2.kernel.org [140.211.167.43]); Fri, 22 Jul 2011 20:19:57 +0000 (UTC) Hi Sergei, Sergei Shtylyov writes: > On 22-07-2011 3:52, Kevin Hilman wrote: > >> For converting from struct device to platform_device, and from >> platform_device to struct device, > > You mean from platform_device to omap_device? > Yes indeed, thanks. Updated patch below (only changelog changed) Kevin From e3996fdb48e6850bc3f2a383e86fe67be5796d40 Mon Sep 17 00:00:00 2001 From: Kevin Hilman Date: Thu, 21 Jul 2011 14:03:51 -0700 Subject: [RFC/PATCH 3/7] OMAP: McBSP: use existing macros for converting between devices For converting from struct device to platform_device, and from platform_device to struct omap_device, there are existing macros. Use them instead of manual use of container_of(). Signed-off-by: Kevin Hilman --- arch/arm/plat-omap/mcbsp.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c index 6c62af1..02199e8 100644 --- a/arch/arm/plat-omap/mcbsp.c +++ b/arch/arm/plat-omap/mcbsp.c @@ -260,9 +260,9 @@ EXPORT_SYMBOL(omap_mcbsp_dma_reg_params); #ifdef CONFIG_ARCH_OMAP3 static struct omap_device *find_omap_device_by_dev(struct device *dev) { - struct platform_device *pdev = container_of(dev, - struct platform_device, dev); - return container_of(pdev, struct omap_device, pdev); + struct platform_device *pdev = to_platform_device(dev); + + return to_omap_device(pdev); } static void omap_st_on(struct omap_mcbsp *mcbsp)