| Message ID | 920c7e7169dc6aaaa3eb4bced2336d38e77b8864.1410035142.git.arno@natisbad.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Dear Arnaud Ebalard, On Sat, 06 Sep 2014 22:49:25 +0200, Arnaud Ebalard wrote: > Fixes: 0373a558bd79 ("ARM: mvebu: Enable NAND controller in ReadyNAS 104 .dts file") > Depends-on: 5b3e507820c6 ("mtd: nand: pxa3xx: Use ECC strength and step size devicetree binding") Maybe it's worth noting that it's not a build dependency: your commit changing the Device Tree files can perfectly be applied without the NAND ECC strength and step size bindings. Of course, it will have no effect on an older kernel that doesn't support those bindings, but it will not cause a build failure. Thanks! Thomas
Hi Thomas, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes: > On Sat, 06 Sep 2014 22:49:25 +0200, Arnaud Ebalard wrote: > >> Fixes: 0373a558bd79 ("ARM: mvebu: Enable NAND controller in ReadyNAS 104 .dts file") >> Depends-on: 5b3e507820c6 ("mtd: nand: pxa3xx: Use ECC strength and step size devicetree binding") > > Maybe it's worth noting that it's not a build dependency: your commit > changing the Device Tree files can perfectly be applied without the > NAND ECC strength and step size bindings. Of course, it will have no > effect on an older kernel that doesn't support those bindings, but it > will not cause a build failure. Yes. To be more explicit, if the patches are candidates for stable, I think they are only useful for 3.16.y (3.16 is the first kernel with 5b3e507820c6). As you point, backporting down to 3.14 would not hurt but would only be decorative. Cheers, a+
diff --git a/arch/arm/boot/dts/armada-370-netgear-rn104.dts b/arch/arm/boot/dts/armada-370-netgear-rn104.dts index f7eb110f43d4..d49e8f24a1c9 100644 --- a/arch/arm/boot/dts/armada-370-netgear-rn104.dts +++ b/arch/arm/boot/dts/armada-370-netgear-rn104.dts @@ -165,6 +165,10 @@ marvell,nand-enable-arbiter; nand-on-flash-bbt; + /* Use Hardware BCH ECC */ + nand-ecc-strength = <4>; + nand-ecc-step-size = <512>; + partition@0 { label = "u-boot"; reg = <0x0000000 0x180000>; /* 1.5MB */
The bootloader on the Netgear ReadyNAS RN104 uses Hardware BCH ECC (strength = 4), while the pxa3xx NAND driver by default uses Hamming ECC (strength = 1). This patch changes the ECC mode on these machines to match that of the bootloader and of the stock firmware. That way, it is now possible to update the kernel from userland (e.g. using standard tools from mtd-utils package); u-boot will happily load and boot it. The issue was initially reported and fixed by Ben Pedell for RN102. The RN104 shares the same Hynix H27U1G8F2BTR NAND flash and setup. This patch is based on Ben's fix for RN102. Fixes: 0373a558bd79 ("ARM: mvebu: Enable NAND controller in ReadyNAS 104 .dts file") Depends-on: 5b3e507820c6 ("mtd: nand: pxa3xx: Use ECC strength and step size devicetree binding") Signed-off-by: Arnaud Ebalard <arno@natisbad.org> --- arch/arm/boot/dts/armada-370-netgear-rn104.dts | 4 ++++ 1 file changed, 4 insertions(+)