| Message ID | 9570f274b9649430b34e5c7e15b63679b94c2c50.1414099246.git.geoff@infradead.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Fri, Oct 24, 2014 at 12:10:59AM +0100, Geoff Levand wrote: > Signed-off-by: Geoff Levand <geoff@infradead.org> > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index d92ef3c..ebf8b3f 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -39,6 +39,7 @@ CONFIG_PREEMPT=y > CONFIG_KSM=y > CONFIG_TRANSPARENT_HUGEPAGE=y > CONFIG_CMA=y > +CONFIG_KEXEC=y Given this is going to be incompatible with KVM, and KVM is already in defconfig, I don't think we can add this until that incompatibility is fixed (or at the very least detected and handled gracefully). Thanks, Mark. > CONFIG_CMDLINE="console=ttyAMA0" > # CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set > CONFIG_COMPAT=y > -- > 1.9.1 > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
On Fri, 2014-10-24 at 11:31 +0100, Mark Rutland wrote: > On Fri, Oct 24, 2014 at 12:10:59AM +0100, Geoff Levand wrote: > > Signed-off-by: Geoff Levand <geoff@infradead.org> > > --- > > arch/arm64/configs/defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > index d92ef3c..ebf8b3f 100644 > > --- a/arch/arm64/configs/defconfig > > +++ b/arch/arm64/configs/defconfig > > @@ -39,6 +39,7 @@ CONFIG_PREEMPT=y > > CONFIG_KSM=y > > CONFIG_TRANSPARENT_HUGEPAGE=y > > CONFIG_CMA=y > > +CONFIG_KEXEC=y > > Given this is going to be incompatible with KVM, and KVM is already in > defconfig, I don't think we can add this until that incompatibility is > fixed (or at the very least detected and handled gracefully). Sure, I can put in a workaround to print out a message and fail the kexec_load sys call if KVM is configured. -Geoff
On Fri, Oct 31, 2014 at 11:50:15PM +0000, Geoff Levand wrote: > On Fri, 2014-10-24 at 11:31 +0100, Mark Rutland wrote: > > On Fri, Oct 24, 2014 at 12:10:59AM +0100, Geoff Levand wrote: > > > Signed-off-by: Geoff Levand <geoff@infradead.org> > > > --- > > > arch/arm64/configs/defconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > > index d92ef3c..ebf8b3f 100644 > > > --- a/arch/arm64/configs/defconfig > > > +++ b/arch/arm64/configs/defconfig > > > @@ -39,6 +39,7 @@ CONFIG_PREEMPT=y > > > CONFIG_KSM=y > > > CONFIG_TRANSPARENT_HUGEPAGE=y > > > CONFIG_CMA=y > > > +CONFIG_KEXEC=y > > > > Given this is going to be incompatible with KVM, and KVM is already in > > defconfig, I don't think we can add this until that incompatibility is > > fixed (or at the very least detected and handled gracefully). > > Sure, I can put in a workaround to print out a message and fail the > kexec_load sys call if KVM is configured. What would be the plan for fixing up kexec to work with kvm were we to do that? Thanks, Mark.
Hi Mark, On Mon, 2014-11-03 at 20:05 +0000, Mark Rutland wrote: > On Fri, Oct 31, 2014 at 11:50:15PM +0000, Geoff Levand wrote: > > On Fri, 2014-10-24 at 11:31 +0100, Mark Rutland wrote: > > > On Fri, Oct 24, 2014 at 12:10:59AM +0100, Geoff Levand wrote: > > > > Signed-off-by: Geoff Levand <geoff@infradead.org> > > > > --- > > > > arch/arm64/configs/defconfig | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > > > index d92ef3c..ebf8b3f 100644 > > > > --- a/arch/arm64/configs/defconfig > > > > +++ b/arch/arm64/configs/defconfig > > > > @@ -39,6 +39,7 @@ CONFIG_PREEMPT=y > > > > CONFIG_KSM=y > > > > CONFIG_TRANSPARENT_HUGEPAGE=y > > > > CONFIG_CMA=y > > > > +CONFIG_KEXEC=y > > > > > > Given this is going to be incompatible with KVM, and KVM is already in > > > defconfig, I don't think we can add this until that incompatibility is > > > fixed (or at the very least detected and handled gracefully). > > > > Sure, I can put in a workaround to print out a message and fail the > > kexec_load sys call if KVM is configured. > > What would be the plan for fixing up kexec to work with kvm were we to > do that? As we discussed at on this ML and in detail at Linaro Connect, KVM needs to shut itself down properly and free up the resources it acquired at startup, mainly the hyp mode vectors. I don't have any time free to do that now, but if no one fixes it by the time I do have some time, then I'll work on it. Kexec needs no fixing for this that I know of. -Geoff
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index d92ef3c..ebf8b3f 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -39,6 +39,7 @@ CONFIG_PREEMPT=y CONFIG_KSM=y CONFIG_TRANSPARENT_HUGEPAGE=y CONFIG_CMA=y +CONFIG_KEXEC=y CONFIG_CMDLINE="console=ttyAMA0" # CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set CONFIG_COMPAT=y
Signed-off-by: Geoff Levand <geoff@infradead.org> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)