| Message ID | 96460adbb99ea829a2a95c72a40118f81946a559.1701335951.git.michal.simek@amd.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: zynqmp: Add missing destination mailbox compatible | expand |
On 30/11/2023 10:19, Michal Simek wrote: > The commit 81186dc16101 ("dt-bindings: zynqmp: add destination mailbox > compatible") make compatible string for child nodes mandatory that's why > add it. > > Signed-off-by: Michal Simek <michal.simek@amd.com> > --- > > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > index f5e1eb8cb3b7..eaba466804bc 100644 > --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > @@ -141,6 +141,7 @@ zynqmp_ipi: zynqmp-ipi { > > ipi_mailbox_pmu1: mailbox@ff9905c0 { > bootph-all; > + compatible = "xlnx,zynqmp-ipi-dest-mailbox"; Probably you want it as first property. Although then reg is also placed odd, but it's all because bootph-all was put at the beginning. Best regards, Krzysztof
On 11/30/23 10:29, Krzysztof Kozlowski wrote: > On 30/11/2023 10:19, Michal Simek wrote: >> The commit 81186dc16101 ("dt-bindings: zynqmp: add destination mailbox >> compatible") make compatible string for child nodes mandatory that's why >> add it. >> >> Signed-off-by: Michal Simek <michal.simek@amd.com> >> --- >> >> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi >> index f5e1eb8cb3b7..eaba466804bc 100644 >> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi >> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi >> @@ -141,6 +141,7 @@ zynqmp_ipi: zynqmp-ipi { >> >> ipi_mailbox_pmu1: mailbox@ff9905c0 { >> bootph-all; >> + compatible = "xlnx,zynqmp-ipi-dest-mailbox"; > > Probably you want it as first property. Although then reg is also placed > odd, but it's all because bootph-all was put at the beginning. When DTS conding style is approved I will need to resort all that nodes based on it. I did this change to be aligned with current style which this file has. What do you think? Thanks, Michal
On 30/11/2023 11:02, Michal Simek wrote: > > > On 11/30/23 10:29, Krzysztof Kozlowski wrote: >> On 30/11/2023 10:19, Michal Simek wrote: >>> The commit 81186dc16101 ("dt-bindings: zynqmp: add destination mailbox >>> compatible") make compatible string for child nodes mandatory that's why >>> add it. >>> >>> Signed-off-by: Michal Simek <michal.simek@amd.com> >>> --- >>> >>> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi >>> index f5e1eb8cb3b7..eaba466804bc 100644 >>> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi >>> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi >>> @@ -141,6 +141,7 @@ zynqmp_ipi: zynqmp-ipi { >>> >>> ipi_mailbox_pmu1: mailbox@ff9905c0 { >>> bootph-all; >>> + compatible = "xlnx,zynqmp-ipi-dest-mailbox"; >> >> Probably you want it as first property. Although then reg is also placed >> odd, but it's all because bootph-all was put at the beginning. > > When DTS conding style is approved I will need to resort all that nodes based on > it. I did this change to be aligned with current style which this file has. > What do you think? Hm, indeed. So it is entirely up to you :) Best regards, Krzysztof
On 11/30/23 10:19, Michal Simek wrote: > The commit 81186dc16101 ("dt-bindings: zynqmp: add destination mailbox > compatible") make compatible string for child nodes mandatory that's why > add it. > > Signed-off-by: Michal Simek <michal.simek@amd.com> > --- > > arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > index f5e1eb8cb3b7..eaba466804bc 100644 > --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi > @@ -141,6 +141,7 @@ zynqmp_ipi: zynqmp-ipi { > > ipi_mailbox_pmu1: mailbox@ff9905c0 { > bootph-all; > + compatible = "xlnx,zynqmp-ipi-dest-mailbox"; > reg = <0x0 0xff9905c0 0x0 0x20>, > <0x0 0xff9905e0 0x0 0x20>, > <0x0 0xff990e80 0x0 0x20>, Applied. M
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi index f5e1eb8cb3b7..eaba466804bc 100644 --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi @@ -141,6 +141,7 @@ zynqmp_ipi: zynqmp-ipi { ipi_mailbox_pmu1: mailbox@ff9905c0 { bootph-all; + compatible = "xlnx,zynqmp-ipi-dest-mailbox"; reg = <0x0 0xff9905c0 0x0 0x20>, <0x0 0xff9905e0 0x0 0x20>, <0x0 0xff990e80 0x0 0x20>,
The commit 81186dc16101 ("dt-bindings: zynqmp: add destination mailbox compatible") make compatible string for child nodes mandatory that's why add it. Signed-off-by: Michal Simek <michal.simek@amd.com> --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 1 + 1 file changed, 1 insertion(+)