From patchwork Mon Aug 21 14:45:21 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Murzin X-Patchwork-Id: 9912955 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 791E7600C8 for ; Mon, 21 Aug 2017 14:46:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 577C2204C2 for ; Mon, 21 Aug 2017 14:46:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4C4262861C; Mon, 21 Aug 2017 14:46:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 88EC82879D for ; Mon, 21 Aug 2017 14:46:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Cn0mBTJPiaTqO0xxLI3YtJ7YRN4fLo8Ef4Fpb3kiWD4=; b=LFr+rWToIh5hCG c8iW20pWAkpqJiOHUspgQ8bkZYNnjIely11riJjGqBAJQaAsC/ZpECISLASvwVcffO01ARt3qjfGO 3h7/bMLQkGJvSvWfbLKeINSzWESiJCJIQWmH4E37HFSq/PmyAW/zSjr+O8vFJDDb6T9sHHd8NwqBk 2btwYzuM4GKJRG+WNYmEDLPbg0lE0Izl5YVD4zl/qElDMevNKEy8CMjWE1MXcDbAq00xsCoC7VV1X aVYgvaY0WD3soiPJSXpWQHgMuqib303XQyUOaDNrqxldUcM/NC1cdN6PgMFn73CKnpBJwS5nzGu+k 4SaL0pnbVPX4VFvWnMSw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1djnxz-00019T-HK; Mon, 21 Aug 2017 14:46:11 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1djnxr-000144-JL for linux-arm-kernel@lists.infradead.org; Mon, 21 Aug 2017 14:46:10 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 06C8980D; Mon, 21 Aug 2017 07:45:43 -0700 (PDT) Received: from [10.1.79.19] (unknown [10.1.79.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 57F353F540; Mon, 21 Aug 2017 07:45:41 -0700 (PDT) Subject: Re: [PATCH] drm: hdlcd: allow HDLCD to be used without interrupt To: Russell King - ARM Linux , Liviu Dudau References: <20170726102748.GM31807@n2100.armlinux.org.uk> From: Vladimir Murzin Message-ID: <9cdccb9c-83c5-5867-06a5-3b344102d232@arm.com> Date: Mon, 21 Aug 2017 15:45:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170821_074603_696142_D53F02EE X-CRM114-Status: GOOD ( 14.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, David Airlie , dri-devel@lists.freedesktop.org, Rob Herring , Mali DP Maintainers , Brian Starkey , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 10/08/17 13:15, Vladimir Murzin wrote: > On 26/07/17 11:27, Russell King - ARM Linux wrote: >> I suspect the above failure is down to either (a) not having enough >> memory available to allocate a 1920x1080 frame buffer, or (b) not >> (yet) being able to program the hdlcd pixel clock for this platform, >> which is currently hard-coded in DT at 23.75MHz. > > Given it is NOMMU it is likely (a). Usually, tweaking FORCE_MAX_ZONEORDER > helped me in such cases. Ok, with CONFIG_FORCE_MAX_ZONEORDER=12 I see [ 5.242423] [drm] found ARM HDLCD version r0p0 [ 5.493835] tda998x 2-0070: found TDA19988 [ 5.527771] hdlcd 40205000.hdlcd: bound 2-0070 (ops 0x1470f8) [ 5.535819] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). [ 5.543478] [drm] No driver support for vblank timestamp query. [ 7.443189] hdlcd 40205000.hdlcd: fb0: frame buffer device [ 7.501975] [drm] Initialized hdlcd 1.0.0 20151021 for 40205000.hdlcd on minor 0 when display is connected. To make fb-test [1] happy I had to apply following diff: (The only user of FB_PROVIDE_GET_FB_UNMAPPED_AREA is NOMMU only drivers/gpu/drm/stm/) However, I do not see anything on the screen. I'm probably missing something obvious, so if you have an idea, please let me know and I can test the patch. [1] https://github.com/prpplague/fb-test-app.git Thanks Vladimir > > Cheers > Vladimir > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > diff --git a/drivers/gpu/drm/arm/Kconfig b/drivers/gpu/drm/arm/Kconfig index 9a18e1b..d4cb1b1 100644 --- a/drivers/gpu/drm/arm/Kconfig +++ b/drivers/gpu/drm/arm/Kconfig @@ -10,6 +10,7 @@ config DRM_HDLCD select DRM_ARM select DRM_KMS_HELPER select DRM_KMS_CMA_HELPER + select FB_PROVIDE_GET_FB_UNMAPPED_AREA if !MMU help Choose this option if you have an ARM High Definition Colour LCD controller.