From patchwork Wed Jan 6 17:52:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 12002023 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1AF6C433DB for ; Wed, 6 Jan 2021 17:55:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C7E32311B for ; Wed, 6 Jan 2021 17:55:06 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C7E32311B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:References: To:From:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=BJqKxSXgH6Ey7yWfOvmwu219W276QZwgcYBq/QJoQGc=; b=WZgD3OziVyuQkk2EuQJ/bRXqu yuajM6tNhdQu/1ebUCDlO02B4nnubkvclKmo+fiidTqlkvEVI+Bha8Sp/l1EMxRbliKlh9k+3cVhE P8kZsFKQNFdKpB7AeGAK3O5wYTt+w+VDmEQWMAAzTzGNavrKpNb1DXc7uDcOGStRktrHfQsGS7MSO Htm9ll02sERLPpQByl/1d/VmajXzpddl5l49jiVHaFO+8l/6NbboDDRjEygyDDkNALc9ipOpxpAQv PjVuNySUsa0bFLb4RALb+1H8TcuyCvpctRqYiXRNOvbSBYESo23fyHAB3i/bvj5QnrZjvSb4ne8Cm CfR4Zz5aQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxCzH-0007L9-B9; Wed, 06 Jan 2021 17:52:47 +0000 Received: from mail-ej1-x636.google.com ([2a00:1450:4864:20::636]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxCzB-0007Hx-Cg for linux-arm-kernel@lists.infradead.org; Wed, 06 Jan 2021 17:52:42 +0000 Received: by mail-ej1-x636.google.com with SMTP id b9so6284674ejy.0 for ; Wed, 06 Jan 2021 09:52:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LMhEikvRUZQaIKyyHYQPd9FehVZ9OCrs1+Guuen9CX0=; b=tFjOXOsquLgJec5Svj2aNg4kNYEga6uS+V4sECR+77oIWlS4xBlhguxxaXIZkuBYHd OZZ1n95oRVDx+yVtvgBdvvyopTPR2JG8/n58G717wNHR7eHBAsE7Sx13XZ4FkZV4PGx9 osesB+IphuyUNg7iZLWFLj27JJ2DRykAaRIyzxuGFykfGlo5Q5vsNzk1wfXsfpRGbxfI IxHB8D+rQYOANCJ44ReQstv3M5fVeYevvRHELPRLc9JzCGX8jJYOcCrQNJQTwBIgIUfv rHMAkvrxfD8y8UAs4sWYt+KvY1lpEfKiyv+Mjv8ZrEgX5qHxk9lNvKtAVknzi9brkptg Gyzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LMhEikvRUZQaIKyyHYQPd9FehVZ9OCrs1+Guuen9CX0=; b=LYvyPYQ0HRHZTJy+gMPo4JMUgnezzCgJV+uiN9tTC4eO6Czp+tD6cCxKOZXit1LEtf otmM7Fshu/UIuQqruM0EFvSjR5yXXAKddB+yN5JM68DBs/4FDPB74Z+LFwcSsji18o4c UPPcLMNzAOVxIpqapXQphxIJcEX4Cz8NMC4Cq6D4MvxlRger3MljarFWRfU+5Nj3Kngh 3FnNGyrNF0x/CTLMo5Pu6RrYJ28WyXth3Wb8fFiz7gj7N67FLNLethkVOUDSlw7zS/Ju Suc41f/Jwh4fBZuFeYtkLpg3S8dqv+koAy7Xd005iB8vbsAACvWDK5jFd0J0Jl3x8yu3 ndTQ== X-Gm-Message-State: AOAM5326lGYvxJk/aq+9MM+aLzNpH5aEK6N2PIcZ/tXld5UGw+hHjJvV C3yuSwwlTPoQ4V7AqNpFweA= X-Google-Smtp-Source: ABdhPJzZhqLPes8FWc+g2+meURM8xcd5OE4SEtJiwwW78Jp8SQlh6ANKZ06XF4U9QcDU5ltSn0Ryfg== X-Received: by 2002:a17:906:c790:: with SMTP id cw16mr3694633ejb.344.1609955559148; Wed, 06 Jan 2021 09:52:39 -0800 (PST) Received: from ?IPv6:2003:ea:8f06:5500:e1db:b990:7e09:f1cf? (p200300ea8f065500e1dbb9907e09f1cf.dip0.t-ipconnect.de. [2003:ea:8f06:5500:e1db:b990:7e09:f1cf]) by smtp.googlemail.com with ESMTPSA id d13sm1728045edx.27.2021.01.06.09.52.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Jan 2021 09:52:38 -0800 (PST) Subject: [PATCH v3 3/3] r8169: simplify broken parity handling now that PCI core takes care From: Heiner Kallweit To: Bjorn Helgaas , Russell King - ARM Linux , Realtek linux nic maintainers , David Miller , Jakub Kicinski References: <992c800e-2e12-16b0-4845-6311b295d932@gmail.com> Message-ID: <9e312679-a684-e9c7-2656-420723706451@gmail.com> Date: Wed, 6 Jan 2021 18:52:28 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <992c800e-2e12-16b0-4845-6311b295d932@gmail.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210106_125241_459833_A869541C X-CRM114-Status: GOOD ( 15.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "netdev@vger.kernel.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Meanwhile the PCI core disables parity checking for a device that has broken_parity_status set. Therefore we don't need the quirk any longer to disable parity checking on the first parity error interrupt. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169_main.c | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index c9abc7ccb..024042f37 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -4329,20 +4329,6 @@ static void rtl8169_pcierr_interrupt(struct net_device *dev) if (net_ratelimit()) netdev_err(dev, "PCI error (cmd = 0x%04x, status_errs = 0x%04x)\n", pci_cmd, pci_status_errs); - /* - * The recovery sequence below admits a very elaborated explanation: - * - it seems to work; - * - I did not see what else could be done; - * - it makes iop3xx happy. - * - * Feel free to adjust to your needs. - */ - if (pdev->broken_parity_status) - pci_cmd &= ~PCI_COMMAND_PARITY; - else - pci_cmd |= PCI_COMMAND_SERR | PCI_COMMAND_PARITY; - - pci_write_config_word(pdev, PCI_COMMAND, pci_cmd); rtl_schedule_task(tp, RTL_FLAG_TASK_RESET_PENDING); }