From patchwork Sat Jun 3 20:08:55 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SF Markus Elfring X-Patchwork-Id: 9764495 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DFD94602B6 for ; Sat, 3 Jun 2017 20:09:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CF87E21F61 for ; Sat, 3 Jun 2017 20:09:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C1F1825404; Sat, 3 Jun 2017 20:09:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 54D2E21F61 for ; Sat, 3 Jun 2017 20:09:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:From:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UbnUMVrV55hl2cBvlHd9ub9DLyF9wCwvLkHyJV75BDs=; b=p43ed2qKMxICi0 agvjgP0/rWHi5O4/gFUQ8YkDGGlRwB6C1bBcL3Act7exZ36KlRg/pYRylqE43HbGgMyCtArBYjYQc Neg8shnFv8lsug+rx3qqJE6E8h6XAOpCT/MEVz0c6V08/Fz0c1j3Qs7F02xXR0smrdfYFCNZ+5jPK 3Ue+kyYk4drQ+9A/Ua2XswZYpRZRypEUOgl2TBFtp9WC4xgVpGV8JhNGXAZ5b4Cu4TqaFqTZy4DSE W6F5Xwm3neE0D27oCzB51Ltqv3bX5tMh39JOnqpA+UTYHDk0Wom6UYPJBhfsF6rDt3LPlBS/lSLDd p3tC+8QpYWLwWFMayR3A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dHFMS-0008Vf-9i; Sat, 03 Jun 2017 20:09:24 +0000 Received: from mout.web.de ([212.227.15.4]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dHFMO-0008K4-W6 for linux-arm-kernel@lists.infradead.org; Sat, 03 Jun 2017 20:09:22 +0000 Received: from [192.168.1.2] ([77.182.192.46]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0M7VZv-1e46HP2wzv-00xGa5; Sat, 03 Jun 2017 22:08:56 +0200 Subject: [PATCH 1/3] ARM: pxa: Delete an error message for a failed memory allocation in pxa_pm_init() From: SF Markus Elfring To: linux-arm-kernel@lists.infradead.org, Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King References: Message-ID: <9fb09355-13c4-cad3-a539-55ae7979aa11@users.sourceforge.net> Date: Sat, 3 Jun 2017 22:08:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Provags-ID: V03:K0:zL0/sjxlEXYv+FhW9/voV8OFPEBEewKv6h/n2b3kkrxYJkm9tIe Xr86LhAj90u6BKOvbZn2Wpgmhd1fcBV4tE/orMiu+5zB6+VSoc/+5TUerHwdEuxBKg6E39V MqxkWk8FpulnZ+yhXRkjlDjoyHgkCk+zWLg+7vVh194TkngJT70+yYHPr2cAOtPN7iJjVpd Vz5xV4HGS6nkxe8vosWEg== X-UI-Out-Filterresults: notjunk:1; V01:K0:kQlxn4xMM0g=:hYORWJs4siH1cXp2OISRNB y5qVmvd9A+nZcOsuoU1SNX6Ye8CSATuXmHlJfYkz1mR9ExfphB8j3qht2TQ2UvdBaIZCO+VOL 71gSYb5CZwfOKb9FkoqmJ09bb6E3uG6bfVUqCSs6MksJl1eyYAOdygRflIL7OaXt34RDt9q0G aG7pPkO2Xi5moIqLHhrIS1UvPXzLKyV8iXaVXDIIEkuT7WX0d+kq3kC9FnXpK7TE2qC9T1yeb 4JYN1Is0Phso6t9t6q0F9z4nEYcS8J1biMZEm2etxX9Ln20pgbfkgQ3pBaU2zO1w6kH+GvIY+ yXg5qpshoA/+kCH0lxb4eYeMA9a6lKEuSm9WDvPyfwbGhN9tYPWRed+z2UmSzNKr5fD18w0Zf 1MIUL3yXhRxsU0NLdS76koBq1vYgS3qM6LJOxUAUaJuhxO5klBUv7+AHa47EfZpcZveX91nre gBKelCbrwp/HuhwpFFnsr/DNt/BZmKWXl5yQjfPJ/jAvUvCn2P9QCmvj0wM/ax8u8m6Kfbo6A X8ReH+1phpKaPE6Tta8R5G22LSgzvpw+7dLaaDQuUcEXgUY0lrxmgCa4Ymhfl4sU2cSep4waP d2w3CJXrVvTO+Ipy93ldFLFYcmBFvOOC+BDkhL08r5VJtW/pthcwqbmOWoBf72TUcoEJrmbdY EDD0NI6TgBCrA8iVXJ34F9qIO9NDoUZR6Ut53toA9KYqfPffirBxEYHvGkJnmj1AMVSpKtbJs Q1OfRz5y9J4CVQcxfV3LjDNPVD65vzJdNeuD0LSmAkRbiT/910grEH1Md2Y/g63fl2EnSuK8b 9v4gt7/ X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170603_130921_389910_DFF7B17B X-CRM114-Status: GOOD ( 10.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel-janitors@vger.kernel.org, LKML Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: Markus Elfring Date: Sat, 3 Jun 2017 21:34:48 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- arch/arm/mach-pxa/pm.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm/mach-pxa/pm.c b/arch/arm/mach-pxa/pm.c index e7450fb49d24..f2237f471750 100644 --- a/arch/arm/mach-pxa/pm.c +++ b/arch/arm/mach-pxa/pm.c @@ -110,7 +110,5 @@ static int __init pxa_pm_init(void) - if (!sleep_save) { - printk(KERN_ERR "failed to alloc memory for pm save\n"); + if (!sleep_save) return -ENOMEM; - } suspend_set_ops(&pxa_pm_ops); return 0;