diff mbox

OMAP baseline test results for v3.8-rc5

Message ID C8443D0743D26F4388EA172BF4E2A7A93EA9456A@DBDE01.ent.ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Afzal Mohammed Jan. 28, 2013, 10:34 a.m. UTC
Hi,

On Sat, Jan 26, 2013 at 14:16:04, Balbi, Felipe wrote:
> On Sat, Jan 26, 2013 at 08:40:07AM +0000, Paul Walmsley wrote:

> > * am335xbone: hangs after "Starting kernel"
> >   - Cause unknown; may be due to CONFIG_EARLY_PRINTK=y?
> >   - http://www.mail-archive.com/linux-omap@vger.kernel.org/msg82297.html
> >   - http://marc.info/?l=linux-omap&m=135903184512238&w=2
> 
> FYI, I don't think it's related to CONFIG_EARLY_PRINTK. Tested with and
> without it, also removed CONFIG_DEBUG_LL completely and nothing seemed
> to help my bone, no matter if I had appended DTB or not.

Following patch with low level debug may help to find where the issue is,
(my observation is that it boots with mainline u-boot)

Regards
Afzal

Comments

Felipe Balbi Jan. 28, 2013, 10:47 a.m. UTC | #1
Hi,

On Mon, Jan 28, 2013 at 11:34:15AM +0100, Mohammed, Afzal wrote:
> Hi,
> 
> On Sat, Jan 26, 2013 at 14:16:04, Balbi, Felipe wrote:
> > On Sat, Jan 26, 2013 at 08:40:07AM +0000, Paul Walmsley wrote:
> 
> > > * am335xbone: hangs after "Starting kernel"
> > >   - Cause unknown; may be due to CONFIG_EARLY_PRINTK=y?
> > >   - http://www.mail-archive.com/linux-omap@vger.kernel.org/msg82297.html
> > >   - http://marc.info/?l=linux-omap&m=135903184512238&w=2
> > 
> > FYI, I don't think it's related to CONFIG_EARLY_PRINTK. Tested with and
> > without it, also removed CONFIG_DEBUG_LL completely and nothing seemed
> > to help my bone, no matter if I had appended DTB or not.
> 
> Following patch with low level debug may help to find where the issue is,
> (my observation is that it boots with mainline u-boot)

will try your patch, but are you using Beagle Bone white or black ? I
should've made it clear I'm using beagle bone black.
Afzal Mohammed Jan. 28, 2013, 10:55 a.m. UTC | #2
Hi Felipe,

On Mon, Jan 28, 2013 at 16:17:52, Balbi, Felipe wrote:

> will try your patch, but are you using Beagle Bone white or black ? I
> should've made it clear I'm using beagle bone black.

Hmm.., I am using white, have never tried on black.


Regards
Afzal
Felipe Balbi Jan. 28, 2013, 10:57 a.m. UTC | #3
Hi,

On Mon, Jan 28, 2013 at 11:55:20AM +0100, Mohammed, Afzal wrote:
> Hi Felipe,
> 
> On Mon, Jan 28, 2013 at 16:17:52, Balbi, Felipe wrote:
> 
> > will try your patch, but are you using Beagle Bone white or black ? I
> > should've made it clear I'm using beagle bone black.
> 
> Hmm.., I am using white, have never tried on black.

ok, maybe there's something missing to get Black booting up :-s
Felipe Balbi Jan. 28, 2013, 11:38 a.m. UTC | #4
Hi,

On Mon, Jan 28, 2013 at 11:34:15AM +0100, Mohammed, Afzal wrote:
> Hi,
> 
> On Sat, Jan 26, 2013 at 14:16:04, Balbi, Felipe wrote:
> > On Sat, Jan 26, 2013 at 08:40:07AM +0000, Paul Walmsley wrote:
> 
> > > * am335xbone: hangs after "Starting kernel"
> > >   - Cause unknown; may be due to CONFIG_EARLY_PRINTK=y?
> > >   - http://www.mail-archive.com/linux-omap@vger.kernel.org/msg82297.html
> > >   - http://marc.info/?l=linux-omap&m=135903184512238&w=2
> > 
> > FYI, I don't think it's related to CONFIG_EARLY_PRINTK. Tested with and
> > without it, also removed CONFIG_DEBUG_LL completely and nothing seemed
> > to help my bone, no matter if I had appended DTB or not.
> 
> Following patch with low level debug may help to find where the issue is,
> (my observation is that it boots with mainline u-boot)
> 
> Regards
> Afzal
> 
> 
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index 41b581f..178a411 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -117,6 +117,10 @@ config SOC_AM33XX
>         select CPU_V7
>         select MULTI_IRQ_HANDLER
>         select COMMON_CLK
> +       select MACH_AM335XEVM
> +
> +config MACH_AM335XEVM
> +       bool
> 
>  config OMAP_PACKAGE_ZAF
>         bool

seems to be a bug with __unflatten_device_tree()...

U-Boot SPL 2013.01-00009-g54b08ef (Jan 25 2013 - 10:26:10)
OMAP SD/MMC: 0
reading u-boot.img
reading u-boot.img


U-Boot 2013.01-00009-g54b08ef (Jan 25 2013 - 10:26:10)

I2C:   ready
DRAM:  512 MiB
WARNING: Caches not enabled
NAND:  No NAND device found!!!
0 MiB
MMC:   OMAP SD/MMC: 0, OMAP SD/MMC: 1
*** Warning - readenv() failed, using default environment

musb-hdrc: ConfigData=0xde (UTMI-8, dyn FIFOs, bulk combine, bulk split, HB-ISO Rx, HB-ISO Tx, SoftConn)
musb-hdrc: MHDRC RTL version 2.0 
musb-hdrc: setup fifo_mode 4
musb-hdrc: 28/31 max ep, 16384/16384 memory
USB Peripheral mode controller at 47401000 using PIO, IRQ 0
musb-hdrc: ConfigData=0xde (UTMI-8, dyn FIFOs, bulk combine, bulk split, HB-ISO Rx, HB-ISO Tx, SoftConn)
musb-hdrc: MHDRC RTL version 2.0 
musb-hdrc: setup fifo_mode 4
musb-hdrc: 28/31 max ep, 16384/16384 memory
USB Host mode controller at 47401800 using PIO, IRQ 0
Net:   cpsw, usb_ether
Hit any key to stop autoboot:  1  0 
U-Boot# 
U-Boot# ext2load mmc ${mmcdev}:2 0x80f80000 /boot/am335x-bone.dtb
7967 bytes read in 17 ms (457 KiB/s)
U-Boot# setenv bootargs console=${console} ${optargs} root=${mmcroot} rootfstype=${mmcrootfstype} debug earlyprintk mem=256M
U-Boot# ext2load mmc ${mmcdev}:2 ${loadaddr} ${bootfile}
4265360 bytes read in 502 ms (8.1 MiB/s)
U-Boot# bootm 0x80200000 - 0x80f80000
## Booting kernel from Legacy Image at 80200000 ...
   Image Name:   Linux-3.8.0-rc5-02311-g1308c2b-d
   Image Type:   ARM Linux Kernel Image (uncompressed)
   Data Size:    4265296 Bytes = 4.1 MiB
   Load Address: 80008000
   Entry Point:  80008000
   Verifying Checksum ... OK
## Flattened Device Tree blob at 80f80000
   Booting using the fdt blob at 0x80f80000
   Loading Kernel Image ... OK
OK
   Loading Device Tree to 9fe3e000, end 9fe42f1e ... OK

Starting kernel ...

Uncompressing Linux... done, booting the kernel.
[    0.000000] Booting Linux on physical CPU 0x0
[    0.000000] Linux version 3.8.0-rc5-02311-g1308c2b-dirty (balbi@arwen) (gcc version 4.6.3 (Sourcery CodeBench Lite 2012.03-57) ) #37 SMP Mon Jan 28 13:32:47 EET 2013
[    0.000000] CPU: ARMv7 Processor [413fc082] revision 2 (ARMv7), cr=10c53c7d
[    0.000000] CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing instruction cache
[    0.000000] Machine: Generic AM33XX (Flattened Device Tree), model: TI AM335x BeagleBone
[    0.000000] bootconsole [earlycon0] enabled
[    0.000000] Memory policy: ECC disabled, Data cache writeback
[    0.000000] On node 0 totalpages: 65280
[    0.000000] free_area_init_node: node 0, pgdat c08331c0, node_mem_map c0d91000
[    0.000000]   Normal zone: 512 pages used for memmap
[    0.000000]   Normal zone: 0 pages reserved
[    0.000000]   Normal zone: 64768 pages, LIFO batch:15
[    0.000000] Unable to handle kernel paging request at virtual address dfe3e000
[    0.000000] pgd = c0004000
[    0.000000] [dfe3e000] *pgd=00000000
[    0.000000] Internal error: Oops: 5 [#1] SMP ARM
[    0.000000] Modules linked in:
[    0.000000] CPU: 0    Not tainted  (3.8.0-rc5-02311-g1308c2b-dirty #37)
[    0.000000] PC is at __unflatten_device_tree+0x1c/0x12c
[    0.000000] LR is at unflatten_device_tree+0x1c/0x34
[    0.000000] pc : [<c0457d2c>]    lr : [<c077a370>]    psr: a0000193
[    0.000000] sp : c07a5f80  ip : 00000000  fp : 00000000
[    0.000000] r10: 00000000  r9 : 413fc082  r8 : 80004059
[    0.000000] r7 : c0755dd0  r6 : c0783ac0  r5 : dfe3e000  r4 : c0755dd0
[    0.000000] r3 : d00dfeed  r2 : c0755dd0  r1 : c0d8a8d4  r0 : dfe3e000
[    0.000000] Flags: NzCv  IRQs off  FIQs on  Mode SVC_32  ISA ARM  Segment kernel
[    0.000000] Control: 10c5387d  Table: 80004019  DAC: 00000017
[    0.000000] Process swapper (pid: 0, stack limit = 0xc07a4240)
[    0.000000] Stack: (0xc07a5f80 to 0xc07a6000)
[    0.000000] 5f80: c07b13d0 c00503b4 8fefffff c0d8a8d4 c0755dd0 c083607c c0783ac0 c07a5fe4
[    0.000000] 5fa0: 80004059 c077a370 c0781dd8 c0755028 00000000 c07a5fc4 c0783abc 00000001
[    0.000000] 5fc0: 00000000 c0783abc c07b11c4 c0751618 00000000 00000000 00000000 00000000
[    0.000000] 5fe0: 00000000 c0783ac0 00000000 10c53c7d c07ac98c 80008078 00000000 00000000
[    0.000000] [<c0457d2c>] (__unflatten_device_tree+0x1c/0x12c) from [<c077a370>] (unflatten_device_tree+0x1c/0x34)
[    0.000000] [<c077a370>] (unflatten_device_tree+0x1c/0x34) from [<c0755028>] (setup_arch+0xf8/0x190)
[    0.000000] [<c0755028>] (setup_arch+0xf8/0x190) from [<c0751618>] (start_kernel+0x80/0x2a8)
[    0.000000] [<c0751618>] (start_kernel+0x80/0x2a8) from [<80008078>] (0x80008078)
[    0.000000] Code: e1a07002 e58d100c 0a000033 e59f30f4 (e5951000) 
[    0.000000] ---[ end trace 1b75b31a2719ed1c ]---
[    0.000000] Kernel panic - not syncing: Attempted to kill the idle task!
Mark Jackson Jan. 28, 2013, 11:43 a.m. UTC | #5
On 28/01/13 10:34, Mohammed, Afzal wrote:
> Hi,
> 
> On Sat, Jan 26, 2013 at 14:16:04, Balbi, Felipe wrote:
>> On Sat, Jan 26, 2013 at 08:40:07AM +0000, Paul Walmsley wrote:
> 
>>> * am335xbone: hangs after "Starting kernel"
>>>   - Cause unknown; may be due to CONFIG_EARLY_PRINTK=y?
>>>   - http://www.mail-archive.com/linux-omap@vger.kernel.org/msg82297.html
>>>   - http://marc.info/?l=linux-omap&m=135903184512238&w=2
>>
>> FYI, I don't think it's related to CONFIG_EARLY_PRINTK. Tested with and
>> without it, also removed CONFIG_DEBUG_LL completely and nothing seemed
>> to help my bone, no matter if I had appended DTB or not.
> 
> Following patch with low level debug may help to find where the issue is,
> (my observation is that it boots with mainline u-boot)
> 
> Regards
> Afzal
> 
> 
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index 41b581f..178a411 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -117,6 +117,10 @@ config SOC_AM33XX
>         select CPU_V7
>         select MULTI_IRQ_HANDLER
>         select COMMON_CLK
> +       select MACH_AM335XEVM
> +
> +config MACH_AM335XEVM
> +       bool
> 
>  config OMAP_PACKAGE_ZAF
>         bool
> 

I can confirm that this patch works with EARLY_PRINTK and DEBUG_LL enabled (current mainline kernel
and u-boot), and the following .config changes:-

$ diff .config.omap2plus_defconfig .config
505c505,508
< # CONFIG_ARM_APPENDED_DTB is not set
---
> CONFIG_ARM_APPENDED_DTB=y
> CONFIG_ARM_ATAG_DTB_COMPAT=y
> CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_FROM_BOOTLOADER=y
> # CONFIG_ARM_ATAG_DTB_COMPAT_CMDLINE_EXTEND is not set
2659c2662,2665
< # CONFIG_DEBUG_LL is not set
---
> CONFIG_DEBUG_LL=y
> CONFIG_DEBUG_LL_UART_NONE=y
> # CONFIG_DEBUG_ICEDCC is not set
> # CONFIG_DEBUG_SEMIHOSTING is not set
2660a2667
> CONFIG_EARLY_PRINTK=y

Boot log
--------
Filename '/nanobone/uImage-dtb'.
Load address: 0x80000000
Loading: #################################################################
         #################################################################
         #################################################################
         #################################################################
         #########
         627 KiB/s
done
Bytes transferred = 3946799 (3c392f hex)
## Booting kernel from Legacy Image at 80000000 ...
   Image Name:   Linux 3.8.0-rc5-dirty
   Image Type:   ARM Linux Kernel Image (uncompressed)
   Data Size:    3946735 Bytes = 3.8 MiB
   Load Address: 80008000
   Entry Point:  80008000
   Verifying Checksum ... OK
   Loading Kernel Image ... OK
OK

Starting kernel ...

Uncompressing Linux... done, booting the kernel.
[    0.000000] Booting Linux on physical CPU 0x0
[    0.000000] Linux version 3.8.0-rc5-dirty (mpfj@mpfj-nanobone) (gcc version 4.5.4 (Buildroot
2012.11-git-00497-ge48bf89) ) #9 SMP Mon Jan 28 11:34:19 GMT 2013
[    0.000000] CPU: ARMv7 Processor [413fc082] revision 2 (ARMv7), cr=10c53c7d
[    0.000000] CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing instruction cache
[    0.000000] Machine: Generic AM33XX (Flattened Device Tree), model: TI AM335x BeagleBone
[    0.000000] bootconsole [earlycon0] enabled
[    0.000000] Memory policy: ECC disabled, Data cache writeback
[    0.000000] On node 0 totalpages: 65280
[    0.000000] free_area_init_node: node 0, pgdat c07c7040, node_mem_map c0d27000
[    0.000000]   Normal zone: 512 pages used for memmap
[    0.000000]   Normal zone: 0 pages reserved
[    0.000000]   Normal zone: 64768 pages, LIFO batch:15
[    0.000000] AM335X ES1.0 (neon )
[    0.000000] PERCPU: Embedded 9 pages/cpu @c0f30000 s12992 r8192 d15680 u36864
[    0.000000] pcpu-alloc: s12992 r8192 d15680 u36864 alloc=9*4096
[    0.000000] pcpu-alloc: [0] 0
[    0.000000] Built 1 zonelists in Zone order, mobility grouping on.  Total pages: 64768
[    0.000000] Kernel command line: console=ttyO0,115200n8 earlyprintk debug root=/dev/mmcblk0p2 ro
rootfstype=ext2 rootwait

<snip>

[    1.702800] davinci_mdio 4a101000.mdio: phy[0]: device 4a101000.mdio:00, driver SMSC LAN8710/LAN8720
[    1.713088] Random MACID = 56:e9:38:ee:af:e4
[    1.723695] drivers/rtc/hctosys.c: unable to open rtc device (rtc0)
[    1.735470] Waiting for root device /dev/mmcblk0p2...

Still no support for rootfs on MMC, but hopefully that won't be long ??

Regards
Mark J.
Afzal Mohammed Jan. 28, 2013, 11:46 a.m. UTC | #6
Hi Felipe,

On Mon, Jan 28, 2013 at 17:08:19, Balbi, Felipe wrote:

> seems to be a bug with __unflatten_device_tree()...

> U-Boot# bootm 0x80200000 - 0x80f80000

Try loading dtb at a different address, I do,

bootm 81000000 - 82000000

Regards
Afzal
Felipe Balbi Jan. 28, 2013, 12:16 p.m. UTC | #7
Hi,

On Mon, Jan 28, 2013 at 12:46:21PM +0100, Mohammed, Afzal wrote:
> Hi Felipe,
> 
> On Mon, Jan 28, 2013 at 17:08:19, Balbi, Felipe wrote:
> 
> > seems to be a bug with __unflatten_device_tree()...
> 
> > U-Boot# bootm 0x80200000 - 0x80f80000
> 
> Try loading dtb at a different address, I do,
> 
> bootm 81000000 - 82000000

didn't help :-s

U-Boot# bootm 0x81000000 - 0x82000000
## Booting kernel from Legacy Image at 81000000 ...
   Image Name:   Linux-3.8.0-rc5-02311-g1308c2b-d
   Image Type:   ARM Linux Kernel Image (uncompressed)
   Data Size:    4265296 Bytes = 4.1 MiB
   Load Address: 80008000
   Entry Point:  80008000
   Verifying Checksum ... OK
## Flattened Device Tree blob at 82000000
   Booting using the fdt blob at 0x82000000
   Loading Kernel Image ... OK
OK
   Loading Device Tree to 9fe3e000, end 9fe42f1e ... OK

Starting kernel ...

Uncompressing Linux... done, booting the kernel.
[    0.000000] Booting Linux on physical CPU 0x0
[    0.000000] Linux version 3.8.0-rc5-02311-g1308c2b-dirty (balbi@arwen) (gcc version 4.6.3 (Sourcery CodeBench Lite 2012.03-57) ) #37 SMP Mon
 Jan 28 13:32:47 EET 2013
[    0.000000] CPU: ARMv7 Processor [413fc082] revision 2 (ARMv7), cr=10c53c7d
[    0.000000] CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing instruction cache
[    0.000000] Machine: Generic AM33XX (Flattened Device Tree), model: TI AM335x BeagleBone
[    0.000000] bootconsole [earlycon0] enabled
[    0.000000] Memory policy: ECC disabled, Data cache writeback
[    0.000000] On node 0 totalpages: 65280
[    0.000000] free_area_init_node: node 0, pgdat c08331c0, node_mem_map c0d91000
[    0.000000]   Normal zone: 512 pages used for memmap
[    0.000000]   Normal zone: 0 pages reserved
[    0.000000]   Normal zone: 64768 pages, LIFO batch:15
[    0.000000] Unable to handle kernel paging request at virtual address dfe3e000
[    0.000000] pgd = c0004000
[    0.000000] [dfe3e000] *pgd=00000000
[    0.000000] Internal error: Oops: 5 [#1] SMP ARM
[    0.000000] Modules linked in:
[    0.000000] CPU: 0    Not tainted  (3.8.0-rc5-02311-g1308c2b-dirty #37)
[    0.000000] PC is at __unflatten_device_tree+0x1c/0x12c
[    0.000000] LR is at unflatten_device_tree+0x1c/0x34
[    0.000000] pc : [<c0457d2c>]    lr : [<c077a370>]    psr: a0000193
[    0.000000] sp : c07a5f80  ip : 00000000  fp : 00000000
[    0.000000] r10: 00000000  r9 : 413fc082  r8 : 80004059
[    0.000000] r7 : c0755dd0  r6 : c0783ac0  r5 : dfe3e000  r4 : c0755dd0
[    0.000000] r3 : d00dfeed  r2 : c0755dd0  r1 : c0d8a8d4  r0 : dfe3e000
[    0.000000] Flags: NzCv  IRQs off  FIQs on  Mode SVC_32  ISA ARM  Segment kernel
[    0.000000] Control: 10c5387d  Table: 80004019  DAC: 00000017
[    0.000000] Process swapper (pid: 0, stack limit = 0xc07a4240)
[    0.000000] Stack: (0xc07a5f80 to 0xc07a6000)
[    0.000000] 5f80: c07b13d0 c00503b4 8fefffff c0d8a8d4 c0755dd0 c083607c c0783ac0 c07a5fe4
[    0.000000] 5fa0: 80004059 c077a370 c0781dd8 c0755028 00000000 c07a5fc4 c0783abc 00000001
[    0.000000] 5fc0: 00000000 c0783abc c07b11c4 c0751618 00000000 00000000 00000000 00000000
[    0.000000] 5fe0: 00000000 c0783ac0 00000000 10c53c7d c07ac98c 80008078 00000000 00000000
[    0.000000] [<c0457d2c>] (__unflatten_device_tree+0x1c/0x12c) from [<c077a370>] (unflatten_device_tree+0x1c/0x34)
[    0.000000] [<c077a370>] (unflatten_device_tree+0x1c/0x34) from [<c0755028>] (setup_arch+0xf8/0x190)
[    0.000000] [<c0755028>] (setup_arch+0xf8/0x190) from [<c0751618>] (start_kernel+0x80/0x2a8)
[    0.000000] [<c0751618>] (start_kernel+0x80/0x2a8) from [<80008078>] (0x80008078)
[    0.000000] Code: e1a07002 e58d100c 0a000033 e59f30f4 (e5951000) 
[    0.000000] ---[ end trace 1b75b31a2719ed1c ]---
[    0.000000] Kernel panic - not syncing: Attempted to kill the idle task!
Afzal Mohammed Jan. 28, 2013, 12:18 p.m. UTC | #8
Hi Felipe,

On Mon, Jan 28, 2013 at 17:46:35, Balbi, Felipe wrote:

> didn't help :-s

Hands up :(

Regards
Afzal
AnilKumar, Chimata Jan. 28, 2013, 2:40 p.m. UTC | #9
On Mon, Jan 28, 2013 at 17:48:49, Mohammed, Afzal wrote:
> Hi Felipe,
> 
> On Mon, Jan 28, 2013 at 17:46:35, Balbi, Felipe wrote:
> 
> > didn't help :-s
> 
> Hands up :(

Hi Felipe,

Could you please try with any of these options?

1. Change/add mem=512M (should be same value as u-boot printed RAM size) in your
bootargs?

Or

2. set fdt_high 0xffffffff (at u-boot prompt).

Thanks
AnilKumar
Felipe Balbi Jan. 28, 2013, 4:51 p.m. UTC | #10
Hi,

On Mon, Jan 28, 2013 at 03:40:09PM +0100, AnilKumar, Chimata wrote:
> On Mon, Jan 28, 2013 at 17:48:49, Mohammed, Afzal wrote:
> > Hi Felipe,
> > 
> > On Mon, Jan 28, 2013 at 17:46:35, Balbi, Felipe wrote:
> > 
> > > didn't help :-s
> > 
> > Hands up :(
> 
> Hi Felipe,
> 
> Could you please try with any of these options?
> 
> 1. Change/add mem=512M (should be same value as u-boot printed RAM size) in your
> bootargs?
> 
> Or
> 
> 2. set fdt_high 0xffffffff (at u-boot prompt).

that helped, thank you :-)
diff mbox

Patch

diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index 41b581f..178a411 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -117,6 +117,10 @@  config SOC_AM33XX
        select CPU_V7
        select MULTI_IRQ_HANDLER
        select COMMON_CLK
+       select MACH_AM335XEVM
+
+config MACH_AM335XEVM
+       bool

 config OMAP_PACKAGE_ZAF
        bool