From patchwork Sun Jun 23 08:23:10 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Naresh Kamboju X-Patchwork-Id: 2767021 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id C82C0C0AB1 for ; Sun, 23 Jun 2013 08:32:02 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E029B2011F for ; Sun, 23 Jun 2013 08:32:01 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B57AD2011B for ; Sun, 23 Jun 2013 08:32:00 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UqfiF-0001ww-F7; Sun, 23 Jun 2013 08:31:55 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UqfiD-0000zw-1W; Sun, 23 Jun 2013 08:31:53 +0000 Received: from mail-ob0-x22a.google.com ([2607:f8b0:4003:c01::22a]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Uqfi9-0000zd-BT for linux-arm-kernel@lists.infradead.org; Sun, 23 Jun 2013 08:31:50 +0000 Received: by mail-ob0-f170.google.com with SMTP id ef5so10017195obb.29 for ; Sun, 23 Jun 2013 01:31:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding:x-gm-message-state; bh=Pu1osQ61DQtd3+ocf8QURUD74BltwbroCnuApz9IzOE=; b=Zm6Fkb9eDL6zx6zKRxO5HMrKV3XAB+97u/b1qH93lMhb+MIW+pKThq3c9iIyRJecjl C1yOhCVGU/QJGeNPZiHYl/X/65u9Lz4fbOS/89DaL/Q3gQs8qpYZiT7QQ02ltE9ZPwVZ 70p/AjKb8v4JrLNc7UeUUB09+NYqfuoaBJN4hvnoviXsF74pres9iyPw19Ow/HAsNr80 PzebfFjXTwRtACCyKVpHmQQjJCTRJftL+B4HP2RYFfBsFnLu+A2zbM8J4FIDhoHNyULh WOOUZvwHHes74lSsFTVl7Rz/t95hkgfKYrObnCzOicqOSAr+kFfesoCT3WOSCkSfsjzr 1gsQ== MIME-Version: 1.0 X-Received: by 10.182.237.50 with SMTP id uz18mr6325756obc.51.1371975790432; Sun, 23 Jun 2013 01:23:10 -0700 (PDT) Received: by 10.182.123.66 with HTTP; Sun, 23 Jun 2013 01:23:10 -0700 (PDT) Date: Sun, 23 Jun 2013 13:53:10 +0530 Message-ID: Subject: linux-next: panda build failed at arch/arm/mach-omap2/omap4-restart.c From: Naresh Kamboju To: Robin Holt , Linus Walleij , Andrey Konovalov , Russ Anderson , Tony Lindgren , Russell King X-Gm-Message-State: ALoCoQk47GROipMlmlUmNT9St8D2y/lS2Jokcnc72SO3BdJSJZghX5pgHRWf2jxbd/PKE1VdPzlL X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130623_043149_451890_7BE76433 X-CRM114-Status: UNSURE ( 8.78 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) Cc: Milosz Wasilewski , linux-omap@vger.kernel.org, "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, panda build broken on linux-next branch kernel_config=omap2plus_defconfig KERNEL_VERSION=3.10.0-rc6 KERNEL_GIT=git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git KERNEL_COMMIT=e1a86578747376f08985627c84df088a5d0d1e92 Build error log : ------------------- 04:43:18 CC arch/arm/mach-omap2/omap4-restart.o 04:43:18 /mnt/ci_build/workspace/linux-next/hwpack/panda/label/kernel_cloud/arch/arm/mach-omap2/omap4-restart.c:21:28: warning: ‘enum reboot_mode’ declared inside parameter list [enabled by default] 04:43:18 void omap44xx_restart(enum reboot_mode mode, const char *cmd) 04:43:18 ^ 04:43:18 /mnt/ci_build/workspace/linux-next/hwpack/panda/label/kernel_cloud/arch/arm/mach-omap2/omap4-restart.c:21:28: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default] 04:43:18 /mnt/ci_build/workspace/linux-next/hwpack/panda/label/kernel_cloud/arch/arm/mach-omap2/omap4-restart.c:21:40: error: parameter 1 (‘mode’) has incomplete type 04:43:18 void omap44xx_restart(enum reboot_mode mode, const char *cmd) 04:43:18 ^ 04:43:18 /mnt/ci_build/workspace/linux-next/hwpack/panda/label/kernel_cloud/arch/arm/mach-omap2/omap4-restart.c:21:6: warning: function declaration isn’t a prototype [-Wstrict-prototypes] 04:43:18 void omap44xx_restart(enum reboot_mode mode, const char *cmd) 04:43:18 ^ 04:43:18 make[2]: *** [arch/arm/mach-omap2/omap4-restart.o] Error 1 04:43:18 make[1]: *** [arch/arm/mach-omap2] Error 2 Full build log: ------------------ https://ci.linaro.org/jenkins/job/linux-next/hwpack=panda,label=kernel_cloud/lastBuild/console Suspecting patch which caused build failed: -------------------------------------------------------- commit b61cdf2aebc5cd2f4efc4e0cbebeb8a91884a43e Author: Robin Holt Date: Wed Jun 19 10:08:43 2013 +1000 reboot: arm: change reboot_mode to use enum reboot_mode Preparing to move the parsing of reboot= to generic kernel code forces the change in reboot_mode handling to use the enum. Signed-off-by: Robin Holt ... ... Best regards Naresh Kamboju diff --git a/arch/arm/mach-omap2/omap4-restart.c b/arch/arm/mach-omap2/omap4-restart.c index f90e02e..652adde 100644 --- a/arch/arm/mach-omap2/omap4-restart.c +++ b/arch/arm/mach-omap2/omap4-restart.c @@ -18,7 +18,7 @@ * Resets the SoC. For @cmd, see the 'reboot' syscall in * kernel/sys.c. No return value. */ -void omap44xx_restart(char mode, const char *cmd) +void omap44xx_restart(enum reboot_mode mode, const char *cmd) { /* XXX Should save 'cmd' into scratchpad for use after reboot */ omap4_prminst_global_warm_sw_reset(); /* never returns */