From patchwork Mon Jun 1 05:14:43 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matthijs van Duin X-Patchwork-Id: 6517281 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 784249F326 for ; Mon, 1 Jun 2015 05:19:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8A4AF205BB for ; Mon, 1 Jun 2015 05:19:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 95EEF20582 for ; Mon, 1 Jun 2015 05:19:20 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YzI4Q-0000Ex-7B; Mon, 01 Jun 2015 05:15:30 +0000 Received: from mail-wi0-x22e.google.com ([2a00:1450:400c:c05::22e]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YzI4N-0007x5-Iw for linux-arm-kernel@lists.infradead.org; Mon, 01 Jun 2015 05:15:28 +0000 Received: by wibut5 with SMTP id ut5so27486126wib.1 for ; Sun, 31 May 2015 22:15:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=YeCdjLa8AhsWyeV3I7yOgXB8+tSKg050eRwzxUu4PI0=; b=RFUkzYETNIBVy81NMWKlWeHJJXXNXq6FSkuyhagsyAXtcvyS+J2UcqjT+cfky4aVcN OIiX/jlCjxCyJZdn2mD0lCGzXno8XcM53mn9ltEil0ME2cbiHPAE8v5mKfPKgPqLwlKL zz2alsPFwPyoewnWKQ4QcoaFzvXrPyq361btA/FJjixEzc8C3eQBhd4AnbPWK0xaEmXl jseu+ZA11Abp4jMMiaKfzwynlZiOnbQtA5WvD1vsBzVTj5k3F8Gu0qbbBqLZrwkCNzZJ PMEPWkxhXc4kt8FZ8GORgOiD3QeyCXQVr7xyqwr6/lThUHEVZFrM6MssbjF9zt3fczIu HMxA== X-Received: by 10.180.206.45 with SMTP id ll13mr17090338wic.94.1433135704678; Sun, 31 May 2015 22:15:04 -0700 (PDT) MIME-Version: 1.0 Received: by 10.194.70.227 with HTTP; Sun, 31 May 2015 22:14:43 -0700 (PDT) In-Reply-To: References: <1432136322-7609-1-git-send-email-robertcnelson@gmail.com> From: Matthijs van Duin Date: Mon, 1 Jun 2015 07:14:43 +0200 Message-ID: Subject: Re: [PATCH] ARM: dts: am335x-boneblack: disable RTC-only sleep To: "linux-omap@vger.kernel.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150531_221527_798479_E3B01DA4 X-CRM114-Status: GOOD ( 14.46 ) X-Spam-Score: -0.8 (/) Cc: devicetree , Tony Lindgren , Johan Hovold , Felipe Balbi , Robert Nelson , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Here's a version that attempts to address Tony's earlier request to include some comments in the patch itself. Since I saw no way to concisely summarize the issues, I included links to relevant messages (and enough info to locate the thread again in case of link rot). Since the patch itself contains more explanation, I made the commit message more concise. Apologies for the attachment (inline text would get fucked up by gmail) From 4278ecc32e886d2e83bc486e6409d8f6df82a0d1 Mon Sep 17 00:00:00 2001 From: Matthijs van Duin Date: Mon, 1 Jun 2015 06:56:24 +0200 Subject: [PATCH] ARM: dts: am335x-bone* enable pmic-shutdown-controller Fixes: http://bugs.elinux.org/issues/143 Avoid entering "RTC-only mode" at poweroff. It is unsupported by most versions of BeagleBone, and risks hardware damage. Reported-by: Matthijs van Duin Tested-by: Matthijs van Duin Signed-off-by: Robert Nelson Cc: Tony Lindgren Cc: Felipe Balbi Cc: Johan Hovold [Matthijs van Duin: added explanatory comments] Signed-off-by: Matthijs van Duin --- arch/arm/boot/dts/am335x-bone-common.dtsi | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/arch/arm/boot/dts/am335x-bone-common.dtsi b/arch/arm/boot/dts/am335x-bone-common.dtsi index c3255e0..90fbbb1 100644 --- a/arch/arm/boot/dts/am335x-bone-common.dtsi +++ b/arch/arm/boot/dts/am335x-bone-common.dtsi @@ -223,6 +223,24 @@ /include/ "tps65217.dtsi" &tps { + // Configure pmic to enter OFF-state instead of SLEEP-state ("RTC-only + // mode") at poweroff. Most BeagleBone versions do not support RTC-only + // mode and risk hardware damage if this mode is entered. + // + // For details, see linux-omap mailing list May 2015 thread + // [PATCH] ARM: dts: am335x-bone* enable pmic-shutdown-controller + // In particular, messages: + // http://www.spinics.net/lists/linux-omap/msg118585.html + // http://www.spinics.net/lists/linux-omap/msg118615.html + // + ti,pmic-shutdown-controller; + // + // You can override this later with + // &tps { /delete-property/ ti,pmic-shutdown-controller; } + // if you want to use RTC-only mode and made sure you are not affected + // by the hardware problems. (Tip: double-check by performing a current + // measurement after shutdown: it should be less than 1 mA.) + regulators { dcdc1_reg: regulator@0 { regulator-name = "vdds_dpr"; -- 2.1.4