From patchwork Sun Apr 6 23:45:35 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 3944111 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 81A049F369 for ; Sun, 6 Apr 2014 23:52:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9E5D32026D for ; Sun, 6 Apr 2014 23:52:51 +0000 (UTC) Received: from casper.infradead.org (casper.infradead.org [85.118.1.10]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 594E120254 for ; Sun, 6 Apr 2014 23:52:50 +0000 (UTC) Received: from merlin.infradead.org ([2001:4978:20e::2]) by casper.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WWwrU-0006xV-MW; Sun, 06 Apr 2014 23:52:28 +0000 Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WWwrS-0000sI-Dj; Sun, 06 Apr 2014 23:52:26 +0000 Received: from mail-wg0-f44.google.com ([74.125.82.44]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WWwrP-0000rO-LA for linux-arm-kernel@lists.infradead.org; Sun, 06 Apr 2014 23:52:24 +0000 Received: by mail-wg0-f44.google.com with SMTP id m15so6088311wgh.27 for ; Sun, 06 Apr 2014 16:51:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=JlA5p1abFOpR8TpWqb6lrQ15n768xNpZLUqEzAuuKdQ=; b=aAXTkjl45SzC52uBRIWlc62YRIVP5AGVE9o3Q4SVVpN2yFVjPcwzz5NLbj9q6w/6lt MAEO1FYPn5J8Md0AdJcDPeBgkwvwdQaKbg4O1G9NbecTnBcmtvg/qoRTbpcSi4CbEUma zKo1opVc6d8nVwLN7lpXQ0MAj5htENfl/CpGW8OPFU40/f+1RWLpAFmupfJNgqALQnaT wIqzfqm7pe0+jKutYBLJJWPB5JNzBonrXukNoy/04bT4+KJeG77W7zCEwfTN/6EN02nA C2ugImDoepg34qCjUJ/UIHK0Hrz/5oDpqmnww8snQPOfc1601eJUn2sT4eovTdQn+TsE X8Iw== X-Gm-Message-State: ALoCoQkuosWgVHSOUQB6pO4jvFjnED7GjehdJMDsyztKC8Er7gTgv40jrwSdOet0N+8mi03i1U0F MIME-Version: 1.0 X-Received: by 10.194.186.140 with SMTP id fk12mr37516374wjc.47.1396827935287; Sun, 06 Apr 2014 16:45:35 -0700 (PDT) Received: by 10.180.87.36 with HTTP; Sun, 6 Apr 2014 16:45:35 -0700 (PDT) X-Originating-IP: [95.21.193.102] In-Reply-To: <5341C351.5060406@xenomai.org> References: <1396801938-24788-1-git-send-email-gilles.chanteperdrix@xenomai.org> <5341C351.5060406@xenomai.org> Date: Mon, 7 Apr 2014 01:45:35 +0200 Message-ID: Subject: Re: [PATCH] arm/igep0020: fix IGEPv2 boot From: Javier Martinez Canillas To: Gilles Chanteperdrix X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140406_195223_803903_F56958E6 X-CRM114-Status: GOOD ( 19.11 ) X-Spam-Score: -2.6 (--) Cc: Enric Balletbo i Serra , Tony Lindgren , "linux-arm-kernel@lists.infradead.org" , =?UTF-8?Q?Beno=C3=AEt_Cousson?= X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hello, On Sun, Apr 6, 2014 at 11:12 PM, Gilles Chanteperdrix wrote: > On 04/06/2014 10:04 PM, Javier Martinez Canillas wrote: >> Hello Giles, > > Hi, > >> It looks suspiciously similar to an issue we had due some DT clock >> changes were the IGEPv2 (or any board that used the "ti,omap3" >> compatible string) were initialized as omap3430 instead of omap3630 >> thus using omap3430 clock data which left the UART4 uninitialized. >> >> I fixed that particular issue on commit fb0cfec ("ARM: dts: >> omap3-igep: fix boot fail due wrong compatible match") which was >> merged on v3.14-rc6 so it should be on your v3.14 kernel so maybe is a >> different issue. >> >> I wonder why you are having this issue though since I didn't have that >> problem with 3.14 as far as I can remember. >> >> Can you provide me the exact commit id of your HEAD? or is just the >> tagged v3.14 commit? > > It is the tagged v3.14 commit, with omap2plus_defconfig configuration > My IGEPv2 does not have an omap3630, but a 3530. > > The boot logs say: > [ 0.000000] OMAP3430/3530 ES3.1 (l2cache iva sgx neon isp ) > Then in your case is the exact opposite, that commit seems to broke your board since now it is initialized as an omap3630 instead of an omap3430. So you need to change the compatible string: The problem is that there are too many IGEP boards revisions that use use different SoC (DM3730 or OMAP3530), flash memory type (OneNAND or NAND), memory sizes and connectivity (with or without wifi chip). So to support all different combinations with DeviceTree mean that an exponential number of dts/dtsi is needed to describe each variation so I decided to only support the most common versions: - IGEPv2 with DM3730, NAND, wifi and 512MB of RAM. - IGEP COM Module with DM3730, NAND, wifi and 512MB of RAM. And companies using IGEP boards and mainline could use it as a reference and adapt the DTS to match their board revision. Honestly I didn't know that there were mainline users using the old omap3530 IGEPv2 so I'll prepare some patches to support both DM3730 and OMAP3530 versions. Thanks a lot and best regards, Javier --- a/arch/arm/boot/dts/omap3-igep0020.dts +++ b/arch/arm/boot/dts/omap3-igep0020.dts @@ -14,7 +14,7 @@ / { model = "IGEPv2 (TI OMAP AM/DM37x)"; - compatible = "isee,omap3-igep0020", "ti,omap36xx", "ti,omap3"; + compatible = "isee,omap3-igep0020", "ti,omap3"; leds { pinctrl-names = "default";