diff mbox

[0/9] More ux500 multiplatform stuff

Message ID CACRpkdbdmJrM48dPyV3zWpi6QLnVYcSTnkZbTDTXRSrd+pyVew@mail.gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Linus Walleij March 22, 2013, 2:39 p.m. UTC 
On Fri, Mar 22, 2013 at 2:34 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> On Friday 22 March 2013, Linus Walleij wrote:
>> On Thu, Mar 21, 2013 at 10:51 PM, Arnd Bergmann <arnd@arndb.de> wrote:
>> > This is
>> > what I came up with, on top of your patches. Feel free to take what
>> > you need if you don't already have the same patches.
>> >
>> > I've successfully built "allmodconfig" with all the other v6/v7
>> > platforms enabled as well.
>>
>> Unfortunately the platform stops booting after
>> 2/9 "ARM: ux500: split out prcmu initialization"
>> so I will look closer at this.
>
> Yes, I can see how it has potential for introducing bugs. I hope it's
> something obvious that you can find easily.

You bet:

        db8500_irq_domain = irq_domain_add_simple(

After this the U8500 and U8520 boot to prompt with all the patches
applied!

Patches only need to be agreed upon and ACKed.

I now feel confident that we can merge ux500 multiplatform support
for v3.10.

Yours,
Linus Walleij

Comments

Arnd Bergmann March 22, 2013, 3:25 p.m. UTC | #1 
On Friday 22 March 2013, Linus Walleij wrote:

> diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
> index bc8f870..8eb8c49 100644
> --- a/drivers/mfd/db8500-prcmu.c
> +++ b/drivers/mfd/db8500-prcmu.c
> @@ -2680,7 +2680,7 @@ static int db8500_irq_init(struct device_node
> *np, int irq_base)
>         int i;
> 
>         /* In the device tree case, just take some IRQs */
> -       if (!np)
> +       if (np)
>                 irq_base = 0;
> 
>         db8500_irq_domain = irq_domain_add_simple(

I think I dreamed about this bug last night but didn't remember
until now, and I had not looked there to confirm ;-)

> After this the U8500 and U8520 boot to prompt with all the patches
> applied!

Ah, very good.

	Arnd
diff mbox

Patch

diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
index bc8f870..8eb8c49 100644
--- a/drivers/mfd/db8500-prcmu.c
+++ b/drivers/mfd/db8500-prcmu.c
@@ -2680,7 +2680,7 @@  static int db8500_irq_init(struct device_node
*np, int irq_base)
        int i;

        /* In the device tree case, just take some IRQs */
-       if (!np)
+       if (np)
                irq_base = 0;