From patchwork Fri Jul 11 00:44:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tanmay Inamdar X-Patchwork-Id: 4529221 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 042FA9F1C4 for ; Fri, 11 Jul 2014 00:47:17 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E1997201C0 for ; Fri, 11 Jul 2014 00:47:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B238201B4 for ; Fri, 11 Jul 2014 00:47:15 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1X5Owy-0000Yt-Oj; Fri, 11 Jul 2014 00:44:32 +0000 Received: from exprod5og104.obsmtp.com ([64.18.0.178]) by bombadil.infradead.org with smtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1X5Oww-0000Vr-RS for linux-arm-kernel@lists.infradead.org; Fri, 11 Jul 2014 00:44:31 +0000 Received: from mail-vc0-f170.google.com ([209.85.220.170]) (using TLSv1) by exprod5ob104.postini.com ([64.18.4.12]) with SMTP ID DSNKU78zWE4CqafuotOl1qFJn54X+AC4U1ru@postini.com; Thu, 10 Jul 2014 17:44:30 PDT Received: by mail-vc0-f170.google.com with SMTP id hy10so730931vcb.1 for ; Thu, 10 Jul 2014 17:44:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=QkoQ9W2lht/dc9rAlRU+tHKtn26O+i+arCwzy4h9f3U=; b=VkDlUhDX+qpj2Rib5IZCeJvVGrtbkrO7CtkyBm7e+4f7o4il4mrCyDCllhOPnCTjos CDxfM1wS4xbFDDfaS/zXT73JsSCVZaRSFC67p1AIOzXjs/ggpvlMP4s5fr6CwePn06RI 7ykutnUjJcQ906xp+MBr7HgGrsN738+6xSXYOEu/sbi9HwNtRxtIFDjZL1WT+wcFuHxQ 6ZT4wZg7TxV5g+zE3NOIW03FW0QnDjjvYmvU1KMAkCp8+FFRYJl0zjcL3mT+dV0qT6Vn Z8QVdiavnZ3Mi2F9PdaeIdijQEhH8Aav0CvaVAs2kN74EM64C3kTWzg147qcYog9AqtO aSJQ== X-Gm-Message-State: ALoCoQloNbHhcPzGrqSu6cftvkWLNnPh68lGzCkdWIWeyqmI4Z+RyuGZbwue9V4/VDz6/Nn7epeB6X/0u9G5CqT6Sm/Hni1/QX6L2VIWWLtn0uvwgEhKD4lrqgqcEyZNaomG9PMnLZZ2y7ekdPPrYuMpkGXKm4/H3w== X-Received: by 10.58.165.106 with SMTP id yx10mr49739578veb.17.1405039448180; Thu, 10 Jul 2014 17:44:08 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.58.165.106 with SMTP id yx10mr49739551veb.17.1405039447899; Thu, 10 Jul 2014 17:44:07 -0700 (PDT) Received: by 10.58.195.194 with HTTP; Thu, 10 Jul 2014 17:44:07 -0700 (PDT) In-Reply-To: <20140708171828.GM6501@e106497-lin.cambridge.arm.com> References: <1404240214-9804-1-git-send-email-Liviu.Dudau@arm.com> <20140708171828.GM6501@e106497-lin.cambridge.arm.com> Date: Thu, 10 Jul 2014 17:44:07 -0700 Message-ID: Subject: Re: [PATCH v8 0/9] Support for creating generic PCI host bridges from DT From: Tanmay Inamdar To: Liviu Dudau X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140710_174430_918686_ACBE4BF4 X-CRM114-Status: GOOD ( 23.06 ) X-Spam-Score: -2.3 (--) Cc: Sinan Kaya , linaro-kernel , Catalin Marinas , Arnd Bergmann , Device Tree ML , linux-pci , Jingoo Han , Will Deacon , LKML , Grant Likely , Kukjin Kim , Suravee Suthikulanit , Benjamin Herrenschmidt , Bjorn Helgaas , LAKML X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi, On Tue, Jul 8, 2014 at 10:18 AM, Liviu Dudau wrote: > On Sun, Jul 06, 2014 at 04:23:43PM +0100, Rob Herring wrote: >> On Tue, Jul 1, 2014 at 1:43 PM, Liviu Dudau wrote: >> > This is my resurected attempt at adding support for generic PCI host >> > bridge controllers that make use of device tree information to >> > configure themselves. I've tagged it as v8 although the patches >> > have now been reshuffled in order to ease adoption so referring to >> > the older versions might be a bit of a hoop jumping exercise. >> > >> > Changes from v7: >> > - Reordered the patches so that fixes and non-controversial patches >> > from v7 can be accepted more easily. If agreed I can split the >> > series again into patches that can be upstreamed easily and ones >> > that still need discussion. >> > - Moved the of_create_host_bridge() function to drivers/of/of_pci.c >> > to better reflect its target use. >> > - Added the function to remap the bus I/O resources that used to be >> > provided in my arm64 patch series and (re)named it pci_remap_iospace() >> > - Removed error code checking from parsing and mapping of IRQ from DT >> > in recognition that some PCI devices will not have legacy IRQ mappings. >> > >> > v7 thread here with all the historic information: https://lkml.org/lkml/2014/3/14/279 >> >> Can you publish a branch for this series please. >> >> Rob >> > > Hi Rob, > > I have pushed a brach that matches my v8 patchset +1 obvious missing header include > here: http://www.linux-arm.org/git?p=linux-ld.git;a=shortlog;h=refs/heads/for-upstream/pci_v8 > I was still getting following compilation error after applying arm64 pci headers. Please let me know if I am missing something. linux-git/drivers/of/of_pci.c: In function ‘pci_host_bridge_of_get_ranges’: linux-git/drivers/of/of_pci.c:114:22: error: storage size of ‘range’ isn’t known struct of_pci_range range; ^ linux-git/drivers/of/of_pci.c:115:29: error: storage size of ‘parser’ isn’t known struct of_pci_range_parser parser; ^ linux-git/drivers/of/of_pci.c:121:2: error: implicit declaration of function ‘of_pci_range_parser_init’ [-Werror=implicit-function-declaration] err = of_pci_range_parser_init(&parser, dev); Below patch fixes the errors. > Best regards, > Liviu > > > -- > ==================== > | I would like to | > | fix the world, | > | but they're not | > | giving me the | > \ source code! / > --------------- > ¯\_(?)_/¯ > diff --git a/drivers/of/of_pci.c b/drivers/of/of_pci.c index 55d8320..da88dac 100644 --- a/drivers/of/of_pci.c +++ b/drivers/of/of_pci.c @@ -2,6 +2,7 @@ #include #include #include +#include static inline int __of_pci_pci_compare(struct device_node *node, unsigned int data)