From patchwork Tue Jan 3 15:29:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chanwoo Choi X-Patchwork-Id: 9495083 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 79FE760405 for ; Tue, 3 Jan 2017 15:31:32 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8FD7E27813 for ; Tue, 3 Jan 2017 15:31:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8412727AB2; Tue, 3 Jan 2017 15:31:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0E6A827813 for ; Tue, 3 Jan 2017 15:31:31 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1cOR2R-00050j-5y; Tue, 03 Jan 2017 15:30:11 +0000 Received: from mail-qk0-x243.google.com ([2607:f8b0:400d:c09::243]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1cOR2L-0004Z9-Ow for linux-arm-kernel@lists.infradead.org; Tue, 03 Jan 2017 15:30:06 +0000 Received: by mail-qk0-x243.google.com with SMTP id t184so50821377qkd.1 for ; Tue, 03 Jan 2017 07:29:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:reply-to:in-reply-to:references:from:date:message-id :subject:to:cc; bh=nF3jFjE4Q8QDSKoksf3bADhVzV0V9EcohGxZCw0SYes=; b=er+Zp6vhw/Kaj1CU0U2L3pWEkGP3K9ijP5I3dc273mbnA/nPY4hBGtziuX8u0JTQU5 Th2t7fkVraFFy5o9aPuV0zQVnSCirNGHNaVGolovibMgYOdYfgHS1dSEc7Igc2RTfZn7 R8MA9JnjPnsz4WEOuS1mTkmifj7TyFPYKKZ/HNwJCVtoTWSZ02mZt0bacHlkDZL1ChmO gJNTl4H2eZDUUTbEixg8MDazkmn3B7P+Z5JUplB4ZAQ2bb3hCSGxuO5V7ZU+g5BXtAoI dprdxecRzT4sKgeM8FCBq9cl030PnExEExiDfBCnvwPhT9hsPAecWOB/+oVTNfT/3Dzr yY4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc; bh=nF3jFjE4Q8QDSKoksf3bADhVzV0V9EcohGxZCw0SYes=; b=FlfUL74YwTeUF3YBcP7GlLYN1mamSG6P+X7If6wocdN4CDcwElVP5XfIaAW15WmQ2c hHRxfz04TUtDadZtvN53+nTHKvleiUC119wSC3+qnBmP/ASwtEEXiefKPcWYrohmqH8L iu6dlM/j6+vgZjIGLuz6VdsUp6sym8m2sQ78nfNThYn7kgOm0crzmvXfornGKu4BQKtB 3KCN3DsvJ94e2obukVkVQwgRzT4yJ8YvuxWPtmlgkwRuJS3dBMJefy8yRmrDL/GvQi9P WJWQBudRSvTui7dL1jwEHYqm9MXNMnGVQQ9K1z2peU6d8NebEGlIS+EY/12LGtSLK1C+ pjqw== X-Gm-Message-State: AIkVDXJrCRFEb+VJQ+fzwA+A2lCzdk9UfHRKozazfFVbegQpFAIPRfqCoR2PDOEg6CIO3+zNQhMqsAnsP198uQ== X-Received: by 10.55.44.133 with SMTP id s127mr59854556qkh.131.1483457384324; Tue, 03 Jan 2017 07:29:44 -0800 (PST) MIME-Version: 1.0 Received: by 10.12.129.34 with HTTP; Tue, 3 Jan 2017 07:29:23 -0800 (PST) In-Reply-To: <20170103144056.4ft2ohmhgmezeney@jack.zhora.eu> References: <1483430237-26823-1-git-send-email-jcsing.lee@samsung.com> <1483430237-26823-4-git-send-email-jcsing.lee@samsung.com> <20170103095842.h3hl64amje4qv4ts@gangnam.samsung> <20170103102548.73jg6qddlcthe2mu@gangnam.samsung> <20170103115530.zhjwn7bzmqmumy23@gangnam.samsung> <20170103144056.4ft2ohmhgmezeney@jack.zhora.eu> From: Chanwoo Choi Date: Wed, 4 Jan 2017 00:29:23 +0900 Message-ID: Subject: Re: [PATCH 3/4] arm64: dts: exynos: make tm2 and tm2e independent from each other To: Andi Shyti X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170103_073005_968553_28F85317 X-CRM114-Status: GOOD ( 18.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: cwchoi00@gmail.com Cc: Mark Rutland , devicetree , linux-samsung-soc , Kukjin Kim , Chanwoo Choi , Catalin Marinas , Jaechul Lee , Dmitry Torokhov , Will Deacon , linux-kernel , Andi Shyti , Javier Martinez Canillas , Rob Herring , Krzysztof Kozlowski , linux-input@vger.kernel.org, galaxyra@gmail.com, beomho.seo@samsung.com, linux-arm-kernel Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Andi, 2017-01-03 23:40 GMT+09:00 Andi Shyti : > Hi, > >> FWIW, I also agree with Chanwoo that the difference is too small to >> need a common .dtsi file. > > in principle I don't like "switching on and off" properties by > overwriting them with "status = disable", unless it's really > necessary (and this case is not). Even for small differences. It > makes the DTS harder to read and duplicates nodes with different > values throughout the DTS include chain. > > In my opinion this approach should be discouraged. > > Besides, there are other overwritten differences in tm2e.dts that > I think should be separated as well. The "common" file approach is > widely used in arm/boot/dts/exynos* files. > > The "status = disable" looks to me more like a temporary hack > rather than a permanent solution. > > In any case, still up to you :) > > Andi I think that "status=disabled" of hsi2c_9 is not hack. The overwrite is possible for Device-tree. But, there is just difference how to support them with some method. Except for touchkey, all peripheral device are same on both tm2 and tm2e. There are only small difference for a few property value. To understand the difference between tm2 and tm2e, I made the patch (it is not complete version). If we implement the following patch, we support both tm2 and tm2e. So, I think that it is not complex to understand the h/w difference between tm2 and tm2e. diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts index 1db4e7f..09b6935 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts +++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2e.dts @@ -18,6 +18,17 @@ compatible = "samsung,tm2e", "samsung,exynos5433"; }; +&display_timings { + clock-frequency = <16523724>; + hactive = <1600>; +}; + +&hsi2c_9 { + /* TM2E don't use the separate touchkey device. Instead, touchscreen + * device support the touchkey device.*/ + status = "disabled"; +}; + &ldo23_reg { regulator-name = "CAM_SEN_CORE_1.025V_AP"; regulator-max-microvolt = <1050000>; @@ -39,3 +50,7 @@ regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; }; + +&touchscreen { + x-size = "1599"; +};