From patchwork Tue Jun 6 14:33:23 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Yegor Yefremov X-Patchwork-Id: 9768975 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9EFD460364 for ; Tue, 6 Jun 2017 14:34:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8970E22B27 for ; Tue, 6 Jun 2017 14:34:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7BC7E283BD; Tue, 6 Jun 2017 14:34:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id F1BD722B27 for ; Tue, 6 Jun 2017 14:34:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=j1VSVpGUpcnV3iy/r8zNumByRigZaP+CQur1ZbZAZMQ=; b=at5p5tKR9hAj5X O0yvSawq0tu3LWf4Sqg0U8vdZx3fOVmJz5/5GzrhR+NQPc0eWwWO2RmQEUUHpe+o9oCeZ/F+62vy9 I96+pq/USC/ZZuwsdJcaF9QVY0oyT3BtucWAsdbXrN/yub+DeieMjE2wAQ8HYifMMYYtQnlvkBnrx w/QfODuF++N786vkNukURZX3Vg5gX+sRmN6QoBSMMVNXWDxJPxmaDG2v0903+SBTviCqVrO42k+DV viFLVLAILRIOfivAklmS6GsJL7JdPCzCWUTpJCfdUbOs36Jz8LPaPcPh7ueas58e6qgBE9TSp2WAG mlPJ3fAxb8mL7tZmjv/Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dIFYh-0007QL-Et; Tue, 06 Jun 2017 14:34:11 +0000 Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dIFYd-0007No-EL for linux-arm-kernel@lists.infradead.org; Tue, 06 Jun 2017 14:34:09 +0000 Received: by mail-wr0-x242.google.com with SMTP id u101so7985280wrc.1 for ; Tue, 06 Jun 2017 07:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=qc1KE6q87fOJWSECWgVXp6q07BIEKKUlaU5kJW/4KK4=; b=I4Qx+sifvvbMv4MEDUOtc8o4gsICE0J01UfUr/2ulrJf/ENWtA9RDbQjF25YKL0OKL 2vfTj3lDjSA3vBNTfxTm5scDfrIHOFLtuRhNnsBOmgS6SAGopVA4fBoxVxuIfI3aA07o DqdfwG/sbiXMMadFEuWP8IYp2EAynGENz/kMsCpF1tYEtidR5v7NBkv9Mw5dWxpnlCM9 WU43s8SvCenQ2GHQCCiPdK/PZ72flyd3JuB+O2oMD3mgyjiIdr6bfAIel82Y7MIomDSv zjNspYQREr/pS+7W9sZ+6P+VBBEXvQ3TXH9bLhU/M9uycirVTTDlUoa8ZL/aTAtieEID wN4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qc1KE6q87fOJWSECWgVXp6q07BIEKKUlaU5kJW/4KK4=; b=Z2wjH+/rj+i5nlAjhmV0WRZSqqS2hFNo/puwEPcHY1La5kbaQCmaRzTOF1nzoJQIxc RVSvs6kxVvkeFPPUZeHsDsf0dtbOriVIYa309gPOWgSAmbQboQZKNP6GkFv3ltO5yujW XGu17WfZudIVkfMDvMkgQS7lUe6bYglQSHdzKMgrgYNiAAbQMCV3+ku5OJWS6yX3AXU4 7c3wTFAMFhKSK3pqKkSecsv10IkEqAKbpB/fwGtL1uPBEuQGzH9LbJjm8CzCx82VNdRE DGYl0+6WzpFYOHcfI5tkLP8OqLzOPdZG9ERjnOQ8oGrSrMRwvKkQNHGThrpp5agol4fn UAjA== X-Gm-Message-State: AODbwcCXSAaZdJCdCMxKiOySViisLl9ZGMlw5b8aJWd3UoDcxcRKLIR4 9UwrebEKZXFvpROMz06ZF/bKKtdcoQ== X-Received: by 10.223.165.4 with SMTP id i4mr16212014wrb.148.1496759624647; Tue, 06 Jun 2017 07:33:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.146.162 with HTTP; Tue, 6 Jun 2017 07:33:23 -0700 (PDT) In-Reply-To: References: <20170526180609.2699-1-uwe@kleine-koenig.org> <20170526180609.2699-2-uwe@kleine-koenig.org> <20170531171932.GH3730@atomide.com> From: Yegor Yefremov Date: Tue, 6 Jun 2017 16:33:23 +0200 Message-ID: Subject: Re: [PATCH RFC 2/5] ARM: dts: am335x-baltos: use IRQ_TYPE_* to specify irq flags To: Tony Lindgren X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170606_073407_663727_18883722 X-CRM114-Status: GOOD ( 15.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , devicetree@vger.kernel.org, =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Arnd Bergmann , Rob Herring , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , "linux-omap@vger.kernel.org" , Frank Rowand , linux-arm-kernel Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Wed, May 31, 2017 at 7:22 PM, Yegor Yefremov wrote: > Hi Uwe, Tony, > > On Wed, May 31, 2017 at 7:19 PM, Tony Lindgren wrote: >> * Uwe Kleine-König [170526 11:09]: >>> According to the binding documentation and the source code the omap-gpio >>> controller takes IRQ_TYPE_* as its flags values, not GPIO_ACTIVE_*. >>> >>> This patch uses the right variable type which yields the same result >>> when compiled. Note that this might be wrong and actually >>> IRQ_TYPE_LEVEL_LOW is intended by the dt author. >>> >>> Signed-off-by: Uwe Kleine-König >>> --- >>> Hello, >>> >>> can somebody with the hardware or it's documentation please check which >>> flag is the right one? >> >> I'll wait on this one until we have somebody test it. > > I'll look at it this week. This is what works for me (at least it doesn't produce "irq 88: nobody cared (try booting with the "irqpoll" option)"). As for tca6416 it is working with all possible settings (from IRQ_TYPE_EDGE_RISING till IRQ_TYPE_LEVEL_LOW). "cat /proc/interrupts" always shows Level type: 47: 5 44e07000.gpio 20 Level 1-0020 Yegor diff --git a/arch/arm/boot/dts/am335x-baltos-ir3220.dts b/arch/arm/boot/dts/am335x-baltos-ir3220.dts index 1b215c4..944b095 100644 --- a/arch/arm/boot/dts/am335x-baltos-ir3220.dts +++ b/arch/arm/boot/dts/am335x-baltos-ir3220.dts @@ -85,7 +85,7 @@ gpio-controller; #gpio-cells = <2>; interrupt-parent = <&gpio0>; - interrupts = <20 IRQ_TYPE_EDGE_RISING>; + interrupts = <20 IRQ_TYPE_LEVEL_LOW>; pinctrl-names = "default"; pinctrl-0 = <&tca6416_pins>; }; diff --git a/arch/arm/boot/dts/am335x-baltos-ir5221.dts b/arch/arm/boot/dts/am335x-baltos-ir5221.dts index 832ead8..ae5692b 100644 --- a/arch/arm/boot/dts/am335x-baltos-ir5221.dts +++ b/arch/arm/boot/dts/am335x-baltos-ir5221.dts @@ -94,7 +94,7 @@ gpio-controller; #gpio-cells = <2>; interrupt-parent = <&gpio0>; - interrupts = <20 IRQ_TYPE_EDGE_RISING>; + interrupts = <20 IRQ_TYPE_LEVEL_LOW>; pinctrl-names = "default"; pinctrl-0 = <&tca6416_pins>; }; diff --git a/arch/arm/boot/dts/am335x-baltos.dtsi b/arch/arm/boot/dts/am335x-baltos.dtsi index e3234d4..863942d 100644 --- a/arch/arm/boot/dts/am335x-baltos.dtsi +++ b/arch/arm/boot/dts/am335x-baltos.dtsi @@ -249,7 +249,7 @@ gpio-controller; #gpio-cells = <2>; interrupt-parent = <&gpio1>; - interrupts = <28 IRQ_TYPE_EDGE_RISING>; + interrupts = <28 IRQ_TYPE_EDGE_FALLING>; pinctrl-names = "default"; pinctrl-0 = <&tps65910_pins>; };