From patchwork Wed Oct 1 10:23:25 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vikas Sajjan X-Patchwork-Id: 5010871 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 913169F375 for ; Wed, 1 Oct 2014 10:25:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A42462021B for ; Wed, 1 Oct 2014 10:25:40 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B5A7B2013A for ; Wed, 1 Oct 2014 10:25:39 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1XZH4a-0004hX-SO; Wed, 01 Oct 2014 10:23:52 +0000 Received: from mail-wg0-x233.google.com ([2a00:1450:400c:c00::233]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XZH4X-0004QR-Qj for linux-arm-kernel@lists.infradead.org; Wed, 01 Oct 2014 10:23:50 +0000 Received: by mail-wg0-f51.google.com with SMTP id l18so20161wgh.34 for ; Wed, 01 Oct 2014 03:23:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=X29+s+ZMnJrzj5x5hJcM2I1k4OZKcmV/W/8F0Ovvjes=; b=FVOCYw7Uq8/V9btN2FYgUBemcjqglu1QsAbkn1T1PRUKqJ7dBrerjPBF3ip74hIV0c Atjjl+rCgLJcqw8k6KPLve8qJHaEyjn39vlFqZL/Zu8863Euf2JNFQmbZ4II1/4J+ZlJ 9QKcJMbiIBAOeONEO+PEp0B7Yt1rEwPhb7cpUp7Dqv0AKdJyrHIMGTQN1swiWKX2ptpN NV/Xl1hYCOtAhIswBoeWvINQli7PKsqDpOC8c1L7/fva6mxcSWK2zG+euZWk9tR8bYYT i0dwtn+DjTZ1PebWTT3U1blWLgrGa9GcoTAx2/fF55NBT+Ata/FFB4CWWSyPNAALjJ1N eejw== MIME-Version: 1.0 X-Received: by 10.180.212.48 with SMTP id nh16mr13176708wic.44.1412159005075; Wed, 01 Oct 2014 03:23:25 -0700 (PDT) Received: by 10.194.72.33 with HTTP; Wed, 1 Oct 2014 03:23:25 -0700 (PDT) In-Reply-To: References: <1412074969-12704-1-git-send-email-vikas.sajjan@samsung.com> Date: Wed, 1 Oct 2014 16:08:25 +0545 X-Google-Sender-Auth: zjr9UMgxJpB1kZuQgBiEBL050Ks Message-ID: Subject: Re: [PATCH v8 0/2] Adds PMU and S2R support for exynos5420 From: Vikas Sajjan To: Javier Martinez Canillas X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141001_032350_023801_AB0AFCB1 X-CRM114-Status: GOOD ( 17.87 ) X-Spam-Score: -0.7 (/) Cc: Kukjin Kim , Douglas Anderson , Tomasz Figa , "linux-samsung-soc@vger.kernel.org" , Olof Johansson , sunil joshi , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_NONE,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP HI Javier, On Tue, Sep 30, 2014 at 7:15 PM, Javier Martinez Canillas wrote: > Hello Vikas, > > Thanks a lot for the re-spin. > > On Tue, Sep 30, 2014 at 1:02 PM, Vikas Sajjan wrote: >> >> Tested on Kukjin Kim's tree, for-next branch + >> 1] http://www.spinics.net/lists/linux-samsung-soc/msg33750.html >> 2] https://lkml.org/lkml/2014/9/30/156 > > I wanted to test your series but I noticed that Abhilash's patch: > > "[PATCH v7] ARM: EXYNOS: Use MCPM call-backs to support S2R on Exynos5420" > > does not apply cleanly on Kukjin's for-next branch. I see that all the > dependencies mentioned (modulo $subject or course) have already been > merged though. > > Did you rebase Abhilash's to test your series?. I can forward port as > well but just want to be sure that I'm not missing any other > dependency. > Yea, I did rebase abhilash's MCPM patch to test my series. > These are the patches I've on top of Kukjin's for-next branch fyi: > > 663dfa7 ARM: exynos5: Add Suspend-to-RAM support for 5420 > b4b3b76 ARM: exynos5: Add PMU support for 5420 > 6c0e381 ARM: EXYNOS: Move PMU specific definitions from common.h > cdf79fe ARM: EXYNOS: Add platform driver support for Exynos PMU > d2d8bc6 mfd: syscon: Decouple syscon interface from platform devices > My git log looks like below on top of Kukjin's for-next branch, d861ddd clk: exynos: Add CLK_IGNORE_UNUSED to aclk200_disp1 and aclk300_disp1 adc14dc POSTED: ARM: EXYNOS: Use MCPM call-backs to support S2R on Exynos5420 d61fc43 ARM: exynos5: Add Suspend-to-RAM support for 5420 3d1d7bd ARM: exynos5: Add PMU support for 5420 a8887b3 mfd: syscon: Decouple syscon interface from platform devices 072e2bc ARM: EXYNOS: Move PMU specific definitions from common.h ec2f950 ARM: EXYNOS: Add platform driver support for Exynos PMU recently I noticed that, without the CLK_IGNORE_UNUSED flag for aclk200_disp1 and aclk300_disp1 CLK, the system is NOT suspending, which was NOT the case when i had posted my previous revisions. SRC_MASK_TOP7, 20, 0, 0), Regards Vikas Sajjan > Best regards, > Javier diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers/clk/samsung/clk-exynos5420.c index 848d602..d8b6633 100644 --- a/drivers/clk/samsung/clk-exynos5420.c +++ b/drivers/clk/samsung/clk-exynos5420.c @@ -932,14 +932,14 @@ static struct samsung_gate_clock exynos5x_gate_clks[] __initdata = { GATE(0, "aclk400_mscl", "mout_user_aclk400_mscl", GATE_BUS_TOP, 17, 0, 0), GATE(0, "aclk200_disp1", "mout_user_aclk200_disp1", - GATE_BUS_TOP, 18, 0, 0), + GATE_BUS_TOP, 18, CLK_IGNORE_UNUSED, 0), GATE(CLK_SCLK_MPHY_IXTAL24, "sclk_mphy_ixtal24", "mphy_refclk_ixtal24", GATE_BUS_TOP, 28, 0, 0), GATE(CLK_SCLK_HSIC_12M, "sclk_hsic_12m", "ff_hsic_12m", GATE_BUS_TOP, 29, 0, 0), GATE(0, "aclk300_disp1", "mout_user_aclk300_disp1", - SRC_MASK_TOP2, 24, 0, 0), + SRC_MASK_TOP2, 24, CLK_IGNORE_UNUSED, 0), GATE(CLK_MAU_EPLL, "mau_epll", "mout_mau_epll_clk",