From patchwork Tue Apr 15 09:10:59 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Barry Song <21cnbao@gmail.com> X-Patchwork-Id: 3990131 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 9C2F9BFF02 for ; Tue, 15 Apr 2014 09:14:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CC53720213 for ; Tue, 15 Apr 2014 09:14:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E7383201EC for ; Tue, 15 Apr 2014 09:14:25 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1WZzPT-000662-Ko; Tue, 15 Apr 2014 09:12:07 +0000 Received: from mail-pb0-f43.google.com ([209.85.160.43]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WZzPQ-0005mx-7D for linux-arm-kernel@lists.infradead.org; Tue, 15 Apr 2014 09:12:04 +0000 Received: by mail-pb0-f43.google.com with SMTP id um1so9304926pbc.2 for ; Tue, 15 Apr 2014 02:11:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; bh=87auCyfsb2JMedBDQ5ajFpV6YIncNq2HcADba6U4RvI=; b=V0xGDQs2O/5w2pXPFydpYEu5sEly5pYocEiXWUQ9R/1mSurUYnaXZLNt3KEGuHzcir VaNfTf2BF6Trx0tT93SluOnfPvQSyEld9pEWCZ4vY9yMtraMAi7AuciNibN4sWXwjes5 vRrQ1hxl8JNJkrVwI93HilvsasNnsFY9Z+nnHX6QMQ8YxEYHADl6+eisMdMR2nCMAagf vQd1Bta4fYgE5lSM6ipftzvkDgK1gC1yPRVg0WQNF+Lnasp1TQjzWXziVguEFWL0kE8w oxquTUhLtaxxTz7xRCFuGmxplYDMkXFQvAmjhlE9NYs+rkR/zZKuyN5J06gVIpcE9F1r PkTw== X-Received: by 10.68.181.165 with SMTP id dx5mr767109pbc.38.1397553079783; Tue, 15 Apr 2014 02:11:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.66.237.173 with HTTP; Tue, 15 Apr 2014 02:10:59 -0700 (PDT) In-Reply-To: <20140415050139.GF5969@pengutronix.de> References: <1397529603-16937-1-git-send-email-21cnbao@gmail.com> <20140415050139.GF5969@pengutronix.de> From: Barry Song <21cnbao@gmail.com> Date: Tue, 15 Apr 2014 17:10:59 +0800 Message-ID: Subject: Re: [PATCH] clk: sirf: fix a bundle of checkpatch issues To: =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140415_021204_289475_452F69BA X-CRM114-Status: GOOD ( 12.20 ) X-Spam-Score: -0.8 (/) Cc: Bin Shi , Mike Turquette , "linux-arm-kernel@lists.infradead.org" , DL-SHA-WorkGroupLinux , Barry Song X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP 2014-04-15 13:01 GMT+08:00 Uwe Kleine-König : > Hello, > > On Tue, Apr 15, 2014 at 10:40:03AM +0800, Barry Song wrote: >> From: Bin Shi >> diff --git a/drivers/clk/sirf/clk-atlas6.c b/drivers/clk/sirf/clk-atlas6.c >> index d63b76c..b068feb 100644 >> --- a/drivers/clk/sirf/clk-atlas6.c >> +++ b/drivers/clk/sirf/clk-atlas6.c >> @@ -60,10 +60,10 @@ static struct clk_dmn clk_nand = { >> >> enum atlas6_clk_index { >> /* 0 1 2 3 4 5 6 7 8 9 */ >> - rtc, osc, pll1, pll2, pll3, mem, sys, security, dsp, gps, >> - mf, io, cpu, uart0, uart1, uart2, tsc, i2c0, i2c1, spi0, >> - spi1, pwmc, efuse, pulse, dmac0, dmac1, nand, audio, usp0, usp1, >> - usp2, vip, gfx, gfx2d, lcd, vpp, mmc01, mmc23, mmc45, usbpll, >> + rtc, osc, pll1, pll2, pll3, mem, sys, security, dsp, gps, >> + mf, io, cpu, uart0, uart1, uart2, tsc, i2c0, i2c1, spi0, >> + spi1, pwmc, efuse, pulse, dmac0, dmac1, nand, audio, usp0, usp1, >> + usp2, vip, gfx, gfx2d, lcd, vpp, mmc01, mmc23, mmc45, usbpll, >> usb0, usb1, cphif, maxclk, > Here only the indention is changed, right? I wonder why the last line > was not fixed to be aligned with the others. careful enough, thanks! we can fix that by: > > Best regards > Uwe -barry diff --git a/drivers/clk/sirf/clk-atlas6.c b/drivers/clk/sirf/clk-atlas6.c index b068feb..bca0052 100644 --- a/drivers/clk/sirf/clk-atlas6.c +++ b/drivers/clk/sirf/clk-atlas6.c @@ -59,12 +59,12 @@ static struct clk_dmn clk_nand = { }; enum atlas6_clk_index { - /* 0 1 2 3 4 5 6 7 8 9 */ - rtc, osc, pll1, pll2, pll3, mem, sys, security, dsp, gps, - mf, io, cpu, uart0, uart1, uart2, tsc, i2c0, i2c1, spi0, - spi1, pwmc, efuse, pulse, dmac0, dmac1, nand, audio, usp0, usp1, - usp2, vip, gfx, gfx2d, lcd, vpp, mmc01, mmc23, mmc45, usbpll, - usb0, usb1, cphif, maxclk, + /* 0 1 2 3 4 5 6 7 8 9 */ + rtc, osc, pll1, pll2, pll3, mem, sys, security, dsp, gps, + mf, io, cpu, uart0, uart1, uart2, tsc, i2c0, i2c1, spi0, + spi1, pwmc, efuse, pulse, dmac0, dmac1, nand, audio, usp0, usp1, + usp2, vip, gfx, gfx2d, lcd, vpp, mmc01, mmc23, mmc45, usbpll, + usb0, usb1, cphif, maxclk, };