From patchwork Tue Aug 16 20:06:03 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 9284507 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A09AC60839 for ; Tue, 16 Aug 2016 20:08:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8936F2876B for ; Tue, 16 Aug 2016 20:08:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7CB0E28772; Tue, 16 Aug 2016 20:08:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1A06B2876B for ; Tue, 16 Aug 2016 20:08:42 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bZkdP-0005st-OQ; Tue, 16 Aug 2016 20:06:51 +0000 Received: from mail-ua0-x22e.google.com ([2607:f8b0:400c:c08::22e]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bZkdJ-0005qk-BP for linux-arm-kernel@lists.infradead.org; Tue, 16 Aug 2016 20:06:46 +0000 Received: by mail-ua0-x22e.google.com with SMTP id 97so139968026uav.3 for ; Tue, 16 Aug 2016 13:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=8VjFXT+UPpzmoNMEhgB96ITkQgLxNo+QapzhvDkxiyc=; b=URH70J5kOFXrtFxp5hyrDr/GDVZU9NZXIFlEAVi6+ioV8PLXQx4Z/+ZdveOIQvB5iq noaoryi6EHuMFF9jFJuxN6nq8Cz0ZuF/GUh7Y4d2qat54lrdYLY1KsUo8eudKzjllKVu 07zJk7wFkyfXORfYLq5r4Dp5G8HZjRXJfP8XY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=8VjFXT+UPpzmoNMEhgB96ITkQgLxNo+QapzhvDkxiyc=; b=fxl9/T6VQT3+JhAKnph6EI0Fh1273UJMcytXJuRpFkRAf5eMuldvi5zMDuuCPLx3HF R/M7mv+GOk/AjoyOo/4bz/hRzneAGSEXhtQglPlFuihViwrTRdh08AFwsuAMCsfd7Q/a g6Yq5N8WM5n0/A8yWUkN/FV/4TTIbsnf+n4iKLLNb4TNSQHdSoFw1WkdGnppO7vAChsD raKg8cLHgHPSQxnM8iZAh7Nsf1iLV20RUYjqYH22WxAW6LPFew1naZ14d+gIP6PZcZi2 RDykrOIFc6KCSteDPSxstbNEY4NHv5Zx2Xpm9PKJMdANc7MmgMgaheLBkp9x6Uk50d9d P6yw== X-Gm-Message-State: AEkoouu3tY87DAwZAtq5VQf7irbWzsS4cCBt01jSYP49KQZ8uc+6p09WPNWQqMxH1nYbNe87dFm6aHxV4MKzUkG+ X-Received: by 10.176.3.22 with SMTP id 22mr14350186uat.89.1471377983714; Tue, 16 Aug 2016 13:06:23 -0700 (PDT) MIME-Version: 1.0 Received: by 10.159.37.65 with HTTP; Tue, 16 Aug 2016 13:06:03 -0700 (PDT) In-Reply-To: <665a9824-b0c5-9eb3-d4b6-4821204d5db0@osg.samsung.com> References: <20160601231533.9354-1-stephen.boyd@linaro.org> <20160601231533.9354-18-stephen.boyd@linaro.org> <665a9824-b0c5-9eb3-d4b6-4821204d5db0@osg.samsung.com> From: Stephen Boyd Date: Tue, 16 Aug 2016 13:06:03 -0700 Message-ID: Subject: Re: [PATCH 17/34] clk: maxgen: Migrate to clk_hw based OF and registration APIs To: Javier Martinez Canillas X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160816_130645_724403_4D8E6E85 X-CRM114-Status: GOOD ( 13.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Turquette , Stephen Boyd , Linux Kernel , Javier Martinez Canillas , linux-clk@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, Jun 7, 2016 at 11:55 AM, Javier Martinez Canillas wrote: > On 06/07/2016 02:50 PM, Javier Martinez Canillas wrote: >> Hello Stephen, >> >> On Wed, Jun 1, 2016 at 7:15 PM, Stephen Boyd wrote: >>> Now that we have clk_hw based provider APIs to register clks, we >>> can get rid of struct clk pointers while registering clks in >>> these drivers, allowing us to move closer to a clear split of >>> consumer and provider clk APIs. >>> >>> Cc: Javier Martinez Canillas >> >> This email address doesn't exist anymore, you can use >> javier@osg.samsung.com instead. >> >>> Signed-off-by: Stephen Boyd >>> --- >>> >>> See commit 58657d189a2f and it's children for details on this >>> new registration API. >>> >> >> I tried this patch on top of linux-next and my Peach Pi Chromebook >> (that has a max77802 chip) failed to boot. Following is the relevant >> parts from the boot log: >> > > It seems the mailer did a mess with the line wrapping so here's another attempt: > Thanks! Found the problem too. ----8<----- return ret; diff --git a/drivers/clk/clk-max-gen.c b/drivers/clk/clk-max-gen.c index 4bb53fcf8639..5e8bac190698 100644 --- a/drivers/clk/clk-max-gen.c +++ b/drivers/clk/clk-max-gen.c @@ -169,7 +169,7 @@ int max_gen_clk_probe(struct platform_device *pdev, struct regmap *regmap, if (dev->of_node) { ret = of_clk_add_hw_provider(dev->of_node, of_clk_max_gen_get, - max_gen_clks); + max_gen_data); if (ret) { dev_err(dev, "failed to register OF clock provider\n");