From patchwork Fri Apr 24 19:32:28 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pranith Kumar X-Patchwork-Id: 6273341 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 069C49F389 for ; Fri, 24 Apr 2015 19:35:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3CFB1202F2 for ; Fri, 24 Apr 2015 19:35:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 70E432021A for ; Fri, 24 Apr 2015 19:35:37 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YljLs-0005ur-AO; Fri, 24 Apr 2015 19:33:28 +0000 Received: from mail-ie0-x229.google.com ([2607:f8b0:4001:c03::229]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YljLm-0005qU-Dh; Fri, 24 Apr 2015 19:33:23 +0000 Received: by iedfl3 with SMTP id fl3so102442542ied.1; Fri, 24 Apr 2015 12:32:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=yee2k6mVlYi7gIiJCU16q6FPwi4sCicwO/NPBoc0P5c=; b=LbCqJznNCjAehGYyF8Je7aB1e8QS3r372G0pS957O7x3Hp8d5c186L3CVtuHEgOFez 7YAaKzKP5KutYGP+H88Fg8i0aF1C8+wJ345mGSvUXaU3Hg53wWODgG0o9QeQh4Ofby3E KL6NRmJMbAoMcJLofmRMMbE/o4/QYTmbghnBgjQNT3vl2FnhJvfOrGL1HACPcUTeyUqC WUD1H6mq1XWi3mlW5/9wKscHcLTpkc5jixYtLmqSZ3on1eiRLqYdoEg5+Hm8Y3FvjBCT NLObnbPRgRL2jnWB812owcwXJdKcc7S0RYIiiQKMqKIzIZpWoIbkB9+dp07U2JH1n57/ n+Nw== X-Received: by 10.42.99.205 with SMTP id x13mr619748icn.53.1429903978860; Fri, 24 Apr 2015 12:32:58 -0700 (PDT) MIME-Version: 1.0 Received: by 10.50.76.170 with HTTP; Fri, 24 Apr 2015 12:32:28 -0700 (PDT) In-Reply-To: <1429902534-2348-2-git-send-email-eric@anholt.net> References: <1429902534-2348-1-git-send-email-eric@anholt.net> <1429902534-2348-2-git-send-email-eric@anholt.net> From: Pranith Kumar Date: Fri, 24 Apr 2015 15:32:28 -0400 Message-ID: Subject: Re: [PATCH 2/2] ARM: BCM2835: Move the restart/power_off handling to the WDT driver. To: Eric Anholt X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150424_123322_525980_E920EEA6 X-CRM114-Status: GOOD ( 11.76 ) X-Spam-Score: -0.1 (/) Cc: "open list:WATCHDOG DEVICE D..." , "moderated list:ARM PORT" , linux-rpi-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Fri, Apr 24, 2015 at 3:08 PM, Eric Anholt wrote: > Since the WDT is what's used to drive restart and power off, it makes > more sense to keep it there, where the regs are already mapped and > definitions for them provided. Note that this means you may need to > add CONFIG_BCM2835_WDT to retain functionality of your kernel. > > Signed-off-by: Eric Anholt > Cc: linux-watchdog@vger.kernel.org Any reason not to select BCM2835_WDT in the config by default then? Signed-off-by: Pranith Kumar diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig index 8b11f44..dd4856d 100644 --- a/arch/arm/mach-bcm/Kconfig +++ b/arch/arm/mach-bcm/Kconfig @@ -116,6 +116,7 @@ config ARCH_BCM2835 select CLKSRC_OF select PINCTRL select PINCTRL_BCM2835 + select BCM2835_WDT help This enables support for the Broadcom BCM2835 SoC. This SoC is used in the Raspberry Pi and Roku 2 devices.