From patchwork Thu Jan 29 03:39:03 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 5737121 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 7C4F19F38B for ; Thu, 29 Jan 2015 03:41:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 92C6D201BB for ; Thu, 29 Jan 2015 03:41:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA0222017D for ; Thu, 29 Jan 2015 03:41:52 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YGfx1-0001eq-88; Thu, 29 Jan 2015 03:39:27 +0000 Received: from mail-oi0-f41.google.com ([209.85.218.41]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YGfwz-0001be-4s for linux-arm-kernel@lists.infradead.org; Thu, 29 Jan 2015 03:39:25 +0000 Received: by mail-oi0-f41.google.com with SMTP id z81so22900824oif.0 for ; Wed, 28 Jan 2015 19:39:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=EAZcswWSspC1/oKXEMJVApuSGXqGhbfTUTpABzY0wjY=; b=RZx+rwQFddSo08HGgw++Rila9Cd9Kk9qXIoHr2yNyX3LplrIMOLGpg5Nn66i5/1qxt dDdb107Vm2EeB9lSjfLZe5zIqob+/7rO8FMtqv0VhBYfOsQDNGqabex9CXYLzFeuhVHu Guxnutj8fI7Hp2Jd78+p1gKChcgNjSqQ5EO9ZX6SUUV+z9UmcWHlivqP3uOSxkMvFUQk lzpo0nhfPuB5H4RjFZQ1yTG1bfdVrCFoe3k43cGioV0PjDs5KI8+Tr59LBW2KAk7lEVs viYNwWj90Lv4e+KMTL82tQ4Xb8MqsDs19nI9M5Cp93++bZF9XVSLJ2uFBgrwT8DoelX5 c5mw== X-Gm-Message-State: ALoCoQlgvXJIhIQ0YoyBvqc1DxkI7hjVktSaPS6N/kqzRApWq9VRE8kqvR1auntzaoAonI6K0hie MIME-Version: 1.0 X-Received: by 10.202.54.67 with SMTP id d64mr4040083oia.55.1422502743562; Wed, 28 Jan 2015 19:39:03 -0800 (PST) Received: by 10.182.33.34 with HTTP; Wed, 28 Jan 2015 19:39:03 -0800 (PST) In-Reply-To: <1799972.nQ2Axu0CEJ@wuerfel> References: <1422451015-390439-1-git-send-email-arnd@arndb.de> <1422451015-390439-4-git-send-email-arnd@arndb.de> <20150128172209.GF29600@developer.hsd1.ca.comcast.net> <1799972.nQ2Axu0CEJ@wuerfel> Date: Thu, 29 Jan 2015 09:09:03 +0530 Message-ID: Subject: Re: [PATCH 3/3] cpufreq: exynos: allow modular build From: Viresh Kumar To: Arnd Bergmann X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150128_193925_235787_6953DCE6 X-CRM114-Status: GOOD ( 10.70 ) X-Spam-Score: -0.7 (/) Cc: linux-samsung-soc , "linux-pm@vger.kernel.org" , "Rafael J. Wysocki" , Eduardo Valentin , Kukjin Kim , Zhang Rui , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 29 January 2015 at 01:31, Arnd Bergmann wrote: >> config ARM_EXYNOS_CPUFREQ >> - bool >> + tristate "SAMSUNG EXYNOS CPUfreq Driver" >> + depends on THERMAL >> + default y >> + help >> + This adds the CPUFreq driver for Samsung EXYNOS platforms >> + >> + If in doubt, say N. > > Now the option shows up on all systems that include Kconfig.arm, > in particular non-exynos machines that might not even be able > to build this. I am sure I am wrong here, but want to know what I am missing. What about: diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index c3c3cf52d2d9..f3ee05067a69 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm @@ -27,7 +27,7 @@ config ARM_VEXPRESS_SPC_CPUFREQ config ARM_EXYNOS_CPUFREQ tristate "SAMSUNG EXYNOS CPUfreq Driver" - depends on THERMAL + depends on THERMAL && ARCH_EXYNOS default y help This adds the CPUFreq driver for Samsung EXYNOS platforms