From patchwork Mon Mar 11 00:57:49 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viresh Kumar X-Patchwork-Id: 2246161 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id 4834F3FC8A for ; Mon, 11 Mar 2013 01:00:46 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1UEr3v-0004ys-3F; Mon, 11 Mar 2013 00:57:59 +0000 Received: from mail-ob0-x22c.google.com ([2607:f8b0:4003:c01::22c]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1UEr3q-0004ya-Ku for linux-arm-kernel@lists.infradead.org; Mon, 11 Mar 2013 00:57:55 +0000 Received: by mail-ob0-f172.google.com with SMTP id tb18so2844315obb.17 for ; Sun, 10 Mar 2013 17:57:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type:x-gm-message-state; bh=CATx2lciI0BohIdGold6AcbBllzGTrfB9eJvQ35z2VM=; b=ZDwoZe3a7k8awVsp7h43qWdrNDS5y3SpCvVr8YrrTcjMqPH8lKXIdQUgKS/+B+0l95 bDNFxaUzBCZQTwTmQ05SmBc7/3NyVvM+u+65q3iyFXpRQOQbcYMb/tLZ8d47vf22PLs6 D2+TzjGyzwL3zZAZqsdH64QN+Et0ATUFd39u1tM0Jk8yUamcT41sZyeOr1EVWVsoqrdQ 4W1SAvnyG2kflREbMhf4+7ooI84B9JS2Gial7hiicRjOBHs8rZFRvALyPRCO3R4AEYn5 AYuLTd2c2dRZpJz9k3EG15Vjxdbiq76MBhYkwa7nA6oRr3ijAoXz7CXMVmbliHTQo+Yn KCFg== MIME-Version: 1.0 X-Received: by 10.182.8.70 with SMTP id p6mr7075487oba.90.1362963470192; Sun, 10 Mar 2013 17:57:50 -0700 (PDT) Received: by 10.182.69.20 with HTTP; Sun, 10 Mar 2013 17:57:49 -0700 (PDT) In-Reply-To: <513CAD9B.908@gmail.com> References: <6cba8f153cfd4b0d3075a34a6dfe287bdec2eb06.1362676407.git.viresh.kumar@linaro.org> <513CAD9B.908@gmail.com> Date: Mon, 11 Mar 2013 08:57:49 +0800 Message-ID: Subject: Re: [PATCH V2] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue From: Viresh Kumar To: Francesco Lavra X-Gm-Message-State: ALoCoQnJ7Lt1xtDB2B752q7Vm1L6QE970t4qRo1EFFWJpOACclB6y5Wxk1Y7AiYPuZ0MUd26KZ9w X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130310_205754_904575_B5EDBBD9 X-CRM114-Status: UNSURE ( 9.47 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -1.9 (-) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-1.9 points) pts rule name description ---- ---------------------- -------------------------------------------------- -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: Steve.Bannister@arm.com, linux@arm.linux.org.uk, linux-pm@vger.kernel.org, Sudeep KarkadaNagesha , devicetree-discuss@lists.ozlabs.org, Liviu.Dudau@arm.com, linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org, rjw@sisk.pl, robin.randhawa@arm.com, mark.hambleton@broadcom.com, linaro-kernel@lists.linaro.org, linux-arm-kernel@lists.infradead.org, charles.garcia-tobin@arm.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On 10 March 2013 23:58, Francesco Lavra wrote: > On 03/07/2013 06:14 PM, Viresh Kumar wrote: >> +void bL_cpufreq_unregister(struct cpufreq_arm_bL_ops *ops) >> +{ >> + if (arm_bL_ops != ops) { >> + pr_info("%s: Registered with: %s, can't unregister, exiting\n", >> + __func__, arm_bL_ops->name); >> + } > > The code is not doing what the info message says. Yes, following is the improvement: linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c index 8b8b07e..9d449cf 100644 --- a/drivers/cpufreq/arm_big_little.c +++ b/drivers/cpufreq/arm_big_little.c @@ -264,8 +264,9 @@ EXPORT_SYMBOL_GPL(bL_cpufreq_register); void bL_cpufreq_unregister(struct cpufreq_arm_bL_ops *ops) { if (arm_bL_ops != ops) { - pr_info("%s: Registered with: %s, can't unregister, exiting\n", + pr_err("%s: Registered with: %s, can't unregister, exiting\n", __func__, arm_bL_ops->name); + return; } _______________________________________________