From patchwork Mon Apr 28 23:24:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Herring X-Patchwork-Id: 4083211 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id D64C3BFF02 for ; Mon, 28 Apr 2014 23:33:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 10D5F201FB for ; Mon, 28 Apr 2014 23:33:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49369201EC for ; Mon, 28 Apr 2014 23:33:43 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wev1K-000397-OE; Mon, 28 Apr 2014 23:31:34 +0000 Received: from mail-vc0-x22d.google.com ([2607:f8b0:400c:c03::22d]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Wev18-0002k5-EZ for linux-arm-kernel@lists.infradead.org; Mon, 28 Apr 2014 23:31:22 +0000 Received: by mail-vc0-f173.google.com with SMTP id ik5so4873706vcb.32 for ; Mon, 28 Apr 2014 16:31:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=nga3W2xhYmc/4u6751cUUg2JqvQyBkfp+MVOF/w/M0s=; b=SZGQZ6KWPZ7grBFpJBhafBMnnkDybobFNLwMMQ+A/3m2Ff3RS0UYfHcDs2Klx+dih7 LaW3ci4ZGf/2Z7NdH8alIR2wyE1xN9AuhBmX/CDtdGNbm7X0LBnD4Dw0uJdZMFIXw0xb pxkcF+uoXKYeV6gFEWhRMY2ZGkgtfqtdadvJXsWdJPNu2DMc1GaviekK8pLmneV5frGy uVJfH4PHwEkaRFI5o1kpdoakTRBubybHn6VNiADNlTxcRKIULdUUDYQeJmpKCutKwgQw M4Bst3hTtk4b5nu1R1mtquKdQyQ4qrkbRq8tN5jI+C/A4nHb6gQamibb32tJ79/Zu2Jc vrDQ== MIME-Version: 1.0 X-Received: by 10.58.207.74 with SMTP id lu10mr25830603vec.15.1398727447122; Mon, 28 Apr 2014 16:24:07 -0700 (PDT) Received: by 10.220.50.132 with HTTP; Mon, 28 Apr 2014 16:24:07 -0700 (PDT) In-Reply-To: References: <1397859600-11507-1-git-send-email-robherring2@gmail.com> <1397859600-11507-4-git-send-email-robherring2@gmail.com> Date: Mon, 28 Apr 2014 18:24:07 -0500 Message-ID: Subject: Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon From: Rob Herring To: Yinghai Lu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20140428_163122_573395_F6BC274E X-CRM114-Status: GOOD ( 16.13 ) X-Spam-Score: 0.1 (/) Cc: Russell King , Arnd Bergmann , Catalin Marinas , Will Deacon , Linux Kernel Mailing List , "linux-serial@vger.kernel.org" , Greg Kroah-Hartman , Jiri Slaby , "linux-arm-kernel@lists.infradead.org" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Sat, Apr 26, 2014 at 1:29 AM, Yinghai Lu wrote: > On Fri, Apr 18, 2014 at 3:19 PM, Rob Herring wrote: >> From: Rob Herring >> >> With the generic earlycon infrastructure in place, convert the 8250 >> early console to use it. >> >> Signed-off-by: Rob Herring >> Cc: Greg Kroah-Hartman >> Cc: Jiri Slaby >> --- >> drivers/tty/serial/8250/8250_early.c | 138 ++++------------------------------- >> drivers/tty/serial/8250/Kconfig | 1 + >> 2 files changed, 16 insertions(+), 123 deletions(-) >> >> diff --git a/drivers/tty/serial/8250/8250_early.c b/drivers/tty/serial/8250/8250_early.c >> index c100d63..e83c9db 100644 >> --- a/drivers/tty/serial/8250/8250_early.c >> +++ b/drivers/tty/serial/8250/8250_early.c >> @@ -35,18 +35,8 @@ > ... >> - >> -int __init setup_early_serial8250_console(char *cmdline) > > You removed global function, but still left declaration and calling... > > arch/mips/mti-malta/malta-init.c: > setup_early_serial8250_console(console_string); > drivers/firmware/pcdp.c: return setup_early_serial8250_console(options); > include/linux/serial_8250.h:extern int > setup_early_serial8250_console(char *cmdline); Thanks for finding these. I missed them in my build tests. This should fix them: struct earlycon_device *device = early_device; diff --git a/drivers/tty/serial/8250/8250_early.c b/drivers/tty/serial/8250/8250_early.c index e83c9db..2094c3b 100644 --- a/drivers/tty/serial/8250/8250_early.c +++ b/drivers/tty/serial/8250/8250_early.c @@ -156,6 +156,11 @@ static int __init early_serial8250_setup(struct earlycon_device *device, EARLYCON_DECLARE(uart8250, early_serial8250_setup); EARLYCON_DECLARE(uart, early_serial8250_setup); +int __init setup_early_serial8250_console(char *cmdline) +{ + return setup_earlycon(cmdline, "uart8250", early_serial8250_setup); +} + int serial8250_find_port_for_earlycon(void) {