From patchwork Thu Sep 6 06:35:45 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Santosh Shilimkar X-Patchwork-Id: 1412161 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id 90B78DFFCF for ; Thu, 6 Sep 2012 06:38:51 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1T9VhE-0002F5-Ia; Thu, 06 Sep 2012 06:36:12 +0000 Received: from na3sys009aog115.obsmtp.com ([74.125.149.238]) by merlin.infradead.org with smtps (Exim 4.76 #1 (Red Hat Linux)) id 1T9VhA-0002Eo-PW for linux-arm-kernel@lists.infradead.org; Thu, 06 Sep 2012 06:36:09 +0000 Received: from mail-iy0-f199.google.com ([209.85.210.199]) (using TLSv1) by na3sys009aob115.postini.com ([74.125.148.12]) with SMTP ID DSNKUEhEVjZzmoJ+SP0UjK9oX9XhsYtS5BZo@postini.com; Wed, 05 Sep 2012 23:36:08 PDT Received: by iagt4 with SMTP id t4so3521366iag.6 for ; Wed, 05 Sep 2012 23:36:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-gm-message-state; bh=FqSp9pZGNnVfrLF/yKVNCMfHRMyHxxvzHzRDvWJFCLE=; b=nkE2xsh1nPSej45hjI/Cd/46ZHxICJaxL3GP7JPezlfwnkHzu+YLszgKqi76lfsgim otinbz81uaXkCaWaLIuTmPdw4FQfJYZ/4IW7m2+UFeVDDLvA/Dytm8hobZGh2xu78cKW VZg3+UTsbxccI95MVRbnTur5qlannheRYr9nRlJmfAytK7+YCp9X8RINcmk0YZsRp/07 vRfSziK1aLvpoNPTU4ed7Lx8gorlWCLmI84BeF6dpDfEbFq0bi1Fam/j2HhIRym+dNvk AxNImNd2WoLE/MEhA1WOS7A62zo+bIophmeLjE2aG5GNqOhuAxUkqdaQOelOg51pUZuP EdEA== Received: by 10.50.191.165 with SMTP id gz5mr1011449igc.50.1346913366077; Wed, 05 Sep 2012 23:36:06 -0700 (PDT) Received: by 10.50.191.165 with SMTP id gz5mr1011439igc.50.1346913365862; Wed, 05 Sep 2012 23:36:05 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.65.85 with HTTP; Wed, 5 Sep 2012 23:35:45 -0700 (PDT) In-Reply-To: References: From: "Shilimkar, Santosh" Date: Thu, 6 Sep 2012 12:05:45 +0530 Message-ID: Subject: Re: [PATCH] ARM: OMAP4: wakeupgen: remove duplicate AUXCOREBOOT* read/write To: Paul Walmsley X-Gm-Message-State: ALoCoQlR+WpmT4doC5cof2njbddxcrY6N6aVYZRXpM790Sfpc3Rsk/nzIdS/VVQUDazMvnGwTPpD5DBK1aMbknZSb5Ue8Rd8XiHAXQetdWpyNxSPOUaK+ZMWDTRWa0y65sSP4xun4ENh2YR5AHjcviNzudYqArV/3vk5tkRrsBTSTqBw4aCrDl10KjhOiNE7FFhGpM9Y8pjA X-Spam-Note: CRM114 invocation failed X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-4.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [74.125.149.238 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Thu, Sep 6, 2012 at 5:04 AM, Paul Walmsley wrote: > > The wakeupgen context-save code reads and stores the AUXCOREBOOT0 and > AUXCOREBOOT1 register contents twice. This seems like a waste of > time, so, remove the duplicates. > > Signed-off-by: Paul Walmsley > Cc: Santosh Shilimkar > --- Looks fine to me. Thanks Paul. Reviewed-by: Santosh Shilimkar ,santosh.shilimkar@ti.com> While reviewing your patch, i noticed a typo in the code. Since the patch fixes nearby code as the subject patch, I generated that patch on top of yours. Same is end of the email as well as attachment. The patch applies on top of your patch. Regards Santosh From 5fcd24e5782e502aa607b73de78be68b394f9639 Mon Sep 17 00:00:00 2001 From: Santosh Shilimkar Date: Thu, 6 Sep 2012 11:51:34 +0530 Subject: [PATCH] ARM: OMAP4: wakeupgen: Fix the typo in AUXCOREBOOT register save The wakeupgen context-save code reads AUXCOREBOOT0 register instead of AUXCOREBOOT1 register contents while saving AUXCOREBOOT1. Fix the same. Signed-off-by: Santosh Shilimkar --- arch/arm/mach-omap2/omap-wakeupgen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-omap2/omap-wakeupgen.c b/arch/arm/mach-omap2/omap-wakeupgen.c index b55432d..567f672 100644 --- a/arch/arm/mach-omap2/omap-wakeupgen.c +++ b/arch/arm/mach-omap2/omap-wakeupgen.c @@ -229,7 +229,7 @@ static inline void omap4_irq_save_context(void) /* Save AuxBoot* registers */ val = __raw_readl(wakeupgen_base + OMAP_AUX_CORE_BOOT_0); __raw_writel(val, sar_base + AUXCOREBOOT0_OFFSET); - val = __raw_readl(wakeupgen_base + OMAP_AUX_CORE_BOOT_0); + val = __raw_readl(wakeupgen_base + OMAP_AUX_CORE_BOOT_1); __raw_writel(val, sar_base + AUXCOREBOOT1_OFFSET); /* Save SyncReq generation logic */