From patchwork Fri Jan 4 16:12:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josh Coombs X-Patchwork-Id: 1933681 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork2.kernel.org (Postfix) with ESMTP id D7089DFABD for ; Fri, 4 Jan 2013 16:15:24 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Tr9sg-0007FZ-90; Fri, 04 Jan 2013 16:12:26 +0000 Received: from mail-oa0-f53.google.com ([209.85.219.53]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Tr9sc-0007EM-Hj for linux-arm-kernel@lists.infradead.org; Fri, 04 Jan 2013 16:12:23 +0000 Received: by mail-oa0-f53.google.com with SMTP id j6so15257304oag.12 for ; Fri, 04 Jan 2013 08:12:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=Ug0HfMDZN8anmMMV7yNEKFBn+orZR/cs7FDJbw/b2Ps=; b=Rvl7jc5OPN5O4BpMvlRAzFm4Hc+mju0h75/rLXkXZ/Y5/eubMSPEoav4od80h4KXui jxPkE5ZpbdqtJwkmCaprdTftZ8up4hVApLyuVefc5f9L+GSGU+BLADrIAb1nV7gobTGf mevpJ+BNGJdym4jlOG007bzVkVban3TzjsLUdDSyj9MWlsjxr246SvYzwq3BnNsFaQjW WsUxKs90OaDiCzBI9XkLysCiwtHXE5mOM98zrmgvZhCvzvreUd3ix149WlPRWD7KoBgh f8QZvddigkclvJc+amg3PKi2n+afXcBBttfaWN6t9u+JogHCmUk7M5n8etIf07kV6G9Z 2MLw== MIME-Version: 1.0 Received: by 10.182.212.70 with SMTP id ni6mr40186673obc.44.1357315940699; Fri, 04 Jan 2013 08:12:20 -0800 (PST) Received: by 10.76.166.129 with HTTP; Fri, 4 Jan 2013 08:12:20 -0800 (PST) Date: Fri, 4 Jan 2013 11:12:20 -0500 Message-ID: Subject: [Patch v1] arm: MVBEU Clk: Remove inappropriate __init tagging From: Josh Coombs To: linux ARM , Russell King - ARM Linux , Jason Cooper , Andrew Lunn , Sebastian Hesselbarth X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20130104_111222_827131_742C6098 X-CRM114-Status: UNSURE ( 8.22 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.219.53 listed in list.dnswl.org] 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (josh.coombs[at]gmail.com) -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org This is based on my prior problem report and discussion on a 3.8-rc1 kernel Oops and reboot hang. I've tested it on top of 3.8-rc2 with the pending missing clk for USB patch on my Seagate GoFlex Net successfully. Without this, 3.8 will not reboot on my system, the Orion WDT fails to probe correctly as well. MVEBU: Remove invalid __init tag from clk function Modules need to be able to use this function outside of kernel init. This corrects an Oops triggered by the Orion WDT driver being built as a module. Signed-off-by: Joshua Coombs --- a/drivers/clk/mvebu/clk-gating-ctrl.c 2013-01-02 21:13:21.000000000 -0500 +++ b/drivers/clk/mvebu/clk-gating-ctrl.c 2013-01-03 11:40:44.000000000 -0500 @@ -32,7 +32,7 @@ #define to_clk_gate(_hw) container_of(_hw, struct clk_gate, hw) -static struct clk __init *mvebu_clk_gating_get_src( +static struct clk *mvebu_clk_gating_get_src( struct of_phandle_args *clkspec, void *data) { struct mvebu_gating_ctrl *ctrl = (struct mvebu_gating_ctrl *)data;