From patchwork Fri Jan 23 22:42:17 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Baker X-Patchwork-Id: 5698111 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E19D6C058D for ; Fri, 23 Jan 2015 22:44:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E1978202FE for ; Fri, 23 Jan 2015 22:44:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFC0B2022A for ; Fri, 23 Jan 2015 22:44:35 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YEmwE-0000XU-J3; Fri, 23 Jan 2015 22:42:50 +0000 Received: from mail-wi0-f171.google.com ([209.85.212.171]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YEmw4-0000GR-9m for linux-arm-kernel@lists.infradead.org; Fri, 23 Jan 2015 22:42:41 +0000 Received: by mail-wi0-f171.google.com with SMTP id l15so79970wiw.4 for ; Fri, 23 Jan 2015 14:42:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=Pe6iTEFgSYCqUzSljH1wyGBkSfhCafutz0Ia9El7QNw=; b=f7xYECOKKmKe8nPgGmlGdxPrXObw/vMirzCfvHCeYJVIHCep1AuKwZ+ZGMGtEurCsS UH5xTE85rQAzh0n30Z1mR0riAsyxScQA6SkRhuufXUxYxJHYm+/3mar4oDS4RfDAXhm1 AVwQNyL8TUztvplhAtAznuf5bRb9gEXv1T/Rcx1p6p4GcRWU4snZ+2EwgxihZxkjkXES VzqHBNRDZkUjhszsX3IgXSfKoenc79tlTiNY0WtA4OilWRmvdPtWhjhxzKplfhe0UjN1 6Xe0sUdbgzzprvUr23zDdZ8StuBJ6+H7iwGGoNZQwasVXV3xNwoZJilHZZfUT5pU7nNy wemQ== X-Gm-Message-State: ALoCoQl3Kw9Q8i8wWoAuglY7RsjnybVPAUOrJ/5BKs+8lAIme1kTYaifBirRWpOB3KNSbKwX1sBR MIME-Version: 1.0 X-Received: by 10.180.91.201 with SMTP id cg9mr8272887wib.63.1422052937838; Fri, 23 Jan 2015 14:42:17 -0800 (PST) Received: by 10.27.125.195 with HTTP; Fri, 23 Jan 2015 14:42:17 -0800 (PST) In-Reply-To: <20150123202229.GA9038@node.dhcp.inet.fi> References: <54BD33DC.40200@ti.com> <20150119174317.GK20386@saruman> <20150120001643.7D15AA8@black.fi.intel.com> <20150120114555.GA11502@n2100.arm.linux.org.uk> <20150120140546.DDCB8D4@black.fi.intel.com> <20150123172736.GA15392@kahuna> <20150123183706.GA15791@kahuna> <20150123202229.GA9038@node.dhcp.inet.fi> Date: Fri, 23 Jan 2015 14:42:17 -0800 Message-ID: Subject: Re: [next-20150119]regression (mm)? From: Tyler Baker To: "Kirill A. Shutemov" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150123_144240_684037_964F39BA X-CRM114-Status: GOOD ( 21.20 ) X-Spam-Score: -0.7 (/) Cc: Nishanth Menon , Russell King - ARM Linux , Felipe Balbi , linux-mm@kvack.org, linux-next , "linux-arm-kernel@lists.infradead.org" , linux-omap , "Kirill A. Shutemov" X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Kirill, On 23 January 2015 at 12:22, Kirill A. Shutemov wrote: > On Fri, Jan 23, 2015 at 12:37:06PM -0600, Nishanth Menon wrote: >> On 09:39-20150123, Tyler Baker wrote: >> > Hi, >> > >> > On 23 January 2015 at 09:27, Nishanth Menon wrote: >> > > On 16:05-20150120, Kirill A. Shutemov wrote: >> > > [..] >> > >> Signed-off-by: Kirill A. Shutemov >> > >> Reported-by: Nishanth Menon >> > > Just to close on this thread: >> > > https://github.com/nmenon/kernel-test-logs/tree/next-20150123 looks good >> > > and back to old status. Thank you folks for all the help. >> > >> > I just reviewed the boot logs for next-20150123 and there still seems >> > to be a related issue. I've been boot testing >> > multi_v7_defconfig+CONFIG_ARM_LPAE=y kernel configurations which still >> > seem broken. >> > >> > For example here are two boots with exynos5250-arndale, one with >> > multi_v7_defconfig+CONFIG_ARM_LPAE=y [1] and the other with >> > multi_v7_defconfig[2]. You can see the kernel configurations with >> > CONFIG_ARM_LPAE=y show the splat: >> > >> > [ 14.605950] ------------[ cut here ]------------ >> > [ 14.609163] WARNING: CPU: 1 PID: 63 at ../mm/mmap.c:2858 >> > exit_mmap+0x1b8/0x224() >> > [ 14.616548] Modules linked in: >> > [ 14.619553] CPU: 1 PID: 63 Comm: init Not tainted 3.19.0-rc5-next-20150123 #1 >> > [ 14.626713] Hardware name: SAMSUNG EXYNOS (Flattened Device Tree) >> > [ 14.632830] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) >> > [ 14.640473] [] (show_stack) from [] (dump_stack+0x78/0x94) >> > [ 14.647678] [] (dump_stack) from [] (warn_slowpath_common+0x74/0xb0) >> > [ 14.655744] [] (warn_slowpath_common) from [] (warn_slowpath_null+0x1c/0x24) >> > [ 14.664510] [] (warn_slowpath_null) from [] (exit_mmap+0x1b8/0x224) >> > [ 14.672497] [] (exit_mmap) from [] (mmput+0x40/0xf8) >> > [ 14.679180] [] (mmput) from [] (flush_old_exec+0x328/0x604) >> > [ 14.686471] [] (flush_old_exec) from [] (load_elf_binary+0x26c/0x11f4) >> > [ 14.694715] [] (load_elf_binary) from [] (search_binary_handler+0x98/0x244) >> > [ 14.703395] [] (search_binary_handler) from [] >> > (do_execveat_common+0x4dc/0x5bc) >> > [ 14.712421] [] (do_execveat_common) from [] (do_execve+0x28/0x30) >> > [ 14.720235] [] (do_execve) from [] (ret_fast_syscall+0x0/0x34) >> > [ 14.727782] ---[ end trace 5e3ca48b454c7e0a ]--- >> > [ 14.733758] ------------[ cut here ]------------ >> > >> > Has anyone else tested with CONFIG_ARM_LPAE=y that can confirm my findings? >> Uggh... I missed since i was looking at non LPAE omap2plus_defconfig. >> >> Dual A15 OMAP5432 with multi_v7_defconfig + CONFIG_ARM_LPAE=y >> https://github.com/nmenon/kernel-test-logs/blob/next-20150123/multi_lpae_defconfig/omap5-evm.txt >> >> Dual A15 DRA7/AM572x with same configuration as above. >> https://raw.githubusercontent.com/nmenon/kernel-test-logs/next-20150123/multi_lpae_defconfig/dra7xx-evm.txt >> https://github.com/nmenon/kernel-test-logs/blob/next-20150123/multi_lpae_defconfig/am57xx-evm.txt >> >> Single A15 DRA72 with same configuration as above: >> https://raw.githubusercontent.com/nmenon/kernel-test-logs/next-20150123/multi_lpae_defconfig/dra72x-evm.txt >> >> You are right. the issue re-appears with LPAE on :( >> Apologies on missing that. > > Guys, could you instrument mm_{inc,dec}_nr_pmds() with dump_stack() + > printk() of the counter and add printk() on mmap_exit() then run a simple > program which triggers the issue? For reference, here is the patch I've applied for testing, mostly stolen from Felipe's debug patch above in this thread. I applied this patch to the tip of linux-next, configured for multi_v7_defconfig and set CONFIG_ARM_LPAE=y. The log for this arndale boot can be found here [1]. For good measure, I then rebuilt the kernel with CONFIG_ARM_LPAE=n and booted the same platform again. This log can be found here [2]. Happy hunting! > > -- > Kirill A. Shutemov [1] http://storage.kernelci.org/debug/mm/arndale-lpae-debug-next-20150123.html [2] http://storage.kernelci.org/debug/mm/arndale-no-lpae-debug-next-20150123.html Cheers, Tyler diff --git a/include/linux/mm.h b/include/linux/mm.h index 1fbd0e8..e5b0444 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -1455,11 +1455,17 @@ static inline unsigned long mm_nr_pmds(struct mm_struct *mm) static inline void mm_inc_nr_pmds(struct mm_struct *mm) { atomic_long_inc(&mm->nr_pmds); + dump_stack(); + printk(KERN_INFO "===> %s nr_pmds %ld\n", __func__, + atomic_long_read(&mm->nr_pmds)); } static inline void mm_dec_nr_pmds(struct mm_struct *mm) { atomic_long_dec(&mm->nr_pmds); + dump_stack(); + printk(KERN_INFO "===> %s nr_pmds %ld\n", __func__, + atomic_long_read(&mm->nr_pmds)); } #endif diff --git a/mm/mmap.c b/mm/mmap.c index 6a7d36d..a16471f 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -2809,6 +2809,7 @@ EXPORT_SYMBOL(vm_brk); /* Release all mmaps. */ void exit_mmap(struct mm_struct *mm) { + printk(KERN_INFO "===> %s exit_mmap enter\n", __func__); struct mmu_gather tlb; struct vm_area_struct *vma; unsigned long nr_accounted = 0;