From patchwork Thu Apr 13 21:35:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Baker X-Patchwork-Id: 9680039 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id ACF4560381 for ; Thu, 13 Apr 2017 21:35:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9CAA1286AC for ; Thu, 13 Apr 2017 21:35:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9101F286B3; Thu, 13 Apr 2017 21:35:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2C972286AC for ; Thu, 13 Apr 2017 21:35:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nlLHXYUU9zPJZouiVfcImOqWm+GRU2J/lvhH3hbHmZg=; b=ZVRaD7fwoR5PO9 5Ut5HSdK3ibZqzTBItzOS9G6iwZ8AL8KOyE0HPzWMz2zD7vBdGOIlDXFPNiWcNi18e7zraUN3SZcY x/ftoM1XJJgHzE93tLrX7NqXJ4lxRLG+Hxnbu/6TtdsN9qFziQCHwqVMoWb7Bchu9GSKdW8afqTUA aGdKsj2UBXoBlWl/2mrBv4UL2ktcfD3I5vhcS4VPkVWXpboCGONx+0VyHkbU6A1RWyRGgV2AvSkGp bSHpMuHkB8Ok+MDxcM/x0NkHUmJAE8VIq/9aUu8VxZ+RRCklztAwZyBxSGvwG9BBoYsBpcnY7OVpo Gx6X295gp8atZKZSVuRw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1cymP9-0001PI-3D; Thu, 13 Apr 2017 21:35:51 +0000 Received: from mail-io0-x22d.google.com ([2607:f8b0:4001:c06::22d]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1cymP5-0001MS-7e for linux-arm-kernel@lists.infradead.org; Thu, 13 Apr 2017 21:35:48 +0000 Received: by mail-io0-x22d.google.com with SMTP id l7so94150202ioe.3 for ; Thu, 13 Apr 2017 14:35:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=G5YizXnX0zBIt5+NBz5MK3Qb+bmxOuTdUvTCXKHA+Zk=; b=SPkkdz8HzoiWn5ErfRHMcW5rUAzvDSxf/+PcqrKyatdz3SQBIaCcOeTixhnliNHo2L pKxfhp9w7/G8/o9aVk+HAOBXLklac2fP6F/SlHLyFiXMvSa1qPfKrE0OyWdoHm94eXwG bT9qEjxo61UnbdZFxbBdVV99M9cnaEkMwmJ7M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=G5YizXnX0zBIt5+NBz5MK3Qb+bmxOuTdUvTCXKHA+Zk=; b=MV4IhxXhQNVT+bDRYoW5XgRTw9hfKA6g05SWEoiU+G+JUBFIKuxyGjDDeVMfyx5RXg YmKMlHuOD8rGqpxj1PMaEqrvh6UUEeVlViUo1432G1TVqP5mis9otsvKDvz1TulnPo5p 2UY4setIsLMTF1MKNUnbM9QLV1WjyC4ZAQ/I2SyMDozYQy/nF8+d/ip0vsmi/NwKVuoT roZULE7Rv31ephPGkmTqERe7yb4shrvzZaCqvMPs7Z6szPRvieAf6sIq2wIpjYKvFVSZ MLBTgLW1UnkzRpl/4ouYL5mDo/oVG5p4tOYhcck7gQOx+zsbSDQFCNJCFsPgc0JSlEMM jrAQ== X-Gm-Message-State: AN3rC/4G9BmmrgfpADGCw1fC+1FJ91ECos7AmbzWmrCptjxXWr2yIJl/ ttL12B0S4XKgaNmO0+unsau5unQYq+Ze X-Received: by 10.107.85.6 with SMTP id j6mr6799433iob.165.1492119326183; Thu, 13 Apr 2017 14:35:26 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.40.213 with HTTP; Thu, 13 Apr 2017 14:35:25 -0700 (PDT) In-Reply-To: References: <20170413133242.5068-1-andrew.smirnov@gmail.com> <20170413133242.5068-5-andrew.smirnov@gmail.com> From: Tyler Baker Date: Thu, 13 Apr 2017 14:35:25 -0700 Message-ID: Subject: Re: [PATCH 4/8] ARM: dts: imx7s: Add node for GPC To: Fabio Estevam X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170413_143547_322099_35BB3A13 X-CRM114-Status: GOOD ( 20.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "devicetree@vger.kernel.org" , Andrey Smirnov , Russell King , "linux-kernel@vger.kernel.org" , Rob Herring , Sascha Hauer , Fabio Estevam , Shawn Guo , linux-arm-kernel , yurovsky@gmail.com Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 13 April 2017 at 13:49, Fabio Estevam wrote: > On Thu, Apr 13, 2017 at 5:13 PM, Tyler Baker wrote: > >> I've rebased this series on the next-20170413 for sanity sake, and >> realized there doesn't appear to be a way to select CONFIG_IMX_GPCV2. >> I forced it using 'default y' and configured with imx_v6_v7_defconfig. >> Now my board is booting. Before this series is applied, it may be good >> to have CONFIG_IMX_GPCV2 selected specifically for iMX7 platform, >> otherwise there will be boot regressions. > > Something like this? > > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > index f03ef43..fe99a48 100644 > --- a/drivers/irqchip/Kconfig > +++ b/drivers/irqchip/Kconfig > @@ -253,6 +253,7 @@ config RENESAS_H8S_INTC > > config IMX_GPCV2 > bool > + def_bool y if SOC_IMX7D > select IRQ_DOMAIN > help > Enables the wakeup IRQs for IMX platforms with GPCv2 block Exactly. LGTM. >> I'd encounter a backtrace with next-20170413 + imx_v6_v7_defconfig + >> CONFIG_IMX_GPCV2=y >> >> Backtrace: >> [] (dump_backtrace) from [] (show_stack+0x18/0x1c) > > but prior to fixing the Kconfig we need to fix this backtrace you reported. I dug into this a bit, and lockdep is unhappy about spin locks not being initialized before use. The following patch fixes the backtrace on my board. I'll submit this patch in a moment. From: Tyler Baker Date: Thu, 13 Apr 2017 14:29:49 -0700 Subject: [PATCH] irqchip/irq-imx-gpcv2: fix spinlock initialization Call raw_spin_lock_init() before the spinlocks are used to prevent a lockdep splat. Signed-off-by: Tyler Baker Reviewed-by: Fabio Estevam --- drivers/irqchip/irq-imx-gpcv2.c | 2 ++ 1 file changed, 2 insertions(+) pr_err("fsl-gpcv2: unable to map gpc registers\n"); diff --git a/drivers/irqchip/irq-imx-gpcv2.c b/drivers/irqchip/irq-imx-gpcv2.c index e13236f..9463f35 100644 --- a/drivers/irqchip/irq-imx-gpcv2.c +++ b/drivers/irqchip/irq-imx-gpcv2.c @@ -230,6 +230,8 @@ static int __init imx_gpcv2_irqchip_init(struct device_node *node, return -ENOMEM; } + raw_spin_lock_init(&cd->rlock); + cd->gpc_base = of_iomap(node, 0); if (!cd->gpc_base) {