From patchwork Fri Jul 20 09:28:10 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkatraman S X-Patchwork-Id: 1220161 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id E6F433FC5A for ; Fri, 20 Jul 2012 09:33:30 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Ss9WH-0005w5-RM; Fri, 20 Jul 2012 09:29:09 +0000 Received: from [74.125.149.84] (helo=na3sys009aog135.obsmtp.com) by merlin.infradead.org with smtps (Exim 4.76 #1 (Red Hat Linux)) id 1Ss9WB-0005vn-8b for linux-arm-kernel@lists.infradead.org; Fri, 20 Jul 2012 09:29:04 +0000 Received: from mail-bk0-f45.google.com ([209.85.214.45]) (using TLSv1) by na3sys009aob135.postini.com ([74.125.148.12]) with SMTP ID DSNKUAkkv3pP6A4EbnzSb8ev2sQ77yZjsifr@postini.com; Fri, 20 Jul 2012 02:29:03 PDT Received: by bkcji1 with SMTP id ji1so3120799bkc.32 for ; Fri, 20 Jul 2012 02:28:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:x-gm-message-state; bh=4b3qqvnUYjHdOTYshP8YjO8Bg0KjoYMYIE/ywA4Lylk=; b=cdK4VWCWIGj1ERbQXoMoyqQsr/ECHGwezoMp5PEyfvCrEwDdy/VKc3yB544Ltk1Iop 9gKJ3fgK8r2616WluqtItlJqLsgk7I6CWhVbRnS0+jt04TnMlNgFno+UFgOTlPEF1Qwk qhgpKSn5OEZdGcv0pdijm4R5AsIzbcWu2lDue4adjnGYuGd/bsgRrtnecsE/8EV2sqG4 jQb7b7YNb0TNY39iLSIaxoXDfKTn9mdPi3aod0zuuxcIDtjYZWnqmEk79Iml8cXxh7nC sbsoSP1/3GLKMoRx0w68O9GDFr8AwUDwjEggcx38hLhlABD7vKlNw5NJSHGXWcxZsEVg LmRw== Received: by 10.204.130.10 with SMTP id q10mr2402773bks.90.1342776510351; Fri, 20 Jul 2012 02:28:30 -0700 (PDT) MIME-Version: 1.0 Received: by 10.205.119.8 with HTTP; Fri, 20 Jul 2012 02:28:10 -0700 (PDT) In-Reply-To: <20120719113246.GN6522@atomide.com> References: <20120718065951.GH6522@atomide.com> <20120718071039.GI6522@atomide.com> <20120719113246.GN6522@atomide.com> From: "S, Venkatraman" Date: Fri, 20 Jul 2012 14:58:10 +0530 Message-ID: Subject: Re: [PATCH 1/1] mmc: host: enable OMAP DMA engine support for omap hosts by default To: Tony Lindgren X-Gm-Message-State: ALoCoQnBIQDOuKzfzXbd79tdkCOrFNizrqFWOWNBU7jZtwBZ8/YsJLbrBQ24ZgNIWyZiBzgZ//bA X-Spam-Note: CRM114 invocation failed X-Spam-Score: -3.4 (---) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-3.4 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, medium trust [74.125.149.84 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.8 RDNS_NONE Delivered to internal network by a host with no rDNS Cc: Kevin Hilman , Javier Martinez Canillas , Chris Ball , Russell King , linux-mmc@vger.kernel.org, "Shilimkar, Santosh" , Javier Martinez Canillas , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Thu, Jul 19, 2012 at 5:02 PM, Tony Lindgren wrote: > * Shilimkar, Santosh [120718 02:49]: >> >> "The patch simply make them depend on DMA_OMAP since DMA_OMAP >> will select DMA_ENGINE automatically" >> >> This won't be true if the DMA selection are not done >> at ARCH_OMAP level as discussed in this thread. >> >> Having said that, I think Russell and Tony need to >> take call on how this needs to be handled. > > As the DMA channels can run out, drivers should also work > without DMA. And building everything as modules should be > possible for the distro kernels. > > So I'd rather not have either select or depends and have > the drivers fixed. > Ok - I'll work on getting polling mode to work, but as you know it's not the mode to get the best performance out of the device. I see that you've also merged the changes to omap2plus_defconfig, which should get MMC working as before DMA Engine conversion. There's a small patch needed to omap_hsmmc to return a non-zero error code during the probe error path. This will atleast make probe failure explicit when DMA is not available. Let me know if you want me to post it separately as a patch.. unsigned tx_req, rx_req; diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 2338703..892a046 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -1773,7 +1773,7 @@ static int __devinit omap_hsmmc_probe(struct platform_device *pdev) struct mmc_host *mmc; struct omap_hsmmc_host *host = NULL; struct resource *res; - int ret, irq; + int ret = -ENXIO, irq; const struct of_device_id *match; dma_cap_mask_t mask;