From patchwork Thu Dec 20 10:45:05 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 1899311 Return-Path: X-Original-To: patchwork-linux-arm@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork1.kernel.org Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by patchwork1.kernel.org (Postfix) with ESMTP id F3CD540061 for ; Thu, 20 Dec 2012 10:48:01 +0000 (UTC) Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Tldco-0007FI-Hk; Thu, 20 Dec 2012 10:45:14 +0000 Received: from mail-oa0-f48.google.com ([209.85.219.48]) by merlin.infradead.org with esmtps (Exim 4.76 #1 (Red Hat Linux)) id 1Tldch-0007D4-ID for linux-arm-kernel@lists.infradead.org; Thu, 20 Dec 2012 10:45:08 +0000 Received: by mail-oa0-f48.google.com with SMTP id h2so3102731oag.7 for ; Thu, 20 Dec 2012 02:45:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=krDyqcblqM+9OSGpl0e7tyLLAz9JhbT0gWn+oTE6tTY=; b=YCCKBccNXlgP8IoKjY8SQ5Zah5natZSxWKfQ1FyRMk6K05yS1bJjxz/FezBKi0Hma4 zSKdiH7X7VCb5j7nfj1hXL3H6RmshPWRQSyK/UsWU73JCyGo9CtZmUMeNWEV45n31z6X Qhd2MdsFioPkBwQmmey7PHs2L8L7te2IycEy7vOe7PQPsAu0ArR8Dt15uQ1Gr+9RR3lJ 6ZtmwL+qCh9i51Mcbw8IC/oIoilPTTmlYIFKnLd5AsQDzupSbnGIxNMYKyU/bck9yIV4 DdH2/nnMLvIzAmgbNBOecFgkC/7mx9LrpqkP2izJNVVGyumA2Lt4WJYsFr9WrKvjFVwf 7jCQ== MIME-Version: 1.0 Received: by 10.60.13.134 with SMTP id h6mr7390543oec.64.1356000305412; Thu, 20 Dec 2012 02:45:05 -0800 (PST) Received: by 10.76.33.34 with HTTP; Thu, 20 Dec 2012 02:45:05 -0800 (PST) In-Reply-To: References: <20121218024353.GA17118@kroah.com> <20121220043943.GA992@nchen-desktop> Date: Thu, 20 Dec 2012 08:45:05 -0200 Message-ID: Subject: Re: 3.7 kernel hangs when doing scp From: Fabio Estevam To: Peter Chen X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20121220_054507_925795_661CE7F6 X-CRM114-Status: GOOD ( 17.23 ) X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.3.2 on merlin.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (festevam[at]gmail.com) -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [209.85.219.48 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Cc: Li Frank-B20596 , alexander.shishkin@linux.intel.com, Greg KH , USB list , sebastian@breakpoint.cc, Sascha Hauer , Chen Peter-B29397 , Shawn Guo , linux-arm-kernel@lists.infradead.org X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-arm-kernel-bounces@lists.infradead.org Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org On Thu, Dec 20, 2012 at 8:20 AM, Fabio Estevam wrote: > Hi Peter, > > On Thu, Dec 20, 2012 at 2:39 AM, Peter Chen wrote: > >> Please to see if the Stream mode disable (bit4, usbmode) is set or not? >> If it is not, please try below patch >> >> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c >> index c97503b..258bc02 100644 >> --- a/drivers/usb/host/ehci-hcd.c >> +++ b/drivers/usb/host/ehci-hcd.c >> @@ -227,6 +227,7 @@ static void tdi_reset (struct ehci_hcd *ehci) >> >> tmp = ehci_readl(ehci, &ehci->regs->usbmode); >> tmp |= USBMODE_CM_HC; >> + tmp |= (1 << 4); /* disable stream mode */ >> /* The default byte access to MMR space is LE after >> * controller reset. Set the required endian mode >> * for transfer buffers to match the host microprocessor > > Excellent! Your suggestion made scp work with mx6 on 3.7. > > I assume that this "fix" or workaround would need a better place, right? > > Should this fix go into the chipidea host driver instead? > > Also, I wonder on how "standard" this USBMODE register is. i.e. there > is a deviation from the FSL EHCI USBMODE register. > I found it in include/linux/usb/ehci_def.h: > > #define USBMODE_SDIS (1<<3) /* Stream disable */ > > , which is at a different bit position from the i.MX6 Reference Manual: > > 4 SDIS Stream Disable Mode. (0 - Inactive [default]; 1 - Active) Would this be the correct fix? linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --- a/include/linux/usb/chipidea.h +++ b/include/linux/usb/chipidea.h @@ -18,7 +18,7 @@ struct ci13xxx_platform_data { #define CI13XXX_REGS_SHARED BIT(0) #define CI13XXX_REQUIRE_TRANSCEIVER BIT(1) #define CI13XXX_PULLUP_ON_VBUS BIT(2) -#define CI13XXX_DISABLE_STREAMING BIT(3) +#define CI13XXX_DISABLE_STREAMING BIT(4) _______________________________________________ linux-arm-kernel mailing list