diff mbox

[RFC,0/5] Use SRC to reset IP modules on i.MX5 and i.MX6

Message ID CAOMZO5C28qgH5DVooxYg5p6tA7bsFJshr4qxZEyp05A1LR3JWA@mail.gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Fabio Estevam Jan. 9, 2013, 5:57 p.m. UTC 
On Wed, Jan 9, 2013 at 3:53 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Wed, Jan 9, 2013 at 3:40 PM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
>
>> I rebased them onto next-20130109 (with this base compile-tested only).
>
> Just tested it, but unfortunately I still get the crash.

Ok, since I am on mx51 I just added a:


Thanks,

Fabio Estevam

Comments

Philipp Zabel Jan. 10, 2013, 2:36 p.m. UTC | #1 
Am Mittwoch, den 09.01.2013, 15:57 -0200 schrieb Fabio Estevam:
> On Wed, Jan 9, 2013 at 3:53 PM, Fabio Estevam <festevam@gmail.com> wrote:
> > On Wed, Jan 9, 2013 at 3:40 PM, Philipp Zabel <p.zabel@pengutronix.de> wrote:
> >
> >> I rebased them onto next-20130109 (with this base compile-tested only).
> >
> > Just tested it, but unfortunately I still get the crash.
> 
> Ok, since I am on mx51 I just added a:
> 
> diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi
> index 1f5d45e..8380b14 100644
> --- a/arch/arm/boot/dts/imx51.dtsi
> +++ b/arch/arm/boot/dts/imx51.dtsi
> @@ -67,6 +67,7 @@
>                         compatible = "fsl,imx51-ipu";
>                         reg = <0x40000000 0x20000000>;
>                         interrupts = <11 10>;
> +                       reset = <&src 2>;
>                 };
> 
> and now it works fine.

Thanks, sorry for missing the essential part for i.MX51.
So it seems hooking up the SRC to a common peripheral device reset call
is the way to go.

regards
Philipp
diff mbox

Patch

diff --git a/arch/arm/boot/dts/imx51.dtsi b/arch/arm/boot/dts/imx51.dtsi
index 1f5d45e..8380b14 100644
--- a/arch/arm/boot/dts/imx51.dtsi
+++ b/arch/arm/boot/dts/imx51.dtsi
@@ -67,6 +67,7 @@ 
                        compatible = "fsl,imx51-ipu";
                        reg = <0x40000000 0x20000000>;
                        interrupts = <11 10>;
+                       reset = <&src 2>;
                };

and now it works fine.